Re: [PATCH 05/13] media: i2c: Add .get_selection() support to ov8865

From: kernel test robot <lkp@intel.com>
To: Daniel Scally <djrscally@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Ezequiel Garcia <ezequiel@collabora.com>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Yang Li <yang.lee@linux.alibaba.com>,
	linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, linux-media@vger.kernel.org,
	Yong Zhi <yong.zhi@intel.com>
Subject: Re: [PATCH 05/13] media: i2c: Add .get_selection() support to ov8865
Date: Fri, 23 Jul 2021 16:13:02 +0800	[thread overview]
Message-ID: <202107231608.m8JDns5n-lkp@intel.com> (raw)
In-Reply-To: <20210722203407.3588046-6-djrscally@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2072 bytes --]

Hi Daniel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.14-rc2 next-20210722]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Daniel-Scally/Extensions-to-ov8865-driver/20210723-043624
base:   git://linuxtv.org/media_tree.git master
config: i386-randconfig-m021-20210723 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

smatch warnings:
drivers/media/i2c/ov8865.c:2784 ov8865_get_selection() warn: inconsistent indenting

vim +2784 drivers/media/i2c/ov8865.c

  2772	
  2773	static int ov8865_get_selection(struct v4l2_subdev *subdev,
  2774					struct v4l2_subdev_state *state,
  2775					struct v4l2_subdev_selection *sel)
  2776	{
  2777		struct ov8865_sensor *sensor = ov8865_subdev_sensor(subdev);
  2778	
  2779		switch (sel->target) {
  2780		case V4L2_SEL_TGT_CROP:
  2781			mutex_lock(&sensor->mutex);
  2782				__ov8865_get_pad_crop(sensor, state, sel->pad,
  2783						      sel->which, &sel->r);
> 2784			mutex_unlock(&sensor->mutex);
  2785			break;
  2786		case V4L2_SEL_TGT_NATIVE_SIZE:
  2787			sel->r.top = 0;
  2788			sel->r.left = 0;
  2789			sel->r.width = OV8865_NATIVE_WIDTH;
  2790			sel->r.height = OV8865_NATIVE_HEIGHT;
  2791			break;
  2792		case V4L2_SEL_TGT_CROP_BOUNDS:
  2793		case V4L2_SEL_TGT_CROP_DEFAULT:
  2794			sel->r.top = OV8865_ACTIVE_START_TOP;
  2795			sel->r.left = OV8865_ACTIVE_START_LEFT;
  2796			sel->r.width = OV8865_ACTIVE_WIDTH;
  2797			sel->r.height = OV8865_ACTIVE_HEIGHT;
  2798			break;
  2799		default:
  2800			return -EINVAL;
  2801		}
  2802	
  2803		return 0;
  2804	}
  2805	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41774 bytes --]