* [PATCH linux-next] s390:bitops: fix boolreturn.cocci warnings
@ 2021-08-24 6:37 CGEL
0 siblings, 0 replies; only message in thread
From: CGEL @ 2021-08-24 6:37 UTC (permalink / raw)
To: Heiko Carstens
Cc: Vasily Gorbik, Christian Borntraeger, Yury Norov,
Stephen Rothwell, Andrew Morton, linux-s390, linux-kernel,
Jing Yangyang, Zeal Robot
From: Jing Yangyang <jing.yangyang@zte.com.cn>
./arch/s390/include/asm/bitops.h:191:9-10:WARNING:return of 0/1 in
function 'arch_test_and_set_bit_lock' with return type bool
Return statements in functions returning bool should use true/false
instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn>
---
arch/s390/include/asm/bitops.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/include/asm/bitops.h b/arch/s390/include/asm/bitops.h
index f7cefdd..1d40630 100644
--- a/arch/s390/include/asm/bitops.h
+++ b/arch/s390/include/asm/bitops.h
@@ -188,7 +188,7 @@ static inline bool arch_test_and_set_bit_lock(unsigned long nr,
volatile unsigned long *ptr)
{
if (arch_test_bit(nr, ptr))
- return 1;
+ return true;
return arch_test_and_set_bit(nr, ptr);
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-08-24 6:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-24 6:37 [PATCH linux-next] s390:bitops: fix boolreturn.cocci warnings CGEL
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).