From: Daniel Palmer <daniel@0x0f.com>
To: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-leds@vger.kernel.org
Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com,
robh+dt@kernel.org, pavel@ucw.cz,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Daniel Palmer <daniel@0x0f.com>
Subject: [PATCH v2 04/11] gpio: msc313: Code clean ups
Date: Thu, 23 Sep 2021 15:54:53 +0900 [thread overview]
Message-ID: <20210923065500.2284347-5-daniel@0x0f.com> (raw)
In-Reply-To: <20210923065500.2284347-1-daniel@0x0f.com>
- Remove the unneeded assignment of ret before returning it.
- Remove an unneeded blank line
Signed-off-by: Daniel Palmer <daniel@0x0f.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpio/gpio-msc313.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-msc313.c b/drivers/gpio/gpio-msc313.c
index da31a5ff7a2b..a894bafbd4c3 100644
--- a/drivers/gpio/gpio-msc313.c
+++ b/drivers/gpio/gpio-msc313.c
@@ -344,7 +344,6 @@ static int msc313_gpio_probe(struct platform_device *pdev)
struct irq_domain *parent_domain;
struct device_node *parent_node;
struct device *dev = &pdev->dev;
- int ret;
match_data = of_device_get_match_data(dev);
if (!match_data)
@@ -399,8 +398,7 @@ static int msc313_gpio_probe(struct platform_device *pdev)
gpioirqchip->handler = handle_bad_irq;
gpioirqchip->default_type = IRQ_TYPE_NONE;
- ret = devm_gpiochip_add_data(dev, gpiochip, gpio);
- return ret;
+ return devm_gpiochip_add_data(dev, gpiochip, gpio);
}
static int msc313_gpio_remove(struct platform_device *pdev)
@@ -456,5 +454,4 @@ static struct platform_driver msc313_gpio_driver = {
.probe = msc313_gpio_probe,
.remove = msc313_gpio_remove,
};
-
builtin_platform_driver(msc313_gpio_driver);
--
2.33.0
next prev parent reply other threads:[~2021-09-23 6:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 6:54 [PATCH v2 00/11] gpio: msc313: Add gpio support for ssd20xd Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 01/11] dt-bindings: gpio: msc313: Add compatible " Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 02/11] dt-bindings: gpio: msc313: Add offsets " Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 03/11] dt-bindings: leds: Document "activity" trigger Daniel Palmer
2021-09-27 19:52 ` Rob Herring
2021-09-27 22:51 ` Daniel Palmer
2021-09-23 6:54 ` Daniel Palmer [this message]
2021-09-23 6:54 ` [PATCH v2 05/11] gpio: msc313: Add support for SSD201 and SSD202D Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 06/11] ARM: dts: mstar: Set gpio compatible for ssd20xd Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 07/11] ARM: dts: mstar: unitv2: Wire up LEDs Daniel Palmer
2021-11-30 18:55 ` Pavel Machek
2021-12-02 9:44 ` Daniel Palmer
2022-10-02 10:26 ` Pavel Machek
2021-09-23 6:54 ` [PATCH v2 08/11] ARM: dts: mstar: unitv2: Add core regulator Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 09/11] ARM: dts: mstar: unitv2: Add io regulator Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 10/11] ARM: dts: mstar: unitv2: Add DRAM regulator Daniel Palmer
2021-09-23 6:55 ` [PATCH v2 11/11] ARM: dts: mstar: unitv2: Add wifi switch Daniel Palmer
2021-11-19 13:11 ` [PATCH v2 00/11] gpio: msc313: Add gpio support for ssd20xd Daniel Palmer
2021-11-22 0:04 ` Linus Walleij
2021-11-22 10:01 ` Daniel Palmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923065500.2284347-5-daniel@0x0f.com \
--to=daniel@0x0f.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).