From: Pavel Machek <pavel@ucw.cz>
To: Daniel Palmer <daniel@0x0f.com>
Cc: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-leds@vger.kernel.org, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 07/11] ARM: dts: mstar: unitv2: Wire up LEDs
Date: Tue, 30 Nov 2021 19:55:58 +0100 [thread overview]
Message-ID: <20211130185558.GD30113@duo.ucw.cz> (raw)
In-Reply-To: <20210923065500.2284347-8-daniel@0x0f.com>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
Hi!
> Add the red and white leds present on the unitv2.
Thanks for cc-ing me.
> @@ -18,6 +20,18 @@ aliases {
> chosen {
> stdout-path = "serial0:115200n8";
> };
> +
> + leds {
> + compatible = "gpio-leds";
> + led-white {
> + gpios = <&gpio SSD20XD_GPIO_GPIO0 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "activity";
> + };
> + led-red {
> + gpios = <&gpio SSD20XD_GPIO_GPIO1 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "heartbeat";
> + };
> + };
How do these look in userspace (ls /sys/class/leds)? See
Documentation/devicetree/bindings/leds/common.yaml . Should the first
one be disk-activity?
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2021-11-30 18:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 6:54 [PATCH v2 00/11] gpio: msc313: Add gpio support for ssd20xd Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 01/11] dt-bindings: gpio: msc313: Add compatible " Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 02/11] dt-bindings: gpio: msc313: Add offsets " Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 03/11] dt-bindings: leds: Document "activity" trigger Daniel Palmer
2021-09-27 19:52 ` Rob Herring
2021-09-27 22:51 ` Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 04/11] gpio: msc313: Code clean ups Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 05/11] gpio: msc313: Add support for SSD201 and SSD202D Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 06/11] ARM: dts: mstar: Set gpio compatible for ssd20xd Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 07/11] ARM: dts: mstar: unitv2: Wire up LEDs Daniel Palmer
2021-11-30 18:55 ` Pavel Machek [this message]
2021-12-02 9:44 ` Daniel Palmer
2022-10-02 10:26 ` Pavel Machek
2021-09-23 6:54 ` [PATCH v2 08/11] ARM: dts: mstar: unitv2: Add core regulator Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 09/11] ARM: dts: mstar: unitv2: Add io regulator Daniel Palmer
2021-09-23 6:54 ` [PATCH v2 10/11] ARM: dts: mstar: unitv2: Add DRAM regulator Daniel Palmer
2021-09-23 6:55 ` [PATCH v2 11/11] ARM: dts: mstar: unitv2: Add wifi switch Daniel Palmer
2021-11-19 13:11 ` [PATCH v2 00/11] gpio: msc313: Add gpio support for ssd20xd Daniel Palmer
2021-11-22 0:04 ` Linus Walleij
2021-11-22 10:01 ` Daniel Palmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130185558.GD30113@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=bgolaszewski@baylibre.com \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).