* [PATCH -next] drivers/base/arch_topology.c: remove superfluous header
@ 2021-09-28 19:31 Mianhan Liu
2021-10-19 9:23 ` Sudeep Holla
0 siblings, 1 reply; 2+ messages in thread
From: Mianhan Liu @ 2021-09-28 19:31 UTC (permalink / raw)
To: Sudeep Holla, Greg Kroah-Hartman, Rafael J. Wysocki
Cc: linux-kernel, Mianhan Liu
arch_topology.c hasn't use any macro or function declared in linux/percpu.h,
linux/smp.h and linux/string.h.
Thus, these files can be removed from arch_topology.c safely without
affecting the compilation of the drivers/base/ module
Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn>
---
drivers/base/arch_topology.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index 434076659..92200873b 100644
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -12,15 +12,12 @@
#include <linux/device.h>
#include <linux/of.h>
#include <linux/slab.h>
-#include <linux/string.h>
#include <linux/sched/topology.h>
#include <linux/cpuset.h>
#include <linux/cpumask.h>
#include <linux/init.h>
-#include <linux/percpu.h>
#include <linux/rcupdate.h>
#include <linux/sched.h>
-#include <linux/smp.h>
static DEFINE_PER_CPU(struct scale_freq_data __rcu *, sft_data);
static struct cpumask scale_freq_counters_mask;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drivers/base/arch_topology.c: remove superfluous header
2021-09-28 19:31 [PATCH -next] drivers/base/arch_topology.c: remove superfluous header Mianhan Liu
@ 2021-10-19 9:23 ` Sudeep Holla
0 siblings, 0 replies; 2+ messages in thread
From: Sudeep Holla @ 2021-10-19 9:23 UTC (permalink / raw)
To: Mianhan Liu
Cc: Greg Kroah-Hartman, Rafael J. Wysocki, Sudeep Holla, linux-kernel
On Wed, Sep 29, 2021 at 03:31:38AM +0800, Mianhan Liu wrote:
> arch_topology.c hasn't use any macro or function declared in linux/percpu.h,
> linux/smp.h and linux/string.h.
> Thus, these files can be removed from arch_topology.c safely without
> affecting the compilation of the drivers/base/ module
>
> Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn>
>
> ---
> drivers/base/arch_topology.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
> index 434076659..92200873b 100644
> --- a/drivers/base/arch_topology.c
> +++ b/drivers/base/arch_topology.c
> @@ -12,15 +12,12 @@
> #include <linux/device.h>
> #include <linux/of.h>
> #include <linux/slab.h>
> -#include <linux/string.h>
> #include <linux/sched/topology.h>
> #include <linux/cpuset.h>
> #include <linux/cpumask.h>
> #include <linux/init.h>
> -#include <linux/percpu.h>
Don't you need linux/percpu-defs.h for DEFINE_PER_CPU then ?
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-19 9:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 19:31 [PATCH -next] drivers/base/arch_topology.c: remove superfluous header Mianhan Liu
2021-10-19 9:23 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).