* [PATCH] staging: r8188eu: remove rtl8188e_silentreset_for_specific_platform()
@ 2021-09-30 8:55 Michael Straube
2021-09-30 12:39 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Michael Straube @ 2021-09-30 8:55 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube
Function rtl8188e_silentreset_for_specific_platform() is empty, remove
it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/hal/rtl8188e_sreset.c | 6 ------
drivers/staging/r8188eu/include/rtl8188e_sreset.h | 1 -
drivers/staging/r8188eu/os_dep/ioctl_linux.c | 1 -
3 files changed, 8 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/rtl8188e_sreset.c b/drivers/staging/r8188eu/hal/rtl8188e_sreset.c
index 16fa249e35d3..a16f10b438ad 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_sreset.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_sreset.c
@@ -6,10 +6,6 @@
#include "../include/rtl8188e_sreset.h"
#include "../include/rtl8188e_hal.h"
-void rtl8188e_silentreset_for_specific_platform(struct adapter *padapter)
-{
-}
-
void rtl8188e_sreset_xmit_status_check(struct adapter *padapter)
{
struct hal_data_8188e *pHalData = GET_HAL_DATA(padapter);
@@ -24,7 +20,6 @@ void rtl8188e_sreset_xmit_status_check(struct adapter *padapter)
if (txdma_status != 0x00) {
DBG_88E("%s REG_TXDMA_STATUS:0x%08x\n", __func__, txdma_status);
rtw_write32(padapter, REG_TXDMA_STATUS, txdma_status);
- rtl8188e_silentreset_for_specific_platform(padapter);
}
/* total xmit irp = 4 */
current_time = jiffies;
@@ -38,7 +33,6 @@ void rtl8188e_sreset_xmit_status_check(struct adapter *padapter)
diff_time = jiffies_to_msecs(current_time - psrtpriv->last_tx_complete_time);
if (diff_time > 4000) {
DBG_88E("%s tx hang\n", __func__);
- rtl8188e_silentreset_for_specific_platform(padapter);
}
}
}
diff --git a/drivers/staging/r8188eu/include/rtl8188e_sreset.h b/drivers/staging/r8188eu/include/rtl8188e_sreset.h
index 880c5792d5dd..5d7fec78a27b 100644
--- a/drivers/staging/r8188eu/include/rtl8188e_sreset.h
+++ b/drivers/staging/r8188eu/include/rtl8188e_sreset.h
@@ -8,7 +8,6 @@
#include "drv_types.h"
#include "rtw_sreset.h"
-void rtl8188e_silentreset_for_specific_platform(struct adapter *padapter);
void rtl8188e_sreset_xmit_status_check(struct adapter *padapter);
void rtl8188e_sreset_linked_status_check(struct adapter *padapter);
diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
index dd47098ed1e5..852f8e0bbf64 100644
--- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
+++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
@@ -4005,7 +4005,6 @@ static int rtw_dbg_port(struct net_device *dev,
case 0x0f:
if (extra_arg == 0) {
DBG_88E("###### silent reset test.......#####\n");
- rtl8188e_silentreset_for_specific_platform(padapter);
}
break;
case 0x15:
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: r8188eu: remove rtl8188e_silentreset_for_specific_platform()
2021-09-30 8:55 [PATCH] staging: r8188eu: remove rtl8188e_silentreset_for_specific_platform() Michael Straube
@ 2021-09-30 12:39 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2021-09-30 12:39 UTC (permalink / raw)
To: Michael Straube; +Cc: gregkh, Larry.Finger, phil, linux-staging, linux-kernel
On Thu, Sep 30, 2021 at 10:55:42AM +0200, Michael Straube wrote:
> diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> index dd47098ed1e5..852f8e0bbf64 100644
> --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> @@ -4005,7 +4005,6 @@ static int rtw_dbg_port(struct net_device *dev,
> case 0x0f:
> if (extra_arg == 0) {
> DBG_88E("###### silent reset test.......#####\n");
> - rtl8188e_silentreset_for_specific_platform(padapter);
> }
This introduces a new checkpatch warning about unnessary curly braces.
Just delete the whole if statement.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-30 12:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30 8:55 [PATCH] staging: r8188eu: remove rtl8188e_silentreset_for_specific_platform() Michael Straube
2021-09-30 12:39 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).