* [PATCH v2] staging: rtl8712: Statements should start on a tabstop
@ 2021-09-30 12:27 Dawid Esterhuizen
2021-09-30 12:49 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Dawid Esterhuizen @ 2021-09-30 12:27 UTC (permalink / raw)
To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
linux-staging, linux-kernel
This path fixes four checkpatch.pl warnings:
Statements should start on a tabstop
Changes since v1:
- Removed the volatile comments as they served no purpose
- Fixed the styling with corrected spacing as per checkpatch.pl
for easier reading
Signed-off-by: Dawid Esterhuizen <desterhuizen@gmail.com>
---
drivers/staging/rtl8712/rtl871x_xmit.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
index 2e6afc7bb0a1..cdcbc87a3cad 100644
--- a/drivers/staging/rtl8712/rtl871x_xmit.h
+++ b/drivers/staging/rtl8712/rtl871x_xmit.h
@@ -182,11 +182,11 @@ struct sta_xmit_priv {
};
struct hw_txqueue {
- /*volatile*/ sint head;
- /*volatile*/ sint tail;
- /*volatile*/ sint free_sz; /*in units of 64 bytes*/
- /*volatile*/ sint free_cmdsz;
- /*volatile*/ sint txsz[8];
+ sint head;
+ sint tail;
+ sint free_sz; /* in units of 64 bytes */
+ sint free_cmdsz;
+ sint txsz[8];
uint ff_hwaddr;
uint cmd_hwaddr;
sint ac_tag;
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: rtl8712: Statements should start on a tabstop
2021-09-30 12:27 [PATCH v2] staging: rtl8712: Statements should start on a tabstop Dawid Esterhuizen
@ 2021-09-30 12:49 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2021-09-30 12:49 UTC (permalink / raw)
To: Dawid Esterhuizen
Cc: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
linux-staging, linux-kernel
On Thu, Sep 30, 2021 at 02:27:16PM +0200, Dawid Esterhuizen wrote:
> This path fixes four checkpatch.pl warnings:
>
> Statements should start on a tabstop
>
> Changes since v1:
> - Removed the volatile comments as they served no purpose
> - Fixed the styling with corrected spacing as per checkpatch.pl
> for easier reading
This part goes under the --- cut off line
>
> Signed-off-by: Dawid Esterhuizen <desterhuizen@gmail.com>
> ---
^^^
here.
Please send v3. ;)
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-30 12:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30 12:27 [PATCH v2] staging: rtl8712: Statements should start on a tabstop Dawid Esterhuizen
2021-09-30 12:49 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).