* [PATCH] power: reset: at91-reset: check properly the return value of devm_of_iomap
@ 2021-09-30 10:09 Claudiu Beznea
2021-10-02 15:44 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Claudiu Beznea @ 2021-09-30 10:09 UTC (permalink / raw)
To: sre, nicolas.ferre, alexandre.belloni, ludovic.desroches
Cc: linux-pm, linux-arm-kernel, linux-kernel, Claudiu Beznea,
Cristian Birsan
devm_of_iomap() returns error code or valid pointer. Check its return
value with IS_ERR().
Fixes: bd3127733f2c ("power: reset: at91-reset: use devm_of_iomap")
Reported-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
drivers/power/reset/at91-reset.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c
index 026649409135..64def79d557a 100644
--- a/drivers/power/reset/at91-reset.c
+++ b/drivers/power/reset/at91-reset.c
@@ -193,7 +193,7 @@ static int __init at91_reset_probe(struct platform_device *pdev)
return -ENOMEM;
reset->rstc_base = devm_of_iomap(&pdev->dev, pdev->dev.of_node, 0, NULL);
- if (!reset->rstc_base) {
+ if (IS_ERR(reset->rstc_base)) {
dev_err(&pdev->dev, "Could not map reset controller address\n");
return -ENODEV;
}
@@ -203,7 +203,7 @@ static int __init at91_reset_probe(struct platform_device *pdev)
for_each_matching_node_and_match(np, at91_ramc_of_match, &match) {
reset->ramc_lpr = (u32)match->data;
reset->ramc_base[idx] = devm_of_iomap(&pdev->dev, np, 0, NULL);
- if (!reset->ramc_base[idx]) {
+ if (IS_ERR(reset->ramc_base[idx])) {
dev_err(&pdev->dev, "Could not map ram controller address\n");
of_node_put(np);
return -ENODEV;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: reset: at91-reset: check properly the return value of devm_of_iomap
2021-09-30 10:09 [PATCH] power: reset: at91-reset: check properly the return value of devm_of_iomap Claudiu Beznea
@ 2021-10-02 15:44 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2021-10-02 15:44 UTC (permalink / raw)
To: Claudiu Beznea
Cc: nicolas.ferre, alexandre.belloni, ludovic.desroches, linux-pm,
linux-arm-kernel, linux-kernel, Cristian Birsan
[-- Attachment #1: Type: text/plain, Size: 1587 bytes --]
Hi,
On Thu, Sep 30, 2021 at 01:09:28PM +0300, Claudiu Beznea wrote:
> devm_of_iomap() returns error code or valid pointer. Check its return
> value with IS_ERR().
>
> Fixes: bd3127733f2c ("power: reset: at91-reset: use devm_of_iomap")
> Reported-by: Cristian Birsan <cristian.birsan@microchip.com>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/reset/at91-reset.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c
> index 026649409135..64def79d557a 100644
> --- a/drivers/power/reset/at91-reset.c
> +++ b/drivers/power/reset/at91-reset.c
> @@ -193,7 +193,7 @@ static int __init at91_reset_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> reset->rstc_base = devm_of_iomap(&pdev->dev, pdev->dev.of_node, 0, NULL);
> - if (!reset->rstc_base) {
> + if (IS_ERR(reset->rstc_base)) {
> dev_err(&pdev->dev, "Could not map reset controller address\n");
> return -ENODEV;
> }
> @@ -203,7 +203,7 @@ static int __init at91_reset_probe(struct platform_device *pdev)
> for_each_matching_node_and_match(np, at91_ramc_of_match, &match) {
> reset->ramc_lpr = (u32)match->data;
> reset->ramc_base[idx] = devm_of_iomap(&pdev->dev, np, 0, NULL);
> - if (!reset->ramc_base[idx]) {
> + if (IS_ERR(reset->ramc_base[idx])) {
> dev_err(&pdev->dev, "Could not map ram controller address\n");
> of_node_put(np);
> return -ENODEV;
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-02 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30 10:09 [PATCH] power: reset: at91-reset: check properly the return value of devm_of_iomap Claudiu Beznea
2021-10-02 15:44 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).