Re: [PATCH 3/8] rtc: max77686: rename day-of-month defines

From: kernel test robot <lkp@intel.com>
To: Luca Ceresoli <luca@lucaceresoli.net>, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, Luca Ceresoli <luca@lucaceresoli.net>,
	Lee Jones <lee.jones@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>
Subject: Re: [PATCH 3/8] rtc: max77686: rename day-of-month defines
Date: Tue, 12 Oct 2021 10:23:23 +0800	[thread overview]
Message-ID: <202110121046.9puZ56W2-lkp@intel.com> (raw)
In-Reply-To: <20211011155615.257529-4-luca@lucaceresoli.net>

[-- Attachment #1: Type: text/plain, Size: 3451 bytes --]

Hi Luca,

I love your patch! Yet something to improve:

[auto build test ERROR on lee-mfd/for-mfd-next]
[also build test ERROR on abelloni/rtc-next linux/master linus/master v5.15-rc5 next-20211011]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Luca-Ceresoli/Add-MAX77714-PMIC-minimal-driver-RTC-and-watchdog-only/20211012-042754
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: h8300-randconfig-r015-20211011 (attached as .config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/6fc9e86fa2de7918c36cb31070f4d4eb7d48bff0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Luca-Ceresoli/Add-MAX77714-PMIC-minimal-driver-RTC-and-watchdog-only/20211012-042754
        git checkout 6fc9e86fa2de7918c36cb31070f4d4eb7d48bff0
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=h8300 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/mfd/max77686.c: In function 'max77802_rtc_is_volatile_reg':
>> drivers/mfd/max77686.c:90:24: error: 'MAX77802_RTC_DATE' undeclared (first use in this function); did you mean 'MAX77802_RTC_AE2'?
      90 |                 reg == MAX77802_RTC_DATE);
         |                        ^~~~~~~~~~~~~~~~~
         |                        MAX77802_RTC_AE2
   drivers/mfd/max77686.c:90:24: note: each undeclared identifier is reported only once for each function it appears in
   drivers/mfd/max77686.c:91:1: error: control reaches end of non-void function [-Werror=return-type]
      91 | }
         | ^
   cc1: some warnings being treated as errors

vim +90 drivers/mfd/max77686.c

a259f3896a39ec Javier Martinez Canillas 2014-07-24  80  
a259f3896a39ec Javier Martinez Canillas 2014-07-24  81  static bool max77802_rtc_is_volatile_reg(struct device *dev, unsigned int reg)
a259f3896a39ec Javier Martinez Canillas 2014-07-24  82  {
a259f3896a39ec Javier Martinez Canillas 2014-07-24  83  	return (max77802_rtc_is_precious_reg(dev, reg) ||
a259f3896a39ec Javier Martinez Canillas 2014-07-24  84  		reg == MAX77802_RTC_SEC ||
a259f3896a39ec Javier Martinez Canillas 2014-07-24  85  		reg == MAX77802_RTC_MIN ||
a259f3896a39ec Javier Martinez Canillas 2014-07-24  86  		reg == MAX77802_RTC_HOUR ||
a259f3896a39ec Javier Martinez Canillas 2014-07-24  87  		reg == MAX77802_RTC_WEEKDAY ||
a259f3896a39ec Javier Martinez Canillas 2014-07-24  88  		reg == MAX77802_RTC_MONTH ||
a259f3896a39ec Javier Martinez Canillas 2014-07-24  89  		reg == MAX77802_RTC_YEAR ||
a259f3896a39ec Javier Martinez Canillas 2014-07-24 @90  		reg == MAX77802_RTC_DATE);
a259f3896a39ec Javier Martinez Canillas 2014-07-24  91  }
a259f3896a39ec Javier Martinez Canillas 2014-07-24  92  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32518 bytes --]