From: Luca Ceresoli <luca@lucaceresoli.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
linux-kernel@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
devicetree@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-watchdog@vger.kernel.org,
Chiwoong Byun <woong.byun@samsung.com>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH 6/8] mfd: max77714: Add driver for Maxim MAX77714 PMIC
Date: Wed, 13 Oct 2021 23:49:40 +0200 [thread overview]
Message-ID: <21684e2a-e84c-05ed-e27c-e710c53e3a64@lucaceresoli.net> (raw)
In-Reply-To: <79a3c52b-ed4a-dadb-c7e2-2c96c9a58c49@canonical.com>
Hi,
On 12/10/21 10:09, Krzysztof Kozlowski wrote:
> On 11/10/2021 17:56, Luca Ceresoli wrote:
>> Add a simple driver for the Maxim MAX77714 PMIC, supporting RTC and
>> watchdog only.
>>
>> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>> ---
>> MAINTAINERS | 2 +
>> drivers/mfd/Kconfig | 14 ++++
>> drivers/mfd/Makefile | 1 +
>> drivers/mfd/max77714.c | 151 +++++++++++++++++++++++++++++++++++
>> include/linux/mfd/max77714.h | 68 ++++++++++++++++
>> 5 files changed, 236 insertions(+)
>> create mode 100644 drivers/mfd/max77714.c
>> create mode 100644 include/linux/mfd/max77714.h
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 4d0134752537..df394192f14e 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -11389,6 +11389,8 @@ MAXIM MAX77714 PMIC MFD DRIVER
>> M: Luca Ceresoli <luca@lucaceresoli.net>
>> S: Maintained
>> F: Documentation/devicetree/bindings/mfd/maxim,max77714.yaml
>> +F: drivers/mfd/max77714.c
>> +F: include/linux/mfd/max77714.h
>>
>> MAXIM MAX77802 PMIC REGULATOR DEVICE DRIVER
>> M: Javier Martinez Canillas <javier@dowhile0.org>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index ca0edab91aeb..b5f6e6174508 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -853,6 +853,20 @@ config MFD_MAX77693
>> additional drivers must be enabled in order to use the functionality
>> of the device.
>>
>> +config MFD_MAX77714
>> + bool "Maxim Semiconductor MAX77714 PMIC Support"
>
> Why it cannot be a tristate (module)?
Because it's not done in the driver I initially copied from, I guess. :)
And also because I thought it's appropriate for a PMIC driver since
regulators tend to be always instantiated. But I understand there are
valid use cases for that -- will do in v2 unless a good reason pops up
for not doing it.
>> diff --git a/include/linux/mfd/max77714.h b/include/linux/mfd/max77714.h
>> new file mode 100644
>> index 000000000000..ca6b747b73c2
>> --- /dev/null
>> +++ b/include/linux/mfd/max77714.h
>> @@ -0,0 +1,68 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> +/*
>> + * Maxim MAX77714 Register and data structures definition.
>> + *
>> + * Copyright (C) 2021 Luca Ceresoli
>> + * Author: Luca Ceresoli <luca@lucaceresoli.net>
>> + */
>> +
>> +#ifndef _MFD_MAX77714_H_
>> +#define _MFD_MAX77714_H_
>
> Header guard:
> __LINUX_MFD_MAX77714_H_
OK.
>> +
>> +struct max77714 {
>> + struct device *dev;
>> + struct regmap *regmap;
>> + struct regmap_irq_chip_data *irq_data;
>> +
>> + int irq;
>> +};
>
> Do you have to make it a public structure? If not, please put it in the
> max77714.c
Good point. Will fix.
--
Luca
next prev parent reply other threads:[~2021-10-13 21:49 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 15:56 [PATCH 0/8] Add MAX77714 PMIC minimal driver (RTC and watchdog only) Luca Ceresoli
2021-10-11 15:56 ` [PATCH 1/8] mfd: max77686: Correct tab-based alignment of register addresses Luca Ceresoli
2021-10-12 8:00 ` Krzysztof Kozlowski
2021-10-11 15:56 ` [PATCH 2/8] rtc: max77686: convert comments to kernel-doc format Luca Ceresoli
2021-10-12 8:00 ` Krzysztof Kozlowski
2021-10-15 17:29 ` Alexandre Belloni
2021-10-11 15:56 ` [PATCH 3/8] rtc: max77686: rename day-of-month defines Luca Ceresoli
2021-10-12 2:23 ` kernel test robot
2021-10-12 2:58 ` kernel test robot
2021-10-12 8:13 ` Krzysztof Kozlowski
2021-10-11 15:56 ` [PATCH 4/8] rtc: max77686: remove useless variable Luca Ceresoli
2021-10-12 8:01 ` Krzysztof Kozlowski
2021-10-15 17:33 ` Alexandre Belloni
2021-10-15 20:59 ` Luca Ceresoli
2021-10-11 15:56 ` [PATCH 5/8] dt-bindings: mfd: add Maxim MAX77714 PMIC Luca Ceresoli
2021-10-12 8:02 ` Krzysztof Kozlowski
2021-10-13 21:28 ` Luca Ceresoli
2021-10-14 7:38 ` Krzysztof Kozlowski
2021-10-11 15:56 ` [PATCH 6/8] mfd: max77714: Add driver for " Luca Ceresoli
2021-10-11 17:15 ` Guenter Roeck
2021-10-12 7:11 ` kernel test robot
2021-10-12 8:09 ` Krzysztof Kozlowski
2021-10-13 21:49 ` Luca Ceresoli [this message]
2021-10-14 7:44 ` Krzysztof Kozlowski
2021-10-12 8:32 ` Krzysztof Kozlowski
2021-10-13 21:39 ` Luca Ceresoli
2021-10-14 7:40 ` Krzysztof Kozlowski
2021-10-14 8:25 ` Luca Ceresoli
2021-10-11 15:56 ` [PATCH 7/8] watchdog: max77714: add driver for the watchdog in the " Luca Ceresoli
2021-10-11 17:17 ` Guenter Roeck
2021-10-15 16:43 ` Luca Ceresoli
2021-10-12 1:18 ` Randy Dunlap
2021-10-15 16:42 ` Luca Ceresoli
2021-10-15 17:07 ` Randy Dunlap
2021-10-11 20:25 ` [PATCH 8/8] rtc: max77686: add MAX77714 support Luca Ceresoli
2021-10-11 16:12 ` Luca Ceresoli
2021-10-12 8:20 ` Krzysztof Kozlowski
2021-10-15 16:46 ` Luca Ceresoli
2021-10-12 8:29 ` Krzysztof Kozlowski
2021-10-15 17:36 ` Alexandre Belloni
2021-10-12 7:59 ` [PATCH 0/8] Add MAX77714 PMIC minimal driver (RTC and watchdog only) Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21684e2a-e84c-05ed-e27c-e710c53e3a64@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=woong.byun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).