linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* phy: rockchip-inno-usb2: Don't print useless error
@ 2021-11-07 18:58 Ondrej Jirman
  2021-11-07 19:19 ` Ondřej Jirman
  0 siblings, 1 reply; 2+ messages in thread
From: Ondrej Jirman @ 2021-11-07 18:58 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Vinod Koul, Heiko Stuebner, Peter Geis,
	Ondrej Jirman, Julia Lawall, kernel test robot, Tobias Schramm,
	open list:GENERIC PHY FRAMEWORK,
	moderated list:ARM/Rockchip SoC support,
	open list:ARM/Rockchip SoC support, open list

The interrupt is optional, make the dmesg not complain about it
missing.

Signed-off-by: Ondrej Jirman <megous@megous.com>
---
 drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
index 428c2313a9cb2..27820bee04eae 100644
--- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
+++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
@@ -1180,7 +1180,7 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
 	phy_cfgs = match->data;
 	rphy->chg_state = USB_CHG_STATE_UNDEFINED;
 	rphy->chg_type = POWER_SUPPLY_TYPE_UNKNOWN;
-	rphy->irq = platform_get_irq(pdev, 0);
+	rphy->irq = platform_get_irq_optional(pdev, 0);
 	platform_set_drvdata(pdev, rphy);
 
 	ret = rockchip_usb2phy_extcon_register(rphy);
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: phy: rockchip-inno-usb2: Don't print useless error
  2021-11-07 18:58 phy: rockchip-inno-usb2: Don't print useless error Ondrej Jirman
@ 2021-11-07 19:19 ` Ondřej Jirman
  0 siblings, 0 replies; 2+ messages in thread
From: Ondřej Jirman @ 2021-11-07 19:19 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Vinod Koul, Heiko Stuebner, Peter Geis,
	Julia Lawall, kernel test robot, Tobias Schramm,
	open list:GENERIC PHY FRAMEWORK,
	moderated list:ARM/Rockchip SoC support,
	open list:ARM/Rockchip SoC support, open list

On Sun, Nov 07, 2021 at 07:58:35PM +0100, megous hlavni wrote:
> The interrupt is optional, make the dmesg not complain about it
> missing.

Ooops. Sorry, this applies only on top of Peter Geis's 

"phy: phy-rockchip-inno-usb2: support muxed interrupts"

which is not mainline yet. Please ignore.

kind regards,
	o.

> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
>  drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> index 428c2313a9cb2..27820bee04eae 100644
> --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> @@ -1180,7 +1180,7 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
>  	phy_cfgs = match->data;
>  	rphy->chg_state = USB_CHG_STATE_UNDEFINED;
>  	rphy->chg_type = POWER_SUPPLY_TYPE_UNKNOWN;
> -	rphy->irq = platform_get_irq(pdev, 0);
> +	rphy->irq = platform_get_irq_optional(pdev, 0);
>  	platform_set_drvdata(pdev, rphy);
>  
>  	ret = rockchip_usb2phy_extcon_register(rphy);
> -- 
> 2.33.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-07 19:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-07 18:58 phy: rockchip-inno-usb2: Don't print useless error Ondrej Jirman
2021-11-07 19:19 ` Ondřej Jirman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).