linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: s3c/jive: add one more "fallthrough" statement
@ 2021-11-16  9:20 Arnd Bergmann
  2021-11-16 10:24 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-11-16  9:20 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Arnd Bergmann, Nathan Chancellor, Nick Desaulniers,
	Miquel Raynal, linux-arm-kernel, linux-samsung-soc, linux-kernel,
	llvm

From: Arnd Bergmann <arnd@arndb.de>

clang warns about one missing fallthrough that gcc ignores:

arch/arm/mach-s3c/mach-jive.c:250:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]

Add it here as well.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/mach-s3c/mach-jive.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-s3c/mach-jive.c b/arch/arm/mach-s3c/mach-jive.c
index 0785638a9069..285e1f0f4145 100644
--- a/arch/arm/mach-s3c/mach-jive.c
+++ b/arch/arm/mach-s3c/mach-jive.c
@@ -247,6 +247,7 @@ static int __init jive_mtdset(char *options)
 	case 1:
 		nand->nr_partitions = ARRAY_SIZE(jive_imageB_nand_part);
 		nand->partitions = jive_imageB_nand_part;
+		break;
 	case 0:
 		/* this is already setup in the nand info */
 		break;
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: s3c/jive: add one more "fallthrough" statement
  2021-11-16  9:20 [PATCH] ARM: s3c/jive: add one more "fallthrough" statement Arnd Bergmann
@ 2021-11-16 10:24 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-16 10:24 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Krzysztof Kozlowski, llvm, Nathan Chancellor, linux-arm-kernel,
	linux-samsung-soc, Arnd Bergmann, Miquel Raynal,
	Nick Desaulniers, linux-kernel

On Tue, 16 Nov 2021 10:20:42 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> clang warns about one missing fallthrough that gcc ignores:
> 
> arch/arm/mach-s3c/mach-jive.c:250:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
> 
> Add it here as well.
> 
> [...]

Applied, thanks!

[1/1] ARM: s3c/jive: add one more "fallthrough" statement
      commit: 7f9ec9b59c278f31b0c2c8fabcf564e6fc02d4d8

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-16 10:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-16  9:20 [PATCH] ARM: s3c/jive: add one more "fallthrough" statement Arnd Bergmann
2021-11-16 10:24 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).