linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Leon Romanovsky <leon@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jan Harkes <jaharkes@cs.cmu.edu>,
	coda@cs.cmu.edu, Paul Moore <paul@paul-moore.com>,
	Eric Paris <eparis@redhat.com>,
	Balbir Singh <bsingharora@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	codalist@coda.cs.cmu.edu, linux-audit@redhat.com
Cc: Leo Yan <leo.yan@linaro.org>
Subject: [PATCH v2 2/7] coresight: etm3x: Use task_is_in_init_pid_ns()
Date: Wed,  8 Dec 2021 16:33:15 +0800	[thread overview]
Message-ID: <20211208083320.472503-3-leo.yan@linaro.org> (raw)
In-Reply-To: <20211208083320.472503-1-leo.yan@linaro.org>

This patch replaces open code with task_is_in_init_pid_ns() to check if
a task is in root PID namespace.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
 drivers/hwtracing/coresight/coresight-etm3x-sysfs.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c
index e8c7649f123e..ff76cb56b727 100644
--- a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c
+++ b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c
@@ -1030,7 +1030,7 @@ static ssize_t ctxid_pid_show(struct device *dev,
 	 * Don't use contextID tracing if coming from a PID namespace.  See
 	 * comment in ctxid_pid_store().
 	 */
-	if (task_active_pid_ns(current) != &init_pid_ns)
+	if (!task_is_in_init_pid_ns(current))
 		return -EINVAL;
 
 	spin_lock(&drvdata->spinlock);
@@ -1058,7 +1058,7 @@ static ssize_t ctxid_pid_store(struct device *dev,
 	 * As such refuse to use the feature if @current is not in the initial
 	 * PID namespace.
 	 */
-	if (task_active_pid_ns(current) != &init_pid_ns)
+	if (!task_is_in_init_pid_ns(current))
 		return -EINVAL;
 
 	ret = kstrtoul(buf, 16, &pid);
@@ -1084,7 +1084,7 @@ static ssize_t ctxid_mask_show(struct device *dev,
 	 * Don't use contextID tracing if coming from a PID namespace.  See
 	 * comment in ctxid_pid_store().
 	 */
-	if (task_active_pid_ns(current) != &init_pid_ns)
+	if (!task_is_in_init_pid_ns(current))
 		return -EINVAL;
 
 	val = config->ctxid_mask;
@@ -1104,7 +1104,7 @@ static ssize_t ctxid_mask_store(struct device *dev,
 	 * Don't use contextID tracing if coming from a PID namespace.  See
 	 * comment in ctxid_pid_store().
 	 */
-	if (task_active_pid_ns(current) != &init_pid_ns)
+	if (!task_is_in_init_pid_ns(current))
 		return -EINVAL;
 
 	ret = kstrtoul(buf, 16, &val);
-- 
2.25.1


  parent reply	other threads:[~2021-12-08  8:33 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-08  8:33 [PATCH v2 0/7] pid: Introduce helper task_is_in_root_ns() Leo Yan
2021-12-08  8:33 ` [PATCH v2 1/7] pid: Introduce helper task_is_in_init_pid_ns() Leo Yan
2021-12-08  9:28   ` Leon Romanovsky
2021-12-08 10:25   ` Suzuki K Poulose
2021-12-14  5:55   ` Balbir Singh
2021-12-08  8:33 ` Leo Yan [this message]
2021-12-08 10:26   ` [PATCH v2 2/7] coresight: etm3x: Use task_is_in_init_pid_ns() Suzuki K Poulose
2021-12-14  5:55   ` Balbir Singh
2021-12-08  8:33 ` [PATCH v2 3/7] coresight: etm4x: " Leo Yan
2021-12-08 10:26   ` Suzuki K Poulose
2021-12-14  5:54   ` Balbir Singh
2021-12-08  8:33 ` [PATCH v2 4/7] connector/cn_proc: " Leo Yan
2021-12-14  5:58   ` Balbir Singh
2021-12-14  7:05     ` Leo Yan
2021-12-08  8:33 ` [PATCH v2 5/7] coda: " Leo Yan
2021-12-08  8:33 ` [PATCH v2 6/7] audit: " Leo Yan
2021-12-14  5:56   ` Balbir Singh
2021-12-14 22:35   ` Paul Moore
2021-12-15 19:09     ` Richard Guy Briggs
2021-12-16  1:09       ` Leo Yan
2021-12-08  8:33 ` [PATCH v2 7/7] taskstats: " Leo Yan
2021-12-14  5:56   ` Balbir Singh
2022-01-12  6:40 ` [PATCH v2 0/7] pid: Introduce helper task_is_in_root_ns() Leo Yan
2022-01-24  9:29   ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211208083320.472503-3-leo.yan@linaro.org \
    --to=leo.yan@linaro.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bsingharora@gmail.com \
    --cc=coda@cs.cmu.edu \
    --cc=codalist@coda.cs.cmu.edu \
    --cc=coresight@lists.linaro.org \
    --cc=davem@davemloft.net \
    --cc=eparis@redhat.com \
    --cc=jaharkes@cs.cmu.edu \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).