From: Leo Yan <leo.yan@linaro.org>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: Paul Moore <paul@paul-moore.com>,
codalist@telemann.coda.cs.cmu.edu,
Jan Harkes <jaharkes@cs.cmu.edu>,
Leon Romanovsky <leon@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
netdev@vger.kernel.org, Balbir Singh <bsingharora@gmail.com>,
linux-kernel@vger.kernel.org, Eric Paris <eparis@redhat.com>,
coda@cs.cmu.edu, linux-audit@redhat.com,
coresight@lists.linaro.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
Mike Leach <mike.leach@linaro.org>
Subject: Re: [PATCH v2 6/7] audit: Use task_is_in_init_pid_ns()
Date: Thu, 16 Dec 2021 09:09:32 +0800 [thread overview]
Message-ID: <20211216010932.GA2313631@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20211215190912.GU1550715@madcap2.tricolour.ca>
On Wed, Dec 15, 2021 at 02:09:12PM -0500, Richard Guy Briggs wrote:
> On 2021-12-14 17:35, Paul Moore wrote:
> > On Wed, Dec 8, 2021 at 3:33 AM Leo Yan <leo.yan@linaro.org> wrote:
> > >
> > > Replace open code with task_is_in_init_pid_ns() for checking root PID
> > > namespace.
> > >
> > > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> > > ---
> > > kernel/audit.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > I'm not sure how necessary this is, but it looks correct to me.
>
> I had the same thought. I looks correct to me. I could see the value
> if it permitted init_pid_ns to not be global.
Just for a background info, we need to check root PID namespace in some
drivers [1], to avoid introducing more open codes, we decided to refactor
with helper task_is_in_init_pid_ns().
[1] https://lore.kernel.org/lkml/20211213121323.1887180-1-leo.yan@linaro.org/
> > Acked-by: Paul Moore <paul@paul-moore.com>
>
> Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
Thanks for review, Paul and Richard.
Leo
next prev parent reply other threads:[~2021-12-16 1:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 8:33 [PATCH v2 0/7] pid: Introduce helper task_is_in_root_ns() Leo Yan
2021-12-08 8:33 ` [PATCH v2 1/7] pid: Introduce helper task_is_in_init_pid_ns() Leo Yan
2021-12-08 9:28 ` Leon Romanovsky
2021-12-08 10:25 ` Suzuki K Poulose
2021-12-14 5:55 ` Balbir Singh
2021-12-08 8:33 ` [PATCH v2 2/7] coresight: etm3x: Use task_is_in_init_pid_ns() Leo Yan
2021-12-08 10:26 ` Suzuki K Poulose
2021-12-14 5:55 ` Balbir Singh
2021-12-08 8:33 ` [PATCH v2 3/7] coresight: etm4x: " Leo Yan
2021-12-08 10:26 ` Suzuki K Poulose
2021-12-14 5:54 ` Balbir Singh
2021-12-08 8:33 ` [PATCH v2 4/7] connector/cn_proc: " Leo Yan
2021-12-14 5:58 ` Balbir Singh
2021-12-14 7:05 ` Leo Yan
2021-12-08 8:33 ` [PATCH v2 5/7] coda: " Leo Yan
2021-12-08 8:33 ` [PATCH v2 6/7] audit: " Leo Yan
2021-12-14 5:56 ` Balbir Singh
2021-12-14 22:35 ` Paul Moore
2021-12-15 19:09 ` Richard Guy Briggs
2021-12-16 1:09 ` Leo Yan [this message]
2021-12-08 8:33 ` [PATCH v2 7/7] taskstats: " Leo Yan
2021-12-14 5:56 ` Balbir Singh
2022-01-12 6:40 ` [PATCH v2 0/7] pid: Introduce helper task_is_in_root_ns() Leo Yan
2022-01-24 9:29 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211216010932.GA2313631@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bsingharora@gmail.com \
--cc=coda@cs.cmu.edu \
--cc=codalist@telemann.coda.cs.cmu.edu \
--cc=coresight@lists.linaro.org \
--cc=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=jaharkes@cs.cmu.edu \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).