linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephane Eranian <eranian@google.com>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, kim.phillips@amd.com, acme@redhat.com,
	jolsa@redhat.com, songliubraving@fb.com, mpe@ellerman.id.au,
	maddy@linux.ibm.com
Subject: [PATCH v4 04/14] perf/x86/amd: add branch-brs helper event for Fam19h BRS
Date: Fri, 10 Dec 2021 13:02:19 -0800	[thread overview]
Message-ID: <20211210210229.2991238-5-eranian@google.com> (raw)
In-Reply-To: <20211210210229.2991238-1-eranian@google.com>

This patch adds a pseudo event called branch-brs to help use the FAM Fam19h
Branch Sampling feature (BRS). BRS samples taken branches, so it is best used
when sampling on a retired taken branch event (0xc4) which is what BRS
captures.  Instead of trying to remember the event code or actual event name,
users can simply do:

$ perf record -b -e cpu/branch-brs/ -c 1000037 .....

Signed-off-by: Stephane Eranian <eranian@google.com>
---
 arch/x86/events/amd/core.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
index 44d8f618bb3e..597defee1e02 100644
--- a/arch/x86/events/amd/core.c
+++ b/arch/x86/events/amd/core.c
@@ -1105,8 +1105,24 @@ static struct attribute_group group_caps_amd_brs = {
 	.is_visible = amd_brs_is_visible,
 };
 
+#define AMD_FAM19H_BRS_EVENT 0xc4 /* Fam19h RETIRED_TAKEN_BRANCH_INSTRUCTIONS */
+EVENT_ATTR_STR(branch-brs, amd_branch_brs,
+	       "event=" __stringify(AMD_FAM19H_BRS_EVENT)"\n");
+
+static struct attribute *amd_brs_events_attrs[] = {
+	EVENT_PTR(amd_branch_brs),
+	NULL,
+};
+
+static struct attribute_group group_events_amd_brs = {
+	.name       = "events",
+	.attrs      = amd_brs_events_attrs,
+	.is_visible = amd_brs_is_visible,
+};
+
 static const struct attribute_group *amd_attr_update[] = {
 	&group_caps_amd_brs,
+	&group_events_amd_brs,
 	NULL,
 };
 
-- 
2.34.1.173.g76aa8bc2d0-goog


  parent reply	other threads:[~2021-12-10 21:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 21:02 [PATCH v4 00/14] perf/x86/amd: Add AMD Fam19h Branch Sampling support Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 01/14] perf/core: add perf_clear_branch_entry_bitfields() helper Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 02/14] x86/cpufeatures: add AMD Fam19h Branch Sampling feature Stephane Eranian
2021-12-10 21:21   ` Borislav Petkov
2021-12-10 21:25     ` Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 03/14] perf/x86/amd: add AMD Fam19h Branch Sampling support Stephane Eranian
2021-12-29  9:54   ` Like Xu
2022-01-03 23:24     ` Stephane Eranian
2021-12-10 21:02 ` Stephane Eranian [this message]
2021-12-10 21:02 ` [PATCH v4 05/14] perf/x86/amd: enable branch sampling priv level filtering Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 06/14] perf/x86/amd: add AMD branch sampling period adjustment Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 07/14] perf/x86/amd: make Zen3 branch sampling opt-in Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 08/14] ACPI: add perf low power callback Stephane Eranian
2021-12-13  5:56   ` kernel test robot
2021-12-13 22:40   ` kernel test robot
2021-12-23 13:11     ` Like Xu
2021-12-10 21:02 ` [PATCH v4 09/14] perf/x86/amd: add idle hooks for branch sampling Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 10/14] perf tools: add branch-brs as a new event Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 11/14] perf evsel: Make evsel__env always return a valid env Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 12/14] perf tools: Improve IBS error handling Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 13/14] perf tools: Improve error handling of AMD Branch Sampling Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 14/14] perf report: add addr_from/addr_to sort dimensions Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211210210229.2991238-5-eranian@google.com \
    --to=eranian@google.com \
    --cc=acme@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=kim.phillips@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=peterz@infradead.org \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).