linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Like Xu <like.xu.linux@gmail.com>
To: Stephane Eranian <eranian@google.com>, linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, kim.phillips@amd.com, acme@redhat.com,
	jolsa@redhat.com, songliubraving@fb.com, mpe@ellerman.id.au,
	maddy@linux.ibm.com
Subject: Re: [PATCH v4 03/14] perf/x86/amd: add AMD Fam19h Branch Sampling support
Date: Wed, 29 Dec 2021 17:54:27 +0800	[thread overview]
Message-ID: <9c8d02ff-74a6-b8ba-c19b-9ee20da9af12@gmail.com> (raw)
In-Reply-To: <20211210210229.2991238-4-eranian@google.com>

Hi Stephane,

On 11/12/2021 5:02 am, Stephane Eranian wrote:
> + * The BRS counter could be any counter, but there is no constraint on Fam19h,
> + * therefore all counters are equal and thus we pick the first one: PMC0

Are you assuming that no other counters can be enabled (guaranteed by the
patched perf context) when BRS is enabled ? Otherwise the hard-coding of
PMC0 may destroy scheduling freedom. Can we relax this condition?

Thanks,
Like Xu

  reply	other threads:[~2021-12-29  9:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 21:02 [PATCH v4 00/14] perf/x86/amd: Add AMD Fam19h Branch Sampling support Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 01/14] perf/core: add perf_clear_branch_entry_bitfields() helper Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 02/14] x86/cpufeatures: add AMD Fam19h Branch Sampling feature Stephane Eranian
2021-12-10 21:21   ` Borislav Petkov
2021-12-10 21:25     ` Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 03/14] perf/x86/amd: add AMD Fam19h Branch Sampling support Stephane Eranian
2021-12-29  9:54   ` Like Xu [this message]
2022-01-03 23:24     ` Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 04/14] perf/x86/amd: add branch-brs helper event for Fam19h BRS Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 05/14] perf/x86/amd: enable branch sampling priv level filtering Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 06/14] perf/x86/amd: add AMD branch sampling period adjustment Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 07/14] perf/x86/amd: make Zen3 branch sampling opt-in Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 08/14] ACPI: add perf low power callback Stephane Eranian
2021-12-13  5:56   ` kernel test robot
2021-12-13 22:40   ` kernel test robot
2021-12-23 13:11     ` Like Xu
2021-12-10 21:02 ` [PATCH v4 09/14] perf/x86/amd: add idle hooks for branch sampling Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 10/14] perf tools: add branch-brs as a new event Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 11/14] perf evsel: Make evsel__env always return a valid env Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 12/14] perf tools: Improve IBS error handling Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 13/14] perf tools: Improve error handling of AMD Branch Sampling Stephane Eranian
2021-12-10 21:02 ` [PATCH v4 14/14] perf report: add addr_from/addr_to sort dimensions Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c8d02ff-74a6-b8ba-c19b-9ee20da9af12@gmail.com \
    --to=like.xu.linux@gmail.com \
    --cc=acme@redhat.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=kim.phillips@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=peterz@infradead.org \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).