* [PATCH] drivers/misc/lis3lv02d/lis3lv02d_i2c.c: Check for error return from regulator_bulk_enable in lis3_i2c_init
@ 2022-01-06 6:56 Jiasheng Jiang
0 siblings, 0 replies; only message in thread
From: Jiasheng Jiang @ 2022-01-06 6:56 UTC (permalink / raw)
To: eric.piel, arnd, gregkh; +Cc: linux-kernel, Jiasheng Jiang
Because of the possible failure of the consumer, the
regulator_bulk_enable() may return error.
Therefore, it should be better to check the return value of the
lis3_reg_ctrl().
There are two callers, and I submit two patches to fix separately.
This patch is about lis3_i2c_init().
Fixes: ec400c9fab99 ("lis3lv02d: make regulator API usage unconditional")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/misc/lis3lv02d/lis3lv02d_i2c.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/lis3lv02d/lis3lv02d_i2c.c b/drivers/misc/lis3lv02d/lis3lv02d_i2c.c
index 52555d2e824b..4001e3c0a167 100644
--- a/drivers/misc/lis3lv02d/lis3lv02d_i2c.c
+++ b/drivers/misc/lis3lv02d/lis3lv02d_i2c.c
@@ -69,7 +69,9 @@ static int lis3_i2c_init(struct lis3lv02d *lis3)
u8 reg;
int ret;
- lis3_reg_ctrl(lis3, LIS3_REG_ON);
+ ret = lis3_reg_ctrl(lis3, LIS3_REG_ON);
+ if (ret)
+ return ret;
lis3->read(lis3, WHO_AM_I, ®);
if (reg != lis3->whoami)
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-01-06 6:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-06 6:56 [PATCH] drivers/misc/lis3lv02d/lis3lv02d_i2c.c: Check for error return from regulator_bulk_enable in lis3_i2c_init Jiasheng Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).