* [PATCH] HID: google: modify HID device groups of eel
@ 2021-12-28 11:46 xiazhengqiao
2022-01-06 9:21 ` xiazhengqiao
2022-01-06 14:29 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: xiazhengqiao @ 2021-12-28 11:46 UTC (permalink / raw)
To: jikos, benjamin.tissoires, linux-input, linux-kernel
Cc: phoenixshen, xiazhengqiao
EEL keyboard belongs to VIVALDI device.
Signed-off-by: xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com>
---
drivers/hid/hid-google-hammer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
index 0403beb3104b..e5acd15f4a55 100644
--- a/drivers/hid/hid-google-hammer.c
+++ b/drivers/hid/hid-google-hammer.c
@@ -585,7 +585,7 @@ static void hammer_remove(struct hid_device *hdev)
static const struct hid_device_id hammer_devices[] = {
{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_DON) },
- { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
+ { HID_DEVICE(BUS_USB, HID_GROUP_VIVALDI,
USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_EEL) },
{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_HAMMER) },
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: google: modify HID device groups of eel
2021-12-28 11:46 [PATCH] HID: google: modify HID device groups of eel xiazhengqiao
@ 2022-01-06 9:21 ` xiazhengqiao
2022-01-06 14:29 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: xiazhengqiao @ 2022-01-06 9:21 UTC (permalink / raw)
To: jikos, benjamin.tissoires, linux-input, linux-kernel; +Cc: phoenixshen
EEL keyboard belongs to VIVALDI device. I have tested it.
please help to review this.
thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: google: modify HID device groups of eel
2021-12-28 11:46 [PATCH] HID: google: modify HID device groups of eel xiazhengqiao
2022-01-06 9:21 ` xiazhengqiao
@ 2022-01-06 14:29 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2022-01-06 14:29 UTC (permalink / raw)
To: xiazhengqiao; +Cc: benjamin.tissoires, linux-input, linux-kernel, phoenixshen
On Tue, 28 Dec 2021, xiazhengqiao wrote:
> EEL keyboard belongs to VIVALDI device.
>
> Signed-off-by: xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com>
Could you please provide more verbose changelog? What user-observable
issue you are fixing here, etc.
Also, unless xiazhengqiao is your proper legal name, could you please
resubmit with a proper full name as indicated in
Documentation/process/submitting-patches.rst ?
Thanks!
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-06 14:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-28 11:46 [PATCH] HID: google: modify HID device groups of eel xiazhengqiao
2022-01-06 9:21 ` xiazhengqiao
2022-01-06 14:29 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).