* [PATCH net] net: hns3: handle empty unknown interrupt for VF
@ 2022-01-25 7:03 Guangbin Huang
2022-01-25 15:50 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Guangbin Huang @ 2022-01-25 7:03 UTC (permalink / raw)
To: davem, kuba, wangjie125
Cc: netdev, linux-kernel, lipeng321, huangguangbin2, chenhao288
From: Yufeng Mo <moyufeng@huawei.com>
Since some interrupt states may be cleared by hardware, the driver
may receive an empty interrupt. Currently, the VF driver directly
disables the vector0 interrupt in this case. As a result, the VF
is unavailable. Therefore, the vector0 interrupt should be enabled
in this case.
Fixes: b90fcc5bd904 ("net: hns3: add reset handling for VF when doing Core/Global/IMP reset")
Signed-off-by: Yufeng Mo <moyufeng@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
index 7df87610ad96..21442a9bb996 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
@@ -2043,8 +2043,7 @@ static irqreturn_t hclgevf_misc_irq_handle(int irq, void *data)
break;
}
- if (event_cause != HCLGEVF_VECTOR0_EVENT_OTHER)
- hclgevf_enable_vector(&hdev->misc_vector, true);
+ hclgevf_enable_vector(&hdev->misc_vector, true);
return IRQ_HANDLED;
}
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: hns3: handle empty unknown interrupt for VF
2022-01-25 7:03 [PATCH net] net: hns3: handle empty unknown interrupt for VF Guangbin Huang
@ 2022-01-25 15:50 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-01-25 15:50 UTC (permalink / raw)
To: Guangbin Huang
Cc: davem, wangjie125, netdev, linux-kernel, lipeng321, chenhao288
On Tue, 25 Jan 2022 15:03:12 +0800 Guangbin Huang wrote:
> From: Yufeng Mo <moyufeng@huawei.com>
>
> Since some interrupt states may be cleared by hardware, the driver
> may receive an empty interrupt. Currently, the VF driver directly
> disables the vector0 interrupt in this case. As a result, the VF
> is unavailable. Therefore, the vector0 interrupt should be enabled
> in this case.
>
> Fixes: b90fcc5bd904 ("net: hns3: add reset handling for VF when doing Core/Global/IMP reset")
> Signed-off-by: Yufeng Mo <moyufeng@huawei.com>
> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Applied, thanks:
2f61353cd2f7 ("net: hns3: handle empty unknown interrupt for VF")
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-25 15:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25 7:03 [PATCH net] net: hns3: handle empty unknown interrupt for VF Guangbin Huang
2022-01-25 15:50 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).