* [PATCH] ftrace: ensure trace buffer is at least 4096 bytes large
@ 2022-02-14 13:44 Sven Schnelle
2022-02-14 18:42 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Sven Schnelle @ 2022-02-14 13:44 UTC (permalink / raw)
To: Steven Rostedt, Ingo Molnar; +Cc: linux-kernel, Sven Schnelle
Booting the kernel with 'trace_buf_size=1' give a warning at
boot during the ftrace selftests:
[ 0.892809] Running postponed tracer tests:
[ 0.892893] Testing tracer function:
[ 0.901899] Callback from call_rcu_tasks_trace() invoked.
[ 0.983829] Callback from call_rcu_tasks_rude() invoked.
[ 1.072003] .. bad ring buffer .. corrupted trace buffer ..
[ 1.091944] Callback from call_rcu_tasks() invoked.
[ 1.097695] PASSED
[ 1.097701] Testing dynamic ftrace: .. filter failed count=0 ..FAILED!
[ 1.353474] ------------[ cut here ]------------
[ 1.353478] WARNING: CPU: 0 PID: 1 at kernel/trace/trace.c:1951 run_tracer_selftest+0x13c/0x1b0
Therefore enforce a minimum of 4096 bytes to make the selftest pass.
Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
---
kernel/trace/trace.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 7c2578efde26..3050892d1812 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -1474,10 +1474,12 @@ static int __init set_buf_size(char *str)
if (!str)
return 0;
buf_size = memparse(str, &str);
- /* nr_entries can not be zero */
- if (buf_size == 0)
- return 0;
- trace_buf_size = buf_size;
+ /*
+ * nr_entries can not be zero and the startup
+ * tests require some buffer space. Therefore
+ * ensure we have at least 4096 bytes of buffer.
+ */
+ trace_buf_size = max(4096UL, buf_size);
return 1;
}
__setup("trace_buf_size=", set_buf_size);
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ftrace: ensure trace buffer is at least 4096 bytes large
2022-02-14 13:44 [PATCH] ftrace: ensure trace buffer is at least 4096 bytes large Sven Schnelle
@ 2022-02-14 18:42 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2022-02-14 18:42 UTC (permalink / raw)
To: Sven Schnelle; +Cc: Ingo Molnar, linux-kernel
On Mon, 14 Feb 2022 14:44:56 +0100
Sven Schnelle <svens@linux.ibm.com> wrote:
> Booting the kernel with 'trace_buf_size=1' give a warning at
> boot during the ftrace selftests:
>
> [ 0.892809] Running postponed tracer tests:
> [ 0.892893] Testing tracer function:
> [ 0.901899] Callback from call_rcu_tasks_trace() invoked.
> [ 0.983829] Callback from call_rcu_tasks_rude() invoked.
> [ 1.072003] .. bad ring buffer .. corrupted trace buffer ..
> [ 1.091944] Callback from call_rcu_tasks() invoked.
> [ 1.097695] PASSED
> [ 1.097701] Testing dynamic ftrace: .. filter failed count=0 ..FAILED!
> [ 1.353474] ------------[ cut here ]------------
> [ 1.353478] WARNING: CPU: 0 PID: 1 at kernel/trace/trace.c:1951 run_tracer_selftest+0x13c/0x1b0
>
> Therefore enforce a minimum of 4096 bytes to make the selftest pass.
>
> Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
Thanks,
I'll queue this up for the next merge window.
-- Steve
> ---
> kernel/trace/trace.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 7c2578efde26..3050892d1812 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -1474,10 +1474,12 @@ static int __init set_buf_size(char *str)
> if (!str)
> return 0;
> buf_size = memparse(str, &str);
> - /* nr_entries can not be zero */
> - if (buf_size == 0)
> - return 0;
> - trace_buf_size = buf_size;
> + /*
> + * nr_entries can not be zero and the startup
> + * tests require some buffer space. Therefore
> + * ensure we have at least 4096 bytes of buffer.
> + */
> + trace_buf_size = max(4096UL, buf_size);
> return 1;
> }
> __setup("trace_buf_size=", set_buf_size);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-14 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-14 13:44 [PATCH] ftrace: ensure trace buffer is at least 4096 bytes large Sven Schnelle
2022-02-14 18:42 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).