From: Jung Daehwan <dh10.jung@samsung.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
quic_wcheng@quicinc.com, quic_jackp@quicinc.com,
Thinh.Nguyen@synopsys.com
Subject: Re: [PATCH v2 1/2] usb: dwc3: Not set DWC3_EP_END_TRANSFER_PENDING in ep cmd fails
Date: Tue, 15 Feb 2022 15:58:26 +0900 [thread overview]
Message-ID: <20220215065826.GD144890@ubuntu> (raw)
In-Reply-To: <Ygo9LZg8lxitTE8J@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]
On Mon, Feb 14, 2022 at 12:29:49PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 14, 2022 at 08:08:52PM +0900, Daehwan Jung wrote:
> > It always sets DWC3_EP_END_TRANSFER_PENDING in dwc3_stop_active_transfer
> > even if dwc3_send_gadget_ep_cmd fails. It can cause some problems like
> > skipping clear stall commmand or giveback from dequeue. We fix to set it
> > only when ep cmd success. Additionally, We clear DWC3_EP_TRANSFER_STARTED
> > for next trb to start transfer not update transfer.
>
> So is this two different changes?
>
> >
> > Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
>
> What commit id does this fix?
>
> thanks,
>
> greg k-h
>
Hi greg,
Below is commit id to fix.
commit c58d8bfc77a2c7f6ff6339b58c9fca7ae6f57e70
Author: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Date: Wed Dec 18 18:14:44 2019 -0800
usb: dwc3: gadget: Check END_TRANSFER completion
While the END_TRANSFER command is sent but not completed, any request
dequeue during this time will cause the driver to issue the END_TRANSFER
command. The driver needs to submit the command only once to stop the
controller from processing further. The controller may take more time to
process the same command multiple times unnecessarily. Let's add a flag
DWC3_EP_END_TRANSFER_PENDING to check for this condition.
Fixes: 3aec99154db3 ("usb: dwc3: gadget: remove DWC3_EP_END_TRANSFER_PENDING")
Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wesley may have run into same issue and I think it's better for us to discuss.
https://protect2.fireeye.com/v1/url?k=9d423b69-fc3fd32e-9d43b026-74fe485fff30-77a099b52659410d&q=1&e=20b4d9f5-2599-4f57-8b6a-7c4ec167d228&u=https%3A%2F%2Flore.kernel.org%2Flinux-usb%2F20220203080017.27339-1-quic_wcheng%40quicinc.com%2F
Best Regards,
Jung Daehwan
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2022-02-15 7:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220214111148epcas2p3fac143c7870c53ecadfb6b093fcf626b@epcas2p3.samsung.com>
2022-02-14 11:08 ` [PATCH v2 0/2] Fix ep command fail issue in dequeue Daehwan Jung
[not found] ` <CGME20220214111149epcas2p1a1faeda037991885fd6f2f026fa44ec5@epcas2p1.samsung.com>
2022-02-14 11:08 ` [PATCH v2 1/2] usb: dwc3: Not set DWC3_EP_END_TRANSFER_PENDING in ep cmd fails Daehwan Jung
2022-02-14 11:29 ` Greg Kroah-Hartman
2022-02-15 6:58 ` Jung Daehwan [this message]
2022-02-15 7:37 ` Greg Kroah-Hartman
2022-02-15 8:20 ` Jung Daehwan
2022-02-14 18:44 ` Thinh Nguyen
2022-02-15 6:39 ` Jung Daehwan
2022-02-15 17:14 ` Thinh Nguyen
2022-02-17 20:05 ` Wesley Cheng
2022-02-17 23:43 ` Thinh Nguyen
2022-02-22 18:08 ` Wesley Cheng
2022-02-23 2:59 ` Thinh Nguyen
2022-02-24 21:45 ` Wesley Cheng
2022-02-25 1:26 ` Thinh Nguyen
2022-02-25 1:31 ` Wesley Cheng
2022-02-25 1:44 ` Thinh Nguyen
2022-02-28 22:53 ` Wesley Cheng
2022-03-01 1:09 ` Thinh Nguyen
2022-03-01 2:09 ` Wesley Cheng
2022-03-01 3:02 ` Thinh Nguyen
2022-03-04 21:58 ` Wesley Cheng
2022-03-05 0:53 ` Thinh Nguyen
2022-03-07 22:57 ` Wesley Cheng
2022-03-07 23:51 ` Thinh Nguyen
2022-03-08 19:20 ` Wesley Cheng
2022-02-18 4:44 ` Jung Daehwan
2022-02-23 2:11 ` Thinh Nguyen
[not found] ` <CGME20220214111149epcas2p29b9e39b84d7203572422531beb3c39ed@epcas2p2.samsung.com>
2022-02-14 11:08 ` [PATCH v2 2/2] usb: dwc3: Prevent cleanup cancelled requests at the same time Daehwan Jung
2022-02-14 11:30 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215065826.GD144890@ubuntu \
--to=dh10.jung@samsung.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_jackp@quicinc.com \
--cc=quic_wcheng@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).