* [PATCH -next] HID: i2c-hid: remove unneeded semicolon
@ 2022-02-16 1:50 Yang Li
2022-02-16 15:30 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-02-16 1:50 UTC (permalink / raw)
To: jikos; +Cc: benjamin.tissoires, linux-input, linux-kernel, Yang Li, Abaci Robot
Eliminate the following coccicheck warning:
./drivers/hid/i2c-hid/i2c-hid-core.c:357:56-57: Unneeded semicolon
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/hid/i2c-hid/i2c-hid-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index 91b2fa0d33c7..c078f09a2318 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -354,7 +354,7 @@ static int i2c_hid_set_or_send_report(struct i2c_hid *ihid,
* With simple "send report" all data goes into the output
* register.
*/
- *(__le16 *)ihid->cmdbuf = ihid->hdesc.wOutputRegister;;
+ *(__le16 *)ihid->cmdbuf = ihid->hdesc.wOutputRegister;
length += sizeof(__le16);
}
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] HID: i2c-hid: remove unneeded semicolon
2022-02-16 1:50 [PATCH -next] HID: i2c-hid: remove unneeded semicolon Yang Li
@ 2022-02-16 15:30 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2022-02-16 15:30 UTC (permalink / raw)
To: Yang Li; +Cc: benjamin.tissoires, linux-input, linux-kernel, Abaci Robot
On Wed, 16 Feb 2022, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/hid/i2c-hid/i2c-hid-core.c:357:56-57: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/hid/i2c-hid/i2c-hid-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
> index 91b2fa0d33c7..c078f09a2318 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-core.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-core.c
> @@ -354,7 +354,7 @@ static int i2c_hid_set_or_send_report(struct i2c_hid *ihid,
> * With simple "send report" all data goes into the output
> * register.
> */
> - *(__le16 *)ihid->cmdbuf = ihid->hdesc.wOutputRegister;;
> + *(__le16 *)ihid->cmdbuf = ihid->hdesc.wOutputRegister;
> length += sizeof(__le16);
> }
Thanks, that was me fat-fingering the fixup in the original patch.
Applied.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-16 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16 1:50 [PATCH -next] HID: i2c-hid: remove unneeded semicolon Yang Li
2022-02-16 15:30 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).