From: Jeffle Xu <jefflexu@linux.alibaba.com>
To: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org,
chao@kernel.org, linux-erofs@lists.ozlabs.org
Cc: torvalds@linux-foundation.org, gregkh@linuxfoundation.org,
willy@infradead.org, linux-fsdevel@vger.kernel.org,
joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com,
tao.peng@linux.alibaba.com, gerry@linux.alibaba.com,
eguan@linux.alibaba.com, linux-kernel@vger.kernel.org,
luodaowen.backend@bytedance.com, tianzichen@kuaishou.com,
fannaihao@baidu.com
Subject: [PATCH v7 15/19] erofs: implement fscache-based metadata read
Date: Thu, 31 Mar 2022 19:57:49 +0800 [thread overview]
Message-ID: <20220331115753.89431-16-jefflexu@linux.alibaba.com> (raw)
In-Reply-To: <20220331115753.89431-1-jefflexu@linux.alibaba.com>
Implement the data plane of reading metadata from primary data blob
over fscache.
Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
---
fs/erofs/data.c | 20 ++++++++++++++++++--
fs/erofs/fscache.c | 38 ++++++++++++++++++++++++++++++++++++++
fs/erofs/internal.h | 9 +++++++++
3 files changed, 65 insertions(+), 2 deletions(-)
diff --git a/fs/erofs/data.c b/fs/erofs/data.c
index 14b64d960541..cb8fe299ad67 100644
--- a/fs/erofs/data.c
+++ b/fs/erofs/data.c
@@ -31,15 +31,26 @@ void erofs_put_metabuf(struct erofs_buf *buf)
void *erofs_bread(struct erofs_buf *buf, struct inode *inode,
erofs_blk_t blkaddr, enum erofs_kmap_type type)
{
- struct address_space *const mapping = inode->i_mapping;
erofs_off_t offset = blknr_to_addr(blkaddr);
pgoff_t index = offset >> PAGE_SHIFT;
struct page *page = buf->page;
if (!page || page->index != index) {
erofs_put_metabuf(buf);
- page = read_cache_page_gfp(mapping, index,
+ if (buf->sb) {
+ struct folio *folio;
+
+ folio = erofs_fscache_get_folio(buf->sb, index);
+ if (IS_ERR(folio))
+ page = ERR_CAST(folio);
+ else
+ page = folio_page(folio, 0);
+ } else {
+ struct address_space *const mapping = inode->i_mapping;
+
+ page = read_cache_page_gfp(mapping, index,
mapping_gfp_constraint(mapping, ~__GFP_FS));
+ }
if (IS_ERR(page))
return page;
/* should already be PageUptodate, no need to lock page */
@@ -63,6 +74,11 @@ void *erofs_bread(struct erofs_buf *buf, struct inode *inode,
void *erofs_read_metabuf(struct erofs_buf *buf, struct super_block *sb,
erofs_blk_t blkaddr, enum erofs_kmap_type type)
{
+ if (erofs_is_fscache_mode(sb)) {
+ buf->sb = sb;
+ return erofs_bread(buf, NULL, blkaddr, type);
+ }
+
return erofs_bread(buf, sb->s_bdev->bd_inode, blkaddr, type);
}
diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
index d38a6efc8e50..158cc273f8fb 100644
--- a/fs/erofs/fscache.c
+++ b/fs/erofs/fscache.c
@@ -34,9 +34,47 @@ static int erofs_fscache_read_folios(struct fscache_cookie *cookie,
return ret;
}
+static int erofs_fscache_meta_readpage(struct file *data, struct page *page)
+{
+ int ret;
+ struct super_block *sb = (struct super_block *)data;
+ struct folio *folio = page_folio(page);
+ struct erofs_map_dev mdev = {
+ .m_deviceid = 0,
+ .m_pa = folio_pos(folio),
+ };
+
+ ret = erofs_map_dev(sb, &mdev);
+ if (ret)
+ goto out;
+
+ ret = erofs_fscache_read_folios(mdev.m_fscache->cookie,
+ folio_file_mapping(folio), folio_pos(folio),
+ folio_size(folio), mdev.m_pa);
+ if (ret)
+ goto out;
+
+ folio_mark_uptodate(folio);
+out:
+ folio_unlock(folio);
+ return ret;
+}
+
static const struct address_space_operations erofs_fscache_meta_aops = {
+ .readpage = erofs_fscache_meta_readpage,
};
+/*
+ * Get the page cache of data blob at the index offset.
+ * Return: up to date page on success, ERR_PTR() on failure.
+ */
+struct folio *erofs_fscache_get_folio(struct super_block *sb, pgoff_t index)
+{
+ struct erofs_fscache *ctx = EROFS_SB(sb)->s_fscache;
+
+ return read_mapping_folio(ctx->inode->i_mapping, index, (void *)sb);
+}
+
/*
* Create an fscache context for data blob.
* Return: 0 on success and allocated fscache context is assigned to @fscache,
diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
index 90f7d6286a4f..e186051f0640 100644
--- a/fs/erofs/internal.h
+++ b/fs/erofs/internal.h
@@ -276,6 +276,7 @@ enum erofs_kmap_type {
};
struct erofs_buf {
+ struct super_block *sb;
struct page *page;
void *base;
enum erofs_kmap_type kmap_type;
@@ -639,6 +640,8 @@ int erofs_fscache_register_cookie(struct super_block *sb,
struct erofs_fscache **fscache,
char *name, bool need_inode);
void erofs_fscache_unregister_cookie(struct erofs_fscache **fscache);
+
+struct folio *erofs_fscache_get_folio(struct super_block *sb, pgoff_t index);
#else
static inline int erofs_fscache_register_fs(struct super_block *sb) { return 0; }
static inline void erofs_fscache_unregister_fs(struct super_block *sb) {}
@@ -653,6 +656,12 @@ static inline int erofs_fscache_register_cookie(struct super_block *sb,
static inline void erofs_fscache_unregister_cookie(struct erofs_fscache **fscache)
{
}
+
+static inline struct folio *erofs_fscache_get_folio(struct super_block *sb,
+ pgoff_t index)
+{
+ return ERR_PTR(-EOPNOTSUPP);
+}
#endif
#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
--
2.27.0
next prev parent reply other threads:[~2022-03-31 11:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 11:57 [PATCH v7 00/19] fscache,erofs: fscache-based on-demand read semantics Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 01/19] cachefiles: extract write routine Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 02/19] cachefiles: notify user daemon with anon_fd when looking up cookie Jeffle Xu
2022-04-02 5:32 ` JeffleXu
2022-03-31 11:57 ` [PATCH v7 03/19] cachefiles: notify user daemon when withdrawing cookie Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 04/19] cachefiles: implement on-demand read Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 05/19] cachefiles: enable on-demand read mode Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 06/19] cachefiles: document " Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 07/19] erofs: make erofs_map_blocks() generally available Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 08/19] erofs: add mode checking helper Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 09/19] erofs: register fscache volume Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 10/19] erofs: add fscache context helper functions Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 11/19] erofs: add anonymous inode managing page cache for data blob Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 12/19] erofs: add erofs_fscache_read_folios() helper Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 13/19] erofs: register fscache context for primary data blob Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 14/19] erofs: register fscache context for extra data blobs Jeffle Xu
2022-03-31 11:57 ` Jeffle Xu [this message]
2022-03-31 11:57 ` [PATCH v7 16/19] erofs: implement fscache-based data read for non-inline layout Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 17/19] erofs: implement fscache-based data read for inline layout Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 18/19] erofs: implement fscache-based data readahead Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 19/19] erofs: add 'fsid' mount option Jeffle Xu
2022-03-31 23:56 ` [PATCH v7 00/19] fscache,erofs: fscache-based on-demand read semantics JeffleXu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331115753.89431-16-jefflexu@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=bo.liu@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=dhowells@redhat.com \
--cc=eguan@linux.alibaba.com \
--cc=fannaihao@baidu.com \
--cc=gerry@linux.alibaba.com \
--cc=gregkh@linuxfoundation.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luodaowen.backend@bytedance.com \
--cc=tao.peng@linux.alibaba.com \
--cc=tianzichen@kuaishou.com \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).