From: Jeffle Xu <jefflexu@linux.alibaba.com>
To: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org,
chao@kernel.org, linux-erofs@lists.ozlabs.org
Cc: torvalds@linux-foundation.org, gregkh@linuxfoundation.org,
willy@infradead.org, linux-fsdevel@vger.kernel.org,
joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com,
tao.peng@linux.alibaba.com, gerry@linux.alibaba.com,
eguan@linux.alibaba.com, linux-kernel@vger.kernel.org,
luodaowen.backend@bytedance.com, tianzichen@kuaishou.com,
fannaihao@baidu.com
Subject: [PATCH v7 03/19] cachefiles: notify user daemon when withdrawing cookie
Date: Thu, 31 Mar 2022 19:57:37 +0800 [thread overview]
Message-ID: <20220331115753.89431-4-jefflexu@linux.alibaba.com> (raw)
In-Reply-To: <20220331115753.89431-1-jefflexu@linux.alibaba.com>
Notify user daemon that cookie is going to be withdrawn, providing a
hint that the associated anon_fd can be closed. The anon_fd attached in
the CLOSE request shall be same with that in the previous OPEN request.
Be noted that this is only a hint. User daemon can close the anon_fd
when receiving the CLOSE request, then it will receive another anon_fd
if the cookie gets looked up. Or it can also ignore the CLOSE request,
and keep writing data into the anon_fd. However the next time cookie
gets looked up, the user daemon will still receive another anon_fd.
Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
---
fs/cachefiles/interface.c | 2 ++
fs/cachefiles/internal.h | 5 +++++
fs/cachefiles/ondemand.c | 34 +++++++++++++++++++++++++++++++++
include/uapi/linux/cachefiles.h | 5 +++++
4 files changed, 46 insertions(+)
diff --git a/fs/cachefiles/interface.c b/fs/cachefiles/interface.c
index ae93cee9d25d..a69073a1d3f0 100644
--- a/fs/cachefiles/interface.c
+++ b/fs/cachefiles/interface.c
@@ -362,6 +362,8 @@ static void cachefiles_withdraw_cookie(struct fscache_cookie *cookie)
spin_unlock(&cache->object_list_lock);
}
+ cachefiles_ondemand_clean_object(object);
+
if (object->file) {
cachefiles_begin_secure(cache, &saved_cred);
cachefiles_clean_up_object(object, cache);
diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h
index 7d5c7d391fdb..8a397d4da560 100644
--- a/fs/cachefiles/internal.h
+++ b/fs/cachefiles/internal.h
@@ -279,6 +279,7 @@ extern int cachefiles_ondemand_copen(struct cachefiles_cache *cache,
char *args);
extern int cachefiles_ondemand_init_object(struct cachefiles_object *object);
+extern void cachefiles_ondemand_clean_object(struct cachefiles_object *object);
#else
static inline ssize_t cachefiles_ondemand_daemon_read(struct cachefiles_cache *cache,
@@ -291,6 +292,10 @@ static inline int cachefiles_ondemand_init_object(struct cachefiles_object *obje
{
return 0;
}
+
+static inline void cachefiles_ondemand_clean_object(struct cachefiles_object *object)
+{
+}
#endif
/*
diff --git a/fs/cachefiles/ondemand.c b/fs/cachefiles/ondemand.c
index f0e6e422263b..8cbfba057616 100644
--- a/fs/cachefiles/ondemand.c
+++ b/fs/cachefiles/ondemand.c
@@ -209,6 +209,12 @@ ssize_t cachefiles_ondemand_daemon_read(struct cachefiles_cache *cache,
goto err_put_fd;
}
+ /* CLOSE request has no reply */
+ if (msg->opcode == CACHEFILES_OP_CLOSE) {
+ xa_erase(&cache->reqs, id);
+ complete(&req->done);
+ }
+
return n;
err_put_fd:
@@ -332,6 +338,26 @@ static int init_open_req(struct cachefiles_req *req, void *private)
return 0;
}
+static int init_close_req(struct cachefiles_req *req, void *private)
+{
+ struct cachefiles_object *object = req->object;
+ struct cachefiles_close *load = (void *)req->msg.data;
+ int fd = object->fd;
+
+ if (WARN_ON_ONCE(fd == -1))
+ return -EIO;
+
+ /*
+ * It's possible if the cookie looking up phase failed before READ
+ * request has ever been sent.
+ */
+ if (fd == 0)
+ return -ENOENT;
+
+ load->fd = fd;
+ return 0;
+}
+
int cachefiles_ondemand_init_object(struct cachefiles_object *object)
{
struct fscache_cookie *cookie = object->cookie;
@@ -356,3 +382,11 @@ int cachefiles_ondemand_init_object(struct cachefiles_object *object)
CACHEFILES_OP_OPEN, data_len,
init_open_req, NULL);
}
+
+void cachefiles_ondemand_clean_object(struct cachefiles_object *object)
+{
+ cachefiles_ondemand_send_req(object,
+ CACHEFILES_OP_CLOSE,
+ sizeof(struct cachefiles_close),
+ init_close_req, NULL);
+}
diff --git a/include/uapi/linux/cachefiles.h b/include/uapi/linux/cachefiles.h
index 49cb7adb439a..dba97d284899 100644
--- a/include/uapi/linux/cachefiles.h
+++ b/include/uapi/linux/cachefiles.h
@@ -12,6 +12,7 @@
enum cachefiles_opcode {
CACHEFILES_OP_OPEN,
+ CACHEFILES_OP_CLOSE,
};
/*
@@ -36,4 +37,8 @@ struct cachefiles_open {
__u8 data[];
};
+struct cachefiles_close {
+ __u32 fd;
+};
+
#endif
--
2.27.0
next prev parent reply other threads:[~2022-03-31 11:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 11:57 [PATCH v7 00/19] fscache,erofs: fscache-based on-demand read semantics Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 01/19] cachefiles: extract write routine Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 02/19] cachefiles: notify user daemon with anon_fd when looking up cookie Jeffle Xu
2022-04-02 5:32 ` JeffleXu
2022-03-31 11:57 ` Jeffle Xu [this message]
2022-03-31 11:57 ` [PATCH v7 04/19] cachefiles: implement on-demand read Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 05/19] cachefiles: enable on-demand read mode Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 06/19] cachefiles: document " Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 07/19] erofs: make erofs_map_blocks() generally available Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 08/19] erofs: add mode checking helper Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 09/19] erofs: register fscache volume Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 10/19] erofs: add fscache context helper functions Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 11/19] erofs: add anonymous inode managing page cache for data blob Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 12/19] erofs: add erofs_fscache_read_folios() helper Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 13/19] erofs: register fscache context for primary data blob Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 14/19] erofs: register fscache context for extra data blobs Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 15/19] erofs: implement fscache-based metadata read Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 16/19] erofs: implement fscache-based data read for non-inline layout Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 17/19] erofs: implement fscache-based data read for inline layout Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 18/19] erofs: implement fscache-based data readahead Jeffle Xu
2022-03-31 11:57 ` [PATCH v7 19/19] erofs: add 'fsid' mount option Jeffle Xu
2022-03-31 23:56 ` [PATCH v7 00/19] fscache,erofs: fscache-based on-demand read semantics JeffleXu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331115753.89431-4-jefflexu@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=bo.liu@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=dhowells@redhat.com \
--cc=eguan@linux.alibaba.com \
--cc=fannaihao@baidu.com \
--cc=gerry@linux.alibaba.com \
--cc=gregkh@linuxfoundation.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luodaowen.backend@bytedance.com \
--cc=tao.peng@linux.alibaba.com \
--cc=tianzichen@kuaishou.com \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).