* [PATCH net] net: bcmgenet: Check for Wake-on-LAN interrupt probe deferral
@ 2022-05-11 3:17 Florian Fainelli
2022-05-11 6:01 ` Stefan Wahren
2022-05-12 8:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2022-05-11 3:17 UTC (permalink / raw)
To: netdev
Cc: Florian Fainelli, Doug Berger, Broadcom Kernel Team,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Sergey Shtylyov, Stefan Wahren, open list
The interrupt controller supplying the Wake-on-LAN interrupt line maybe
modular on some platforms (irq-bcm7038-l1.c) and might be probed at a
later time than the GENET driver. We need to specifically check for
-EPROBE_DEFER and propagate that error to ensure that we eventually
fetch the interrupt descriptor.
Fixes: 9deb48b53e7f ("bcmgenet: add WOL IRQ check")
Fixes: 5b1f0e62941b ("net: bcmgenet: Avoid touching non-existent interrupt")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index bf1ec8fdc2ad..e87e46c47387 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -3999,6 +3999,10 @@ static int bcmgenet_probe(struct platform_device *pdev)
goto err;
}
priv->wol_irq = platform_get_irq_optional(pdev, 2);
+ if (priv->wol_irq == -EPROBE_DEFER) {
+ err = priv->wol_irq;
+ goto err;
+ }
priv->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->base)) {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: bcmgenet: Check for Wake-on-LAN interrupt probe deferral
2022-05-11 3:17 [PATCH net] net: bcmgenet: Check for Wake-on-LAN interrupt probe deferral Florian Fainelli
@ 2022-05-11 6:01 ` Stefan Wahren
2022-05-12 8:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Wahren @ 2022-05-11 6:01 UTC (permalink / raw)
To: Florian Fainelli, netdev
Cc: Doug Berger, Broadcom Kernel Team, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Sergey Shtylyov, open list
Am 11.05.22 um 05:17 schrieb Florian Fainelli:
> The interrupt controller supplying the Wake-on-LAN interrupt line maybe
> modular on some platforms (irq-bcm7038-l1.c) and might be probed at a
> later time than the GENET driver. We need to specifically check for
> -EPROBE_DEFER and propagate that error to ensure that we eventually
> fetch the interrupt descriptor.
>
> Fixes: 9deb48b53e7f ("bcmgenet: add WOL IRQ check")
> Fixes: 5b1f0e62941b ("net: bcmgenet: Avoid touching non-existent interrupt")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index bf1ec8fdc2ad..e87e46c47387 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -3999,6 +3999,10 @@ static int bcmgenet_probe(struct platform_device *pdev)
> goto err;
> }
> priv->wol_irq = platform_get_irq_optional(pdev, 2);
> + if (priv->wol_irq == -EPROBE_DEFER) {
> + err = priv->wol_irq;
> + goto err;
> + }
>
> priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base)) {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: bcmgenet: Check for Wake-on-LAN interrupt probe deferral
2022-05-11 3:17 [PATCH net] net: bcmgenet: Check for Wake-on-LAN interrupt probe deferral Florian Fainelli
2022-05-11 6:01 ` Stefan Wahren
@ 2022-05-12 8:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-12 8:20 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, opendmb, bcm-kernel-feedback-list, davem, edumazet, kuba,
pabeni, s.shtylyov, wahrenst, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 10 May 2022 20:17:51 -0700 you wrote:
> The interrupt controller supplying the Wake-on-LAN interrupt line maybe
> modular on some platforms (irq-bcm7038-l1.c) and might be probed at a
> later time than the GENET driver. We need to specifically check for
> -EPROBE_DEFER and propagate that error to ensure that we eventually
> fetch the interrupt descriptor.
>
> Fixes: 9deb48b53e7f ("bcmgenet: add WOL IRQ check")
> Fixes: 5b1f0e62941b ("net: bcmgenet: Avoid touching non-existent interrupt")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
> [...]
Here is the summary with links:
- [net] net: bcmgenet: Check for Wake-on-LAN interrupt probe deferral
https://git.kernel.org/netdev/net/c/6b77c06655b8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-12 8:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-11 3:17 [PATCH net] net: bcmgenet: Check for Wake-on-LAN interrupt probe deferral Florian Fainelli
2022-05-11 6:01 ` Stefan Wahren
2022-05-12 8:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).