* [PATCH -next v2] vt: defkeymap.c_shipped remove unused variables
@ 2022-05-13 1:54 Zhang Jianhua
2022-05-16 7:00 ` Jiri Slaby
0 siblings, 1 reply; 3+ messages in thread
From: Zhang Jianhua @ 2022-05-13 1:54 UTC (permalink / raw)
To: gregkh, jirislaby, chris.zjh; +Cc: linux-kernel
The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have
been initialized but not used, they are redundant and remove them.
Signed-off-by: Zhang Jianhua <chris.zjh@huawei.com>
---
No code changes since v1, only remove the redundant line "--------" in
v1 commit message.
---
drivers/tty/vt/defkeymap.c_shipped | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/tty/vt/defkeymap.c_shipped b/drivers/tty/vt/defkeymap.c_shipped
index 094d95bf0005..80dee50bcb7a 100644
--- a/drivers/tty/vt/defkeymap.c_shipped
+++ b/drivers/tty/vt/defkeymap.c_shipped
@@ -185,10 +185,6 @@ char func_buf[] = {
'\033', '[', 'P', 0,
};
-char *funcbufptr = func_buf;
-int funcbufsize = sizeof(func_buf);
-int funcbufleft = 0; /* space left */
-
char *func_table[MAX_NR_FUNC] = {
func_buf + 0,
func_buf + 5,
--
2.31.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next v2] vt: defkeymap.c_shipped remove unused variables
2022-05-13 1:54 [PATCH -next v2] vt: defkeymap.c_shipped remove unused variables Zhang Jianhua
@ 2022-05-16 7:00 ` Jiri Slaby
2022-05-16 14:26 ` zhangjianhua (E)
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Slaby @ 2022-05-16 7:00 UTC (permalink / raw)
To: Zhang Jianhua, gregkh; +Cc: linux-kernel
On 13. 05. 22, 3:54, Zhang Jianhua wrote:
> The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have
> been initialized but not used, they are redundant and remove them.
>
> Signed-off-by: Zhang Jianhua <chris.zjh@huawei.com>
>
> ---
> No code changes since v1, only remove the redundant line "--------" in
> v1 commit message.
> ---
> drivers/tty/vt/defkeymap.c_shipped | 4 ----
The file header says:
/* Do not edit this file! It was automatically generated by */
/* loadkeys --mktable defkeymap.map > defkeymap.c */
So I'm not sure anyone wants to touch it.
> --- a/drivers/tty/vt/defkeymap.c_shipped
> +++ b/drivers/tty/vt/defkeymap.c_shipped
> @@ -185,10 +185,6 @@ char func_buf[] = {
> '\033', '[', 'P', 0,
> };
>
> -char *funcbufptr = func_buf;
> -int funcbufsize = sizeof(func_buf);
> -int funcbufleft = 0; /* space left */
> -
> char *func_table[MAX_NR_FUNC] = {
> func_buf + 0,
> func_buf + 5,
--
js
suse labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next v2] vt: defkeymap.c_shipped remove unused variables
2022-05-16 7:00 ` Jiri Slaby
@ 2022-05-16 14:26 ` zhangjianhua (E)
0 siblings, 0 replies; 3+ messages in thread
From: zhangjianhua (E) @ 2022-05-16 14:26 UTC (permalink / raw)
To: Jiri Slaby, gregkh; +Cc: linux-kernel
在 2022/5/16 15:00, Jiri Slaby 写道:
> On 13. 05. 22, 3:54, Zhang Jianhua wrote:
>> The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have
>> been initialized but not used, they are redundant and remove them.
>>
>> Signed-off-by: Zhang Jianhua <chris.zjh@huawei.com>
>>
>> ---
>> No code changes since v1, only remove the redundant line "--------" in
>> v1 commit message.
>> ---
>> drivers/tty/vt/defkeymap.c_shipped | 4 ----
>
> The file header says:
> /* Do not edit this file! It was automatically generated by */
> /* loadkeys --mktable defkeymap.map > defkeymap.c */
>
> So I'm not sure anyone wants to touch it.
This notes will be copied to the file defkeymap.c completely which is
automatically generated, so it says to defkeymap.c rather than defkeymap.map
>
>> --- a/drivers/tty/vt/defkeymap.c_shipped
>> +++ b/drivers/tty/vt/defkeymap.c_shipped
>> @@ -185,10 +185,6 @@ char func_buf[] = {
>> '\033', '[', 'P', 0,
>> };
>> -char *funcbufptr = func_buf;
>> -int funcbufsize = sizeof(func_buf);
>> -int funcbufleft = 0; /* space left */
>> -
>> char *func_table[MAX_NR_FUNC] = {
>> func_buf + 0,
>> func_buf + 5,
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-16 14:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-13 1:54 [PATCH -next v2] vt: defkeymap.c_shipped remove unused variables Zhang Jianhua
2022-05-16 7:00 ` Jiri Slaby
2022-05-16 14:26 ` zhangjianhua (E)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).