From: Stephen Kitt <steve@sk2.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Robin van der Gracht <robin@protonic.nl>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] auxdisplay: ht16k33: Use backlight helper
Date: Tue, 7 Jun 2022 23:02:31 +0200 [thread overview]
Message-ID: <20220607230231.07e36338@heffalump.sk2.org> (raw)
In-Reply-To: <CANiq72kRhmT37H1FAGYGny83ONYXeqJuO8ZPbym0ajQOWKY4Kw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]
Hi Miguel,
On Tue, 7 Jun 2022 21:08:34 +0200, Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
> On Tue, Jun 7, 2022 at 8:04 PM Stephen Kitt <steve@sk2.org> wrote:
> > backlight_properties.fb_blank is deprecated. The states it represents
> > are handled by other properties; but instead of accessing those
> > properties directly, drivers should use the helpers provided by
> > backlight.h.
> >
> > Instead of retrieving the backlight brightness in struct
> > backlight_properties manually, and then checking whether the backlight
> > should be on at all, use backlight_get_brightness() which does all
> > this and insulates this from future changes.
>
> Thanks for the patch! Looks good to me.
>
> There is a functional change in that `BL_CORE_SUSPENDED` is taken into
> account with this change, but I assume that is expected. In that case,
> it could be good to mention it in the commit message.
That’s a good point, and it is indeed expected; I’ll add it to the commit
message.
Regards,
Stephen
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-06-08 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 18:04 [PATCH] auxdisplay: ht16k33: Use backlight helper Stephen Kitt
2022-06-07 19:08 ` Miguel Ojeda
2022-06-07 21:02 ` Stephen Kitt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607230231.07e36338@heffalump.sk2.org \
--to=steve@sk2.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).