linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] arm64: dts: verdin-imx8mm: add otg2 pd to usbphy
@ 2022-08-11 14:07 Philippe Schenker
  2022-08-22  1:22 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Philippe Schenker @ 2022-08-11 14:07 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Frieder Schrempf, Peter Chen, Philippe Schenker, Fabio Estevam,
	Krzysztof Kozlowski, Marcel Ziswiler, NXP Linux Team,
	Pengutronix Kernel Team, Rob Herring, Sascha Hauer, devicetree,
	linux-arm-kernel, linux-kernel

From: Philippe Schenker <philippe.schenker@toradex.com>

The Verdin iMX8M Mini System on Module does not have USB-ID signal
connected on Verdin USB_2 (usbotg2). On Verdin Development board this is
no problem, as we have connected a USB-Hub that is always connected.

However, if Verdin USB_2 is desired to be used as a single USB-Host port
the chipidea driver does not detect if a USB device is plugged into this
port, due to runtime pm shutting down the PHY.

Add the power-domain &pgc_otg2 to &usbphynop2 in order to detect
plugging events and enumerate the usb device.

Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

---

Changes in v2:
- Changed word VBUS to USB-ID, as from mailinglist discussions I
  obviously mixed that up before.

 arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
index d1b4582f44c4..34808aa36c2b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
@@ -745,6 +745,7 @@ &usbphynop1 {
 };
 
 &usbphynop2 {
+	power-domains = <&pgc_otg2>;
 	vcc-supply = <&reg_vdd_3v3>;
 };
 
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] arm64: dts: verdin-imx8mm: add otg2 pd to usbphy
  2022-08-11 14:07 [PATCH v2] arm64: dts: verdin-imx8mm: add otg2 pd to usbphy Philippe Schenker
@ 2022-08-22  1:22 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2022-08-22  1:22 UTC (permalink / raw)
  To: Philippe Schenker
  Cc: Frieder Schrempf, Peter Chen, Philippe Schenker, Fabio Estevam,
	Krzysztof Kozlowski, Marcel Ziswiler, NXP Linux Team,
	Pengutronix Kernel Team, Rob Herring, Sascha Hauer, devicetree,
	linux-arm-kernel, linux-kernel

On Thu, Aug 11, 2022 at 04:07:38PM +0200, Philippe Schenker wrote:
> From: Philippe Schenker <philippe.schenker@toradex.com>
> 
> The Verdin iMX8M Mini System on Module does not have USB-ID signal
> connected on Verdin USB_2 (usbotg2). On Verdin Development board this is
> no problem, as we have connected a USB-Hub that is always connected.
> 
> However, if Verdin USB_2 is desired to be used as a single USB-Host port
> the chipidea driver does not detect if a USB device is plugged into this
> port, due to runtime pm shutting down the PHY.
> 
> Add the power-domain &pgc_otg2 to &usbphynop2 in order to detect
> plugging events and enumerate the usb device.
> 
> Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-08-22  1:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-11 14:07 [PATCH v2] arm64: dts: verdin-imx8mm: add otg2 pd to usbphy Philippe Schenker
2022-08-22  1:22 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).