* [resend PATCH v6 0/4] Mediatek ethernet patches for mt8188
@ 2022-09-28 9:23 Jianguo Zhang
2022-09-28 9:23 ` [resend PATCH v6 1/4] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Jianguo Zhang @ 2022-09-28 9:23 UTC (permalink / raw)
To: David S . Miller, Rob Herring, Krzysztof Kozlowski,
AngeloGioacchino Del Regno
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek, Jianguo Zhang
Changes in v6:
v6:
1) Update commit message of patch 'dt-bindings: net: snps,dwmac: add new property snps,clk-csr'
as Krzysztof Kozlowski'comment.
2) Add a parse for new property 'snps,clk-csr' in patch
'net: stmmac: add a parse for new property 'snps,clk-csr''
as AngeloGioacchino Del Regno's comment.
v5:
1) Rename the property 'clk_csr' as 'snps,clk-csr' in binding
file as Krzysztof Kozlowski'comment.
2) Add DTS patch 'arm64: dts: mediatek: mt2712e: Update the name of property 'clk_csr''
as Krzysztof Kozlowski'comment.
3) Add driver patch 'net: stmmac: Update the name of property 'clk_csr''
as Krzysztof Kozlowski'comment.
v4:
1) Update the commit message of patch 'dt-bindings: net: snps,dwmac: add clk_csr property'
as Krzysztof Kozlowski'comment.
v3:
1) List the names of SoCs mt8188 and mt8195 in correct order as
AngeloGioacchino Del Regno's comment.
2) Add patch version info as Krzysztof Kozlowski'comment.
v2:
1) Delete patch 'stmmac: dwmac-mediatek: add support for mt8188' as
Krzysztof Kozlowski's comment.
2) Update patch 'dt-bindings: net: mediatek-dwmac: add support for
mt8188' as Krzysztof Kozlowski's comment.
3) Add clk_csr property to fix warning ('clk_csr' was unexpected) when
runnig 'make dtbs_check'.
v1:
1) Add ethernet driver entry for mt8188.
2) Add binding document for ethernet on mt8188.
Jianguo Zhang (4):
dt-bindings: net: mediatek-dwmac: add support for mt8188
dt-bindings: net: snps,dwmac: add new property snps,clk-csr
arm64: dts: mediatek: mt2712e: Update the name of property 'clk_csr'
net: stmmac: add a parse for new property 'snps,clk-csr'
.../devicetree/bindings/net/mediatek-dwmac.yaml | 10 ++++++++--
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++
arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 2 +-
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 +++-
4 files changed, 17 insertions(+), 4 deletions(-)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [resend PATCH v6 1/4] dt-bindings: net: mediatek-dwmac: add support for mt8188
2022-09-28 9:23 [resend PATCH v6 0/4] Mediatek ethernet patches for mt8188 Jianguo Zhang
@ 2022-09-28 9:23 ` Jianguo Zhang
2022-09-28 9:23 ` [resend PATCH v6 2/4] dt-bindings: net: snps,dwmac: add new property snps,clk-csr Jianguo Zhang
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Jianguo Zhang @ 2022-09-28 9:23 UTC (permalink / raw)
To: David S . Miller, Rob Herring, Krzysztof Kozlowski,
AngeloGioacchino Del Regno
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek, Jianguo Zhang,
Krzysztof Kozlowski
Add binding document for the ethernet on mt8188
Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/net/mediatek-dwmac.yaml | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
index 61b2fb9e141b..0fa2132fa4f4 100644
--- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
@@ -19,6 +19,7 @@ select:
contains:
enum:
- mediatek,mt2712-gmac
+ - mediatek,mt8188-gmac
- mediatek,mt8195-gmac
required:
- compatible
@@ -37,6 +38,11 @@ properties:
- enum:
- mediatek,mt8195-gmac
- const: snps,dwmac-5.10a
+ - items:
+ - enum:
+ - mediatek,mt8188-gmac
+ - const: mediatek,mt8195-gmac
+ - const: snps,dwmac-5.10a
clocks:
minItems: 5
@@ -74,7 +80,7 @@ properties:
or will round down. Range 0~31*170.
For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550,
or will round down. Range 0~31*550.
- For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290,
+ For MT8188/MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290,
or will round down. Range 0~31*290.
mediatek,rx-delay-ps:
@@ -84,7 +90,7 @@ properties:
or will round down. Range 0~31*170.
For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550,
or will round down. Range 0~31*550.
- For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple
+ For MT8188/MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple
of 290, or will round down. Range 0~31*290.
mediatek,rmii-rxc:
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [resend PATCH v6 2/4] dt-bindings: net: snps,dwmac: add new property snps,clk-csr
2022-09-28 9:23 [resend PATCH v6 0/4] Mediatek ethernet patches for mt8188 Jianguo Zhang
2022-09-28 9:23 ` [resend PATCH v6 1/4] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang
@ 2022-09-28 9:23 ` Jianguo Zhang
2022-09-28 13:02 ` AngeloGioacchino Del Regno
2022-09-28 9:23 ` [resend PATCH v6 3/4] arm64: dts: mediatek: mt2712e: Update the name of property 'clk_csr' Jianguo Zhang
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Jianguo Zhang @ 2022-09-28 9:23 UTC (permalink / raw)
To: David S . Miller, Rob Herring, Krzysztof Kozlowski,
AngeloGioacchino Del Regno
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek, Jianguo Zhang,
Krzysztof Kozlowski
Add description for new property snps,clk-csr in binding file
Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 491597c02edf..4d5a56661322 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -288,6 +288,11 @@ properties:
is supported. For example, this is used in case of SGMII and
MAC2MAC connection.
+ snps,clk-csr:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ Frequency division factor for MDC clock.
+
mdio:
$ref: mdio.yaml#
unevaluatedProperties: false
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [resend PATCH v6 3/4] arm64: dts: mediatek: mt2712e: Update the name of property 'clk_csr'
2022-09-28 9:23 [resend PATCH v6 0/4] Mediatek ethernet patches for mt8188 Jianguo Zhang
2022-09-28 9:23 ` [resend PATCH v6 1/4] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang
2022-09-28 9:23 ` [resend PATCH v6 2/4] dt-bindings: net: snps,dwmac: add new property snps,clk-csr Jianguo Zhang
@ 2022-09-28 9:23 ` Jianguo Zhang
2022-09-28 13:03 ` AngeloGioacchino Del Regno
2022-09-28 9:23 ` [resend PATCH v6 4/4] net: stmmac: add a parse for new property 'snps,clk-csr' Jianguo Zhang
2022-09-30 1:49 ` [resend PATCH v6 0/4] Mediatek ethernet patches for mt8188 Jakub Kicinski
4 siblings, 1 reply; 9+ messages in thread
From: Jianguo Zhang @ 2022-09-28 9:23 UTC (permalink / raw)
To: David S . Miller, Rob Herring, Krzysztof Kozlowski,
AngeloGioacchino Del Regno
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek, Jianguo Zhang
Update the name of property 'clk_csr' as 'snps,clk-csr' to align with
the property name in the binding file.
Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
index 4797537cb368..e6d7453e56e0 100644
--- a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
@@ -756,7 +756,7 @@ eth: ethernet@1101c000 {
snps,mtl-tx-config = <&mtl_tx_setup>;
snps,txpbl = <1>;
snps,rxpbl = <1>;
- clk_csr = <0>;
+ snps,clk-csr = <0>;
status = "disabled";
};
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [resend PATCH v6 4/4] net: stmmac: add a parse for new property 'snps,clk-csr'
2022-09-28 9:23 [resend PATCH v6 0/4] Mediatek ethernet patches for mt8188 Jianguo Zhang
` (2 preceding siblings ...)
2022-09-28 9:23 ` [resend PATCH v6 3/4] arm64: dts: mediatek: mt2712e: Update the name of property 'clk_csr' Jianguo Zhang
@ 2022-09-28 9:23 ` Jianguo Zhang
2022-09-28 13:01 ` AngeloGioacchino Del Regno
2022-09-30 1:49 ` [resend PATCH v6 0/4] Mediatek ethernet patches for mt8188 Jakub Kicinski
4 siblings, 1 reply; 9+ messages in thread
From: Jianguo Zhang @ 2022-09-28 9:23 UTC (permalink / raw)
To: David S . Miller, Rob Herring, Krzysztof Kozlowski,
AngeloGioacchino Del Regno
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek, Jianguo Zhang
Parse new property 'snps,clk-csr' firstly because the new property
is documented in binding file, if failed, fall back to old property
'clk_csr' for legacy case
Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index 9f5cac4000da..3db6cb0b6124 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -444,7 +444,8 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
* or get clk_csr from device tree.
*/
plat->clk_csr = -1;
- of_property_read_u32(np, "clk_csr", &plat->clk_csr);
+ if (of_property_read_u32(np, "snps,clk-csr", &plat->clk_csr))
+ of_property_read_u32(np, "clk_csr", &plat->clk_csr);
/* "snps,phy-addr" is not a standard property. Mark it as deprecated
* and warn of its use. Remove this when phy node support is added.
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [resend PATCH v6 4/4] net: stmmac: add a parse for new property 'snps,clk-csr'
2022-09-28 9:23 ` [resend PATCH v6 4/4] net: stmmac: add a parse for new property 'snps,clk-csr' Jianguo Zhang
@ 2022-09-28 13:01 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 9+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-09-28 13:01 UTC (permalink / raw)
To: Jianguo Zhang, David S . Miller, Rob Herring, Krzysztof Kozlowski
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek
Il 28/09/22 11:23, Jianguo Zhang ha scritto:
> Parse new property 'snps,clk-csr' firstly because the new property
> is documented in binding file, if failed, fall back to old property
> 'clk_csr' for legacy case
>
> Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [resend PATCH v6 2/4] dt-bindings: net: snps,dwmac: add new property snps,clk-csr
2022-09-28 9:23 ` [resend PATCH v6 2/4] dt-bindings: net: snps,dwmac: add new property snps,clk-csr Jianguo Zhang
@ 2022-09-28 13:02 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 9+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-09-28 13:02 UTC (permalink / raw)
To: Jianguo Zhang, David S . Miller, Rob Herring, Krzysztof Kozlowski
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek, Krzysztof Kozlowski
Il 28/09/22 11:23, Jianguo Zhang ha scritto:
> Add description for new property snps,clk-csr in binding file
>
> Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [resend PATCH v6 3/4] arm64: dts: mediatek: mt2712e: Update the name of property 'clk_csr'
2022-09-28 9:23 ` [resend PATCH v6 3/4] arm64: dts: mediatek: mt2712e: Update the name of property 'clk_csr' Jianguo Zhang
@ 2022-09-28 13:03 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 9+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-09-28 13:03 UTC (permalink / raw)
To: Jianguo Zhang, David S . Miller, Rob Herring, Krzysztof Kozlowski
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek
Il 28/09/22 11:23, Jianguo Zhang ha scritto:
> Update the name of property 'clk_csr' as 'snps,clk-csr' to align with
> the property name in the binding file.
>
> Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [resend PATCH v6 0/4] Mediatek ethernet patches for mt8188
2022-09-28 9:23 [resend PATCH v6 0/4] Mediatek ethernet patches for mt8188 Jianguo Zhang
` (3 preceding siblings ...)
2022-09-28 9:23 ` [resend PATCH v6 4/4] net: stmmac: add a parse for new property 'snps,clk-csr' Jianguo Zhang
@ 2022-09-30 1:49 ` Jakub Kicinski
4 siblings, 0 replies; 9+ messages in thread
From: Jakub Kicinski @ 2022-09-30 1:49 UTC (permalink / raw)
To: Jianguo Zhang, Krzysztof Kozlowski, AngeloGioacchino Del Regno
Cc: David S . Miller, Rob Herring, Eric Dumazet, Paolo Abeni,
Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu,
Maxime Coquelin, Matthias Brugger, Biao Huang, netdev,
devicetree, linux-kernel, linux-stm32, linux-arm-kernel,
linux-mediatek
On Wed, 28 Sep 2022 17:23:04 +0800 Jianguo Zhang wrote:
> Jianguo Zhang (4):
> dt-bindings: net: mediatek-dwmac: add support for mt8188
> dt-bindings: net: snps,dwmac: add new property snps,clk-csr
> arm64: dts: mediatek: mt2712e: Update the name of property 'clk_csr'
> net: stmmac: add a parse for new property 'snps,clk-csr'
Are we supposed to drop patch 3 when applying this to net-next?
Do I understand this correctly?
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-09-30 1:50 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-28 9:23 [resend PATCH v6 0/4] Mediatek ethernet patches for mt8188 Jianguo Zhang
2022-09-28 9:23 ` [resend PATCH v6 1/4] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang
2022-09-28 9:23 ` [resend PATCH v6 2/4] dt-bindings: net: snps,dwmac: add new property snps,clk-csr Jianguo Zhang
2022-09-28 13:02 ` AngeloGioacchino Del Regno
2022-09-28 9:23 ` [resend PATCH v6 3/4] arm64: dts: mediatek: mt2712e: Update the name of property 'clk_csr' Jianguo Zhang
2022-09-28 13:03 ` AngeloGioacchino Del Regno
2022-09-28 9:23 ` [resend PATCH v6 4/4] net: stmmac: add a parse for new property 'snps,clk-csr' Jianguo Zhang
2022-09-28 13:01 ` AngeloGioacchino Del Regno
2022-09-30 1:49 ` [resend PATCH v6 0/4] Mediatek ethernet patches for mt8188 Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).