From: Herve Codina <herve.codina@bootlin.com>
To: Herve Codina <herve.codina@bootlin.com>,
Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Qiang Zhao <qiang.zhao@nxp.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: [PATCH v4 04/10] powerpc/8xx: Use a larger CPM1 command check mask
Date: Thu, 26 Jan 2023 09:32:16 +0100 [thread overview]
Message-ID: <20230126083222.374243-5-herve.codina@bootlin.com> (raw)
In-Reply-To: <20230126083222.374243-1-herve.codina@bootlin.com>
The CPM1 command mask is defined for use with the standard
CPM1 command register as described in the user's manual:
0 |1 3|4 7|8 11|12 14| 15|
RST| - |OPCODE|CH_NUM| - |FLG|
In the QMC extension the CPM1 command register is redefined
(QMC supplement user's manuel) with the following mapping:
0 |1 3|4 7|8 13|14| 15|
RST|QMC OPCODE| 1110|CHANNEL_NUMBER| -|FLG|
Extend the check command mask in order to support both the
standard CH_NUM field and the QMC extension CHANNEL_NUMBER
field.
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Acked-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
arch/powerpc/platforms/8xx/cpm1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/8xx/cpm1.c b/arch/powerpc/platforms/8xx/cpm1.c
index 8ef1f4392086..6b828b9f90d9 100644
--- a/arch/powerpc/platforms/8xx/cpm1.c
+++ b/arch/powerpc/platforms/8xx/cpm1.c
@@ -100,7 +100,7 @@ int cpm_command(u32 command, u8 opcode)
int i, ret;
unsigned long flags;
- if (command & 0xffffff0f)
+ if (command & 0xffffff03)
return -EINVAL;
spin_lock_irqsave(&cmd_lock, flags);
--
2.39.0
next prev parent reply other threads:[~2023-01-26 8:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 8:32 [PATCH v4 00/10] Add the PowerQUICC audio support using the QMC Herve Codina
2023-01-26 8:32 ` [PATCH v4 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller Herve Codina
2023-01-30 18:27 ` Rob Herring
2023-01-31 7:44 ` Herve Codina
2023-01-26 8:32 ` [PATCH v4 02/10] soc: fsl: cpm1: Add support for TSA Herve Codina
2023-02-15 16:10 ` Christophe Leroy
2023-01-26 8:32 ` [PATCH v4 03/10] MAINTAINERS: add the Freescale TSA controller entry Herve Codina
2023-01-26 8:32 ` Herve Codina [this message]
2023-01-26 9:59 ` [PATCH v4 04/10] powerpc/8xx: Use a larger CPM1 command check mask Michael Ellerman
2023-01-26 8:32 ` [PATCH v4 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Herve Codina
2023-01-30 18:30 ` Rob Herring
2023-01-31 7:45 ` Herve Codina
2023-01-26 8:32 ` [PATCH v4 06/10] soc: fsl: cmp1: Add support for QMC Herve Codina
2023-02-15 12:45 ` kernel test robot
2023-02-15 12:51 ` Christophe Leroy
2023-02-15 16:08 ` Christophe Leroy
2023-02-15 21:42 ` Leo Li
2023-02-15 22:44 ` Leo Li
2023-02-16 6:43 ` Christophe Leroy
2023-01-26 8:32 ` [PATCH v4 07/10] MAINTAINERS: add the Freescale QMC controller entry Herve Codina
2023-01-26 8:32 ` [PATCH v4 08/10] dt-bindings: sound: Add support for QMC audio Herve Codina
2023-01-26 8:32 ` [PATCH v4 09/10] ASoC: fsl: " Herve Codina
2023-01-26 8:32 ` [PATCH v4 10/10] MAINTAINERS: add the Freescale QMC audio entry Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126083222.374243-5-herve.codina@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nicoleotsuka@gmail.com \
--cc=npiggin@gmail.com \
--cc=perex@perex.cz \
--cc=qiang.zhao@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).