From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Leo Li <leoyang.li@nxp.com>,
Herve Codina <herve.codina@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Qiang Zhao <qiang.zhao@nxp.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v4 06/10] soc: fsl: cmp1: Add support for QMC
Date: Thu, 16 Feb 2023 06:43:54 +0000 [thread overview]
Message-ID: <a5a2ab44-2ec8-66a1-b249-88e41d3a30f9@csgroup.eu> (raw)
In-Reply-To: <AM0PR04MB6289BCED290AB979E0DEE3448FA39@AM0PR04MB6289.eurprd04.prod.outlook.com>
Le 15/02/2023 à 23:44, Leo Li a écrit :
>
>
>> -----Original Message-----
>> From: Herve Codina <herve.codina@bootlin.com>
>> Sent: Thursday, January 26, 2023 2:32 AM
>> To: Herve Codina <herve.codina@bootlin.com>; Leo Li
>> <leoyang.li@nxp.com>; Rob Herring <robh+dt@kernel.org>; Krzysztof
>> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Liam Girdwood
>> <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>; Christophe
>> Leroy <christophe.leroy@csgroup.eu>; Michael Ellerman
>> <mpe@ellerman.id.au>; Nicholas Piggin <npiggin@gmail.com>; Qiang Zhao
>> <qiang.zhao@nxp.com>; Jaroslav Kysela <perex@perex.cz>; Takashi Iwai
>> <tiwai@suse.com>; Shengjiu Wang <shengjiu.wang@gmail.com>; Xiubo Li
>> <Xiubo.Lee@gmail.com>; Fabio Estevam <festevam@gmail.com>; Nicolin
>> Chen <nicoleotsuka@gmail.com>
>> Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org;
>> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; alsa-devel@alsa-
>> project.org; Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>> Subject: [PATCH v4 06/10] soc: fsl: cmp1: Add support for QMC
>
> Typo: cpm1
>
>>
>> The QMC (QUICC Multichannel Controller) emulates up to 64 channels within
>> one serial controller using the same TDM physical interface routed from the
>> TSA.
>>
>> It is available in some PowerQUICC SoC such as the
>> MPC885 or MPC866.
>>
>> It is also available on some Quicc Engine SoCs.
>> This current version support CPM1 SoCs only and some enhancement are
>> needed to support Quicc Engine SoCs.
>>
>> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
>
> Otherwise looks good to me.
>
> Acked-by: Li Yang <leoyang.li@nxp.com>
Thanks for the review and the ack.
Were you also able to have a look at patch 2 which implements support
for the timeslot assigner (TSA) ?
Christophe
next prev parent reply other threads:[~2023-02-16 6:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 8:32 [PATCH v4 00/10] Add the PowerQUICC audio support using the QMC Herve Codina
2023-01-26 8:32 ` [PATCH v4 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller Herve Codina
2023-01-30 18:27 ` Rob Herring
2023-01-31 7:44 ` Herve Codina
2023-01-26 8:32 ` [PATCH v4 02/10] soc: fsl: cpm1: Add support for TSA Herve Codina
2023-02-15 16:10 ` Christophe Leroy
2023-01-26 8:32 ` [PATCH v4 03/10] MAINTAINERS: add the Freescale TSA controller entry Herve Codina
2023-01-26 8:32 ` [PATCH v4 04/10] powerpc/8xx: Use a larger CPM1 command check mask Herve Codina
2023-01-26 9:59 ` Michael Ellerman
2023-01-26 8:32 ` [PATCH v4 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Herve Codina
2023-01-30 18:30 ` Rob Herring
2023-01-31 7:45 ` Herve Codina
2023-01-26 8:32 ` [PATCH v4 06/10] soc: fsl: cmp1: Add support for QMC Herve Codina
2023-02-15 12:45 ` kernel test robot
2023-02-15 12:51 ` Christophe Leroy
2023-02-15 16:08 ` Christophe Leroy
2023-02-15 21:42 ` Leo Li
2023-02-15 22:44 ` Leo Li
2023-02-16 6:43 ` Christophe Leroy [this message]
2023-01-26 8:32 ` [PATCH v4 07/10] MAINTAINERS: add the Freescale QMC controller entry Herve Codina
2023-01-26 8:32 ` [PATCH v4 08/10] dt-bindings: sound: Add support for QMC audio Herve Codina
2023-01-26 8:32 ` [PATCH v4 09/10] ASoC: fsl: " Herve Codina
2023-01-26 8:32 ` [PATCH v4 10/10] MAINTAINERS: add the Freescale QMC audio entry Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5a2ab44-2ec8-66a1-b249-88e41d3a30f9@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nicoleotsuka@gmail.com \
--cc=npiggin@gmail.com \
--cc=perex@perex.cz \
--cc=qiang.zhao@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).