* [PATCH] soc: mediatek: mtk-svs: delete node name check
@ 2023-02-09 16:24 matthias.bgg
2023-02-10 12:01 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 4+ messages in thread
From: matthias.bgg @ 2023-02-09 16:24 UTC (permalink / raw)
To: matthias.bgg, roger.lu
Cc: nfraprado, linux-mediatek, linux-kernel, linux-arm-kernel,
angelogioacchino.delregno
From: Matthias Brugger <matthias.bgg@gmail.com>
The function svs_add_device_link is called only internally from the SoC
specific probe functions. We don't need to check if the node_name is
null because that would mean that we have a buggy SoC probe function in
the first place.
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
drivers/soc/mediatek/mtk-svs.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index 299f580847bdc..a7eb019b5157d 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -2027,11 +2027,6 @@ static struct device *svs_add_device_link(struct svs_platform *svsp,
struct device *dev;
struct device_link *sup_link;
- if (!node_name) {
- dev_err(svsp->dev, "node name cannot be null\n");
- return ERR_PTR(-EINVAL);
- }
-
dev = svs_get_subsys_device(svsp, node_name);
if (IS_ERR(dev))
return dev;
--
2.39.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: mediatek: mtk-svs: delete node name check
2023-02-09 16:24 [PATCH] soc: mediatek: mtk-svs: delete node name check matthias.bgg
@ 2023-02-10 12:01 ` AngeloGioacchino Del Regno
2023-02-11 11:37 ` Roger Lu (陸瑞傑)
0 siblings, 1 reply; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-02-10 12:01 UTC (permalink / raw)
To: matthias.bgg, matthias.bgg, roger.lu
Cc: nfraprado, linux-mediatek, linux-kernel, linux-arm-kernel
Il 09/02/23 17:24, matthias.bgg@kernel.org ha scritto:
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
> The function svs_add_device_link is called only internally from the SoC
> specific probe functions. We don't need to check if the node_name is
> null because that would mean that we have a buggy SoC probe function in
> the first place.
>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: mediatek: mtk-svs: delete node name check
2023-02-10 12:01 ` AngeloGioacchino Del Regno
@ 2023-02-11 11:37 ` Roger Lu (陸瑞傑)
2023-02-14 13:54 ` Matthias Brugger
0 siblings, 1 reply; 4+ messages in thread
From: Roger Lu (陸瑞傑) @ 2023-02-11 11:37 UTC (permalink / raw)
To: matthias.bgg, matthias.bgg, angelogioacchino.delregno
Cc: linux-arm-kernel, linux-kernel, linux-mediatek, nfraprado
On Fri, 2023-02-10 at 13:01 +0100, AngeloGioacchino Del Regno wrote:
> Il 09/02/23 17:24, matthias.bgg@kernel.org ha scritto:
> > From: Matthias Brugger <matthias.bgg@gmail.com>
> >
> > The function svs_add_device_link is called only internally from the SoC
> > specific probe functions. We don't need to check if the node_name is
> > null because that would mean that we have a buggy SoC probe function in
> > the first place.
> >
> > Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
Reviewed-by: Roger Lu <roger.lu@mediatek.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: mediatek: mtk-svs: delete node name check
2023-02-11 11:37 ` Roger Lu (陸瑞傑)
@ 2023-02-14 13:54 ` Matthias Brugger
0 siblings, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2023-02-14 13:54 UTC (permalink / raw)
To: Roger Lu (陸瑞傑),
matthias.bgg, angelogioacchino.delregno
Cc: linux-arm-kernel, linux-kernel, linux-mediatek, nfraprado
On 11/02/2023 12:37, Roger Lu (陸瑞傑) wrote:
> On Fri, 2023-02-10 at 13:01 +0100, AngeloGioacchino Del Regno wrote:
>> Il 09/02/23 17:24, matthias.bgg@kernel.org ha scritto:
>>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>>
>>> The function svs_add_device_link is called only internally from the SoC
>>> specific probe functions. We don't need to check if the node_name is
>>> null because that would mean that we have a buggy SoC probe function in
>>> the first place.
>>>
>>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> Reviewed-by: AngeloGioacchino Del Regno <
>> angelogioacchino.delregno@collabora.com>
>
> Reviewed-by: Roger Lu <roger.lu@mediatek.com>
Applied, thanks for the reviews.
Matthias
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-14 13:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-09 16:24 [PATCH] soc: mediatek: mtk-svs: delete node name check matthias.bgg
2023-02-10 12:01 ` AngeloGioacchino Del Regno
2023-02-11 11:37 ` Roger Lu (陸瑞傑)
2023-02-14 13:54 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).