* [PATCH] hwmon: gxp-fan-ctrl: use devm_platform_get_and_ioremap_resource()
@ 2023-02-08 7:46 ye.xingchen
2023-02-09 17:37 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: ye.xingchen @ 2023-02-08 7:46 UTC (permalink / raw)
To: nick.hawkins; +Cc: verdun, linux, jdelvare, linux-hwmon, linux-kernel
From: Ye Xingchen <ye.xingchen@zte.com.cn>
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
drivers/hwmon/gxp-fan-ctrl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hwmon/gxp-fan-ctrl.c b/drivers/hwmon/gxp-fan-ctrl.c
index 0e9225a8b805..0014b8b0fd41 100644
--- a/drivers/hwmon/gxp-fan-ctrl.c
+++ b/drivers/hwmon/gxp-fan-ctrl.c
@@ -199,7 +199,6 @@ static const struct hwmon_chip_info gxp_fan_ctrl_chip_info = {
static int gxp_fan_ctrl_probe(struct platform_device *pdev)
{
struct gxp_fan_ctrl_drvdata *drvdata;
- struct resource *res;
struct device *dev = &pdev->dev;
struct device *hwmon_dev;
@@ -208,8 +207,7 @@ static int gxp_fan_ctrl_probe(struct platform_device *pdev)
if (!drvdata)
return -ENOMEM;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- drvdata->base = devm_ioremap_resource(&pdev->dev, res);
+ drvdata->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(drvdata->base))
return dev_err_probe(dev, PTR_ERR(drvdata->base),
"failed to map base\n");
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: gxp-fan-ctrl: use devm_platform_get_and_ioremap_resource()
2023-02-08 7:46 [PATCH] hwmon: gxp-fan-ctrl: use devm_platform_get_and_ioremap_resource() ye.xingchen
@ 2023-02-09 17:37 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2023-02-09 17:37 UTC (permalink / raw)
To: ye.xingchen; +Cc: nick.hawkins, verdun, jdelvare, linux-hwmon, linux-kernel
On Wed, Feb 08, 2023 at 03:46:06PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/gxp-fan-ctrl.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/gxp-fan-ctrl.c b/drivers/hwmon/gxp-fan-ctrl.c
> index 0e9225a8b805..0014b8b0fd41 100644
> --- a/drivers/hwmon/gxp-fan-ctrl.c
> +++ b/drivers/hwmon/gxp-fan-ctrl.c
> @@ -199,7 +199,6 @@ static const struct hwmon_chip_info gxp_fan_ctrl_chip_info = {
> static int gxp_fan_ctrl_probe(struct platform_device *pdev)
> {
> struct gxp_fan_ctrl_drvdata *drvdata;
> - struct resource *res;
> struct device *dev = &pdev->dev;
> struct device *hwmon_dev;
>
> @@ -208,8 +207,7 @@ static int gxp_fan_ctrl_probe(struct platform_device *pdev)
> if (!drvdata)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - drvdata->base = devm_ioremap_resource(&pdev->dev, res);
> + drvdata->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> if (IS_ERR(drvdata->base))
> return dev_err_probe(dev, PTR_ERR(drvdata->base),
> "failed to map base\n");
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-09 17:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08 7:46 [PATCH] hwmon: gxp-fan-ctrl: use devm_platform_get_and_ioremap_resource() ye.xingchen
2023-02-09 17:37 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).