* [PATCH v2 1/1] dt-bindings: Fix multi pattern support in DT_SCHEMA_FILES
@ 2023-02-09 19:37 Cristian Ciocaltea
2023-02-15 18:19 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Cristian Ciocaltea @ 2023-02-09 19:37 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski; +Cc: devicetree, linux-kernel, kernel
DT_SCHEMA_FILES used to allow specifying a space separated list of file
paths, but the introduction of partial matches support broke this
feature:
$ make dtbs_check DT_SCHEMA_FILES="path/to/schema1.yaml path/to/schema2.yaml"
[...]
LINT Documentation/devicetree/bindings
usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [...]
[-v]
[FILE_OR_DIR ...]
yamllint: error: one of the arguments FILE_OR_DIR - is required
[...]
Restore the lost functionality by preparing a grep filter that is able
to handle multiple search patterns.
Additionally, as suggested by Rob, use ':' instead of ' ' as the
patterns separator char. Hence, the command above becomes:
$ make dtbs_check DT_SCHEMA_FILES="path/to/schema1.yaml:path/to/schema2.yaml"
Fixes: 309d955985ee ("dt-bindings: kbuild: Support partial matches with DT_SCHEMA_FILES")
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
Changes in v2:
- Use ':' instead of ' ' as the patterns separator char, per Rob's review
- Drop empty line between Fixes and Signed-off-by tags
Documentation/devicetree/bindings/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
index bf2d8a8ced77..8b395893bd85 100644
--- a/Documentation/devicetree/bindings/Makefile
+++ b/Documentation/devicetree/bindings/Makefile
@@ -28,7 +28,7 @@ $(obj)/%.example.dts: $(src)/%.yaml check_dtschema_version FORCE
find_all_cmd = find $(srctree)/$(src) \( -name '*.yaml' ! \
-name 'processed-schema*' \)
-find_cmd = $(find_all_cmd) | grep -F "$(DT_SCHEMA_FILES)"
+find_cmd = $(find_all_cmd) | grep -F -e "$(subst :," -e ",$(DT_SCHEMA_FILES))"
CHK_DT_DOCS := $(shell $(find_cmd))
quiet_cmd_yamllint = LINT $(src)
--
2.39.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: Fix multi pattern support in DT_SCHEMA_FILES
2023-02-09 19:37 [PATCH v2 1/1] dt-bindings: Fix multi pattern support in DT_SCHEMA_FILES Cristian Ciocaltea
@ 2023-02-15 18:19 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2023-02-15 18:19 UTC (permalink / raw)
To: Cristian Ciocaltea
Cc: linux-kernel, Rob Herring, Krzysztof Kozlowski, devicetree, kernel
On Thu, 09 Feb 2023 21:37:35 +0200, Cristian Ciocaltea wrote:
> DT_SCHEMA_FILES used to allow specifying a space separated list of file
> paths, but the introduction of partial matches support broke this
> feature:
>
> $ make dtbs_check DT_SCHEMA_FILES="path/to/schema1.yaml path/to/schema2.yaml"
> [...]
> LINT Documentation/devicetree/bindings
> usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [...]
> [-v]
> [FILE_OR_DIR ...]
> yamllint: error: one of the arguments FILE_OR_DIR - is required
> [...]
>
> Restore the lost functionality by preparing a grep filter that is able
> to handle multiple search patterns.
>
> Additionally, as suggested by Rob, use ':' instead of ' ' as the
> patterns separator char. Hence, the command above becomes:
>
> $ make dtbs_check DT_SCHEMA_FILES="path/to/schema1.yaml:path/to/schema2.yaml"
>
> Fixes: 309d955985ee ("dt-bindings: kbuild: Support partial matches with DT_SCHEMA_FILES")
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
> Changes in v2:
> - Use ':' instead of ' ' as the patterns separator char, per Rob's review
> - Drop empty line between Fixes and Signed-off-by tags
>
> Documentation/devicetree/bindings/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-15 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-09 19:37 [PATCH v2 1/1] dt-bindings: Fix multi pattern support in DT_SCHEMA_FILES Cristian Ciocaltea
2023-02-15 18:19 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).