* [PATCH v1 1/1] Documentation: firmware-guide: gpio-properties: Clarify Explicit and Implicit
@ 2023-02-13 13:28 Andy Shevchenko
2023-02-13 18:39 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2023-02-13 13:28 UTC (permalink / raw)
To: Andy Shevchenko, linux-gpio, linux-acpi, linux-kernel
Cc: Mika Westerberg, Rafael J. Wysocki, Len Brown, Linus Walleij,
Bartosz Golaszewski
Clarify the Explicit and Implicit meanings in the table of Pull Bias.
While at it, distinguish pull bias keywords used in ACPI by using bold
font in the table of the respective terms.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
.../firmware-guide/acpi/gpio-properties.rst | 25 +++++++++++--------
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/Documentation/firmware-guide/acpi/gpio-properties.rst b/Documentation/firmware-guide/acpi/gpio-properties.rst
index eaec732cc77c..ae87aa64cb7b 100644
--- a/Documentation/firmware-guide/acpi/gpio-properties.rst
+++ b/Documentation/firmware-guide/acpi/gpio-properties.rst
@@ -67,17 +67,20 @@ state of the output pin which driver should use during its initialization.
Linux tries to use common sense here and derives the state from the bias
and polarity settings. The table below shows the expectations:
-========= ============= ==============
-Pull Bias Polarity Requested...
-========= ============= ==============
-Implicit x AS IS (assumed firmware configured for us)
-Explicit x (no _DSD) as Pull Bias (Up == High, Down == Low),
- assuming non-active (Polarity = !Pull Bias)
-Down Low as low, assuming active
-Down High as low, assuming non-active
-Up Low as high, assuming non-active
-Up High as high, assuming active
-========= ============= ==============
+========= ============= ==============
+Pull Bias Polarity Requested...
+========= ============= ==============
+Implicit x AS IS (assumed firmware configured it for us)
+(**Default**)
+Explicit x (no _DSD) as Pull Bias (**Up** == high, **Down** == low),
+(**Up**, **Down**, assuming non-active (Polarity = !Pull Bias);
+ **None**) or AS IS (assumed firmware configured it for us)
+ with no Pull Bias
+**Down** Low as low, assuming active
+**Down** High as low, assuming non-active
+**Up** Low as high, assuming non-active
+**Up** High as high, assuming active
+========= ============= ==============
That said, for our above example the both GPIOs, since the bias setting
is explicit and _DSD is present, will be treated as active with a high
--
2.39.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] Documentation: firmware-guide: gpio-properties: Clarify Explicit and Implicit
2023-02-13 13:28 [PATCH v1 1/1] Documentation: firmware-guide: gpio-properties: Clarify Explicit and Implicit Andy Shevchenko
@ 2023-02-13 18:39 ` Rafael J. Wysocki
2023-02-13 18:55 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2023-02-13 18:39 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-gpio, linux-acpi, linux-kernel, Mika Westerberg,
Rafael J. Wysocki, Len Brown, Linus Walleij, Bartosz Golaszewski
On Mon, Feb 13, 2023 at 2:27 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Clarify the Explicit and Implicit meanings in the table of Pull Bias.
>
> While at it, distinguish pull bias keywords used in ACPI by using bold
> font in the table of the respective terms.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> .../firmware-guide/acpi/gpio-properties.rst | 25 +++++++++++--------
> 1 file changed, 14 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/firmware-guide/acpi/gpio-properties.rst b/Documentation/firmware-guide/acpi/gpio-properties.rst
> index eaec732cc77c..ae87aa64cb7b 100644
> --- a/Documentation/firmware-guide/acpi/gpio-properties.rst
> +++ b/Documentation/firmware-guide/acpi/gpio-properties.rst
> @@ -67,17 +67,20 @@ state of the output pin which driver should use during its initialization.
> Linux tries to use common sense here and derives the state from the bias
> and polarity settings. The table below shows the expectations:
>
> -========= ============= ==============
> -Pull Bias Polarity Requested...
> -========= ============= ==============
> -Implicit x AS IS (assumed firmware configured for us)
> -Explicit x (no _DSD) as Pull Bias (Up == High, Down == Low),
> - assuming non-active (Polarity = !Pull Bias)
> -Down Low as low, assuming active
> -Down High as low, assuming non-active
> -Up Low as high, assuming non-active
> -Up High as high, assuming active
> -========= ============= ==============
> +========= ============= ==============
> +Pull Bias Polarity Requested...
> +========= ============= ==============
> +Implicit x AS IS (assumed firmware configured it for us)
> +(**Default**)
> +Explicit x (no _DSD) as Pull Bias (**Up** == high, **Down** == low),
> +(**Up**, **Down**, assuming non-active (Polarity = !Pull Bias);
> + **None**) or AS IS (assumed firmware configured it for us)
> + with no Pull Bias
> +**Down** Low as low, assuming active
> +**Down** High as low, assuming non-active
> +**Up** Low as high, assuming non-active
> +**Up** High as high, assuming active
> +========= ============= ==============
>
> That said, for our above example the both GPIOs, since the bias setting
> is explicit and _DSD is present, will be treated as active with a high
> --
Applied as 6.3 material, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] Documentation: firmware-guide: gpio-properties: Clarify Explicit and Implicit
2023-02-13 18:39 ` Rafael J. Wysocki
@ 2023-02-13 18:55 ` Andy Shevchenko
2023-02-13 18:59 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2023-02-13 18:55 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: linux-gpio, linux-acpi, linux-kernel, Mika Westerberg, Len Brown,
Linus Walleij, Bartosz Golaszewski
On Mon, Feb 13, 2023 at 07:39:10PM +0100, Rafael J. Wysocki wrote:
> On Mon, Feb 13, 2023 at 2:27 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
...
> > That said, for our above example the both GPIOs, since the bias setting
> > is explicit and _DSD is present, will be treated as active with a high
>
> Applied as 6.3 material, thanks!
Can you withdraw it for now, please? It has some formatting issues.
I will fix and send a new version instead.
Thank you!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] Documentation: firmware-guide: gpio-properties: Clarify Explicit and Implicit
2023-02-13 18:55 ` Andy Shevchenko
@ 2023-02-13 18:59 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2023-02-13 18:59 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Rafael J. Wysocki, linux-gpio, linux-acpi, linux-kernel,
Mika Westerberg, Len Brown, Linus Walleij, Bartosz Golaszewski
On Mon, Feb 13, 2023 at 7:55 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Mon, Feb 13, 2023 at 07:39:10PM +0100, Rafael J. Wysocki wrote:
> > On Mon, Feb 13, 2023 at 2:27 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
>
> ...
>
> > > That said, for our above example the both GPIOs, since the bias setting
> > > is explicit and _DSD is present, will be treated as active with a high
> >
> > Applied as 6.3 material, thanks!
>
> Can you withdraw it for now, please? It has some formatting issues.
> I will fix and send a new version instead.
Sure.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-13 19:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-13 13:28 [PATCH v1 1/1] Documentation: firmware-guide: gpio-properties: Clarify Explicit and Implicit Andy Shevchenko
2023-02-13 18:39 ` Rafael J. Wysocki
2023-02-13 18:55 ` Andy Shevchenko
2023-02-13 18:59 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).