* [PATCH 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible
@ 2023-02-13 20:49 Konrad Dybcio
2023-02-13 20:49 ` [PATCH 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-02-13 20:49 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Konrad Dybcio, Sebastian Reichel, Rob Herring,
Krzysztof Kozlowski, linux-pm, devicetree, linux-kernel
Add a specific compatible for the coincell charger present on PM8998.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
.../bindings/power/supply/qcom,pm8941-coincell.yaml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
index 0450f4dd4e51..b7b58aed3f3c 100644
--- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
+++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
@@ -16,7 +16,13 @@ maintainers:
properties:
compatible:
- const: qcom,pm8941-coincell
+ oneOf:
+ - items:
+ - enum:
+ - qcom,pm8998-coincell
+ - const: qcom,pm8941-coincell
+
+ - const: qcom,pm8941-coincell
reg:
maxItems: 1
--
2.39.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties
2023-02-13 20:49 [PATCH 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Konrad Dybcio
@ 2023-02-13 20:49 ` Konrad Dybcio
2023-02-13 21:27 ` Sebastian Reichel
2023-02-13 20:49 ` [PATCH 3/3] arm64: dts: qcom: pm8998: Add a specific compatible for coincell chg Konrad Dybcio
2023-02-14 7:57 ` [PATCH 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Krzysztof Kozlowski
2 siblings, 1 reply; 7+ messages in thread
From: Konrad Dybcio @ 2023-02-13 20:49 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Konrad Dybcio, Sebastian Reichel, Rob Herring,
Krzysztof Kozlowski, linux-pm, devicetree, linux-kernel
It's fine for these properties to be absent, as the driver doesn't fail
without them and functions with settings inherited from the reset/previous
stage bootloader state.
Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
.../devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml | 2 --
1 file changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
index b7b58aed3f3c..d62e3af55560 100644
--- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
+++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
@@ -43,8 +43,6 @@ properties:
required:
- compatible
- reg
- - qcom,rset-ohms
- - qcom,vset-millivolts
additionalProperties: false
--
2.39.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: pm8998: Add a specific compatible for coincell chg
2023-02-13 20:49 [PATCH 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Konrad Dybcio
2023-02-13 20:49 ` [PATCH 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties Konrad Dybcio
@ 2023-02-13 20:49 ` Konrad Dybcio
2023-02-14 7:57 ` [PATCH 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Krzysztof Kozlowski
2 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-02-13 20:49 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
Cc: marijn.suijten, Konrad Dybcio, Sebastian Reichel, Rob Herring,
Krzysztof Kozlowski, linux-pm, devicetree, linux-kernel
Add a PM8998-specific compatibel to the coincell charger and keep the
PM8941 one as fallback.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
index adbba9f4089a..340033ac3186 100644
--- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
@@ -72,7 +72,7 @@ pm8998_temp: temp-alarm@2400 {
};
pm8998_coincell: charger@2800 {
- compatible = "qcom,pm8941-coincell";
+ compatible = "qcom,pm8998-coincell", "qcom,pm8941-coincell";
reg = <0x2800>;
status = "disabled";
--
2.39.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties
2023-02-13 20:49 ` [PATCH 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties Konrad Dybcio
@ 2023-02-13 21:27 ` Sebastian Reichel
2023-02-13 21:41 ` Konrad Dybcio
0 siblings, 1 reply; 7+ messages in thread
From: Sebastian Reichel @ 2023-02-13 21:27 UTC (permalink / raw)
To: Konrad Dybcio
Cc: linux-arm-msm, andersson, agross, krzysztof.kozlowski,
marijn.suijten, Rob Herring, Krzysztof Kozlowski, linux-pm,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]
Hi,
On Mon, Feb 13, 2023 at 09:49:49PM +0100, Konrad Dybcio wrote:
> It's fine for these properties to be absent, as the driver doesn't fail
> without them and functions with settings inherited from the reset/previous
> stage bootloader state.
>
> Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
Please update the description of these properties to describe the
default behaviour.
-- Sebastian
> .../devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> index b7b58aed3f3c..d62e3af55560 100644
> --- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
> @@ -43,8 +43,6 @@ properties:
> required:
> - compatible
> - reg
> - - qcom,rset-ohms
> - - qcom,vset-millivolts
>
> additionalProperties: false
>
> --
> 2.39.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties
2023-02-13 21:27 ` Sebastian Reichel
@ 2023-02-13 21:41 ` Konrad Dybcio
2023-02-13 22:45 ` Sebastian Reichel
0 siblings, 1 reply; 7+ messages in thread
From: Konrad Dybcio @ 2023-02-13 21:41 UTC (permalink / raw)
To: Sebastian Reichel
Cc: linux-arm-msm, andersson, agross, krzysztof.kozlowski,
marijn.suijten, Rob Herring, Krzysztof Kozlowski, linux-pm,
devicetree, linux-kernel
On 13.02.2023 22:27, Sebastian Reichel wrote:
> Hi,
>
> On Mon, Feb 13, 2023 at 09:49:49PM +0100, Konrad Dybcio wrote:
>> It's fine for these properties to be absent, as the driver doesn't fail
>> without them and functions with settings inherited from the reset/previous
>> stage bootloader state.
>>
>> Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>
> Please update the description of these properties to describe the
> default behaviour.
Not sure if there's any default behavior other than "go with
whatever was there previously, no matter how it got there".
Is it okay if I just add:
"If unspecified, inherit the bootloader configuration"
?
Konrad
>
> -- Sebastian
>
>> .../devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
>> index b7b58aed3f3c..d62e3af55560 100644
>> --- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
>> +++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml
>> @@ -43,8 +43,6 @@ properties:
>> required:
>> - compatible
>> - reg
>> - - qcom,rset-ohms
>> - - qcom,vset-millivolts
>>
>> additionalProperties: false
>>
>> --
>> 2.39.1
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties
2023-02-13 21:41 ` Konrad Dybcio
@ 2023-02-13 22:45 ` Sebastian Reichel
0 siblings, 0 replies; 7+ messages in thread
From: Sebastian Reichel @ 2023-02-13 22:45 UTC (permalink / raw)
To: Konrad Dybcio
Cc: linux-arm-msm, andersson, agross, krzysztof.kozlowski,
marijn.suijten, Rob Herring, Krzysztof Kozlowski, linux-pm,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
Hi,
On Mon, Feb 13, 2023 at 10:41:10PM +0100, Konrad Dybcio wrote:
> On 13.02.2023 22:27, Sebastian Reichel wrote:
> > On Mon, Feb 13, 2023 at 09:49:49PM +0100, Konrad Dybcio wrote:
> >> It's fine for these properties to be absent, as the driver doesn't fail
> >> without them and functions with settings inherited from the reset/previous
> >> stage bootloader state.
> >>
> >> Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> >> ---
> > Please update the description of these properties to describe the
> > default behaviour.
> Not sure if there's any default behavior other than "go with
> whatever was there previously, no matter how it got there".
I got that from the patch description, but that behaviour should be
described in the binding.
> Is it okay if I just add:
>
> "If unspecified, inherit the bootloader configuration"
Technically the bindings are also for bootloaders. I suggest:
If unspecified, inherit the previous configuration (e.g. from
bootloader or hardware default value).
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible
2023-02-13 20:49 [PATCH 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Konrad Dybcio
2023-02-13 20:49 ` [PATCH 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties Konrad Dybcio
2023-02-13 20:49 ` [PATCH 3/3] arm64: dts: qcom: pm8998: Add a specific compatible for coincell chg Konrad Dybcio
@ 2023-02-14 7:57 ` Krzysztof Kozlowski
2 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-14 7:57 UTC (permalink / raw)
To: Konrad Dybcio, linux-arm-msm, andersson, agross
Cc: marijn.suijten, Sebastian Reichel, Rob Herring,
Krzysztof Kozlowski, linux-pm, devicetree, linux-kernel
On 13/02/2023 21:49, Konrad Dybcio wrote:
> Add a specific compatible for the coincell charger present on PM8998.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-02-14 7:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-13 20:49 [PATCH 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Konrad Dybcio
2023-02-13 20:49 ` [PATCH 2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties Konrad Dybcio
2023-02-13 21:27 ` Sebastian Reichel
2023-02-13 21:41 ` Konrad Dybcio
2023-02-13 22:45 ` Sebastian Reichel
2023-02-13 20:49 ` [PATCH 3/3] arm64: dts: qcom: pm8998: Add a specific compatible for coincell chg Konrad Dybcio
2023-02-14 7:57 ` [PATCH 1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).