linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sched/psi: make psi_cgroups_enabled static
@ 2023-05-25 10:34 Miaohe Lin
  2023-05-25 17:43 ` Suren Baghdasaryan
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Miaohe Lin @ 2023-05-25 10:34 UTC (permalink / raw)
  To: hannes, surenb, mingo, peterz, juri.lelli, vincent.guittot
  Cc: dietmar.eggemann, rostedt, bsegall, mgorman, bristot, vschneid,
	linux-kernel, linmiaohe

The static key psi_cgroups_enabled is only used inside file psi.c.
Make it static.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 kernel/sched/psi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 81fca77397f6..2ccb0b2ebd78 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -140,7 +140,7 @@
 static int psi_bug __read_mostly;
 
 DEFINE_STATIC_KEY_FALSE(psi_disabled);
-DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
+static DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
 
 #ifdef CONFIG_PSI_DEFAULT_DISABLED
 static bool psi_enable;
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] sched/psi: make psi_cgroups_enabled static
  2023-05-25 10:34 [PATCH] sched/psi: make psi_cgroups_enabled static Miaohe Lin
@ 2023-05-25 17:43 ` Suren Baghdasaryan
  2023-05-25 17:49 ` Johannes Weiner
  2023-07-17 12:56 ` [tip: sched/core] " tip-bot2 for Miaohe Lin
  2 siblings, 0 replies; 6+ messages in thread
From: Suren Baghdasaryan @ 2023-05-25 17:43 UTC (permalink / raw)
  To: Miaohe Lin
  Cc: hannes, mingo, peterz, juri.lelli, vincent.guittot,
	dietmar.eggemann, rostedt, bsegall, mgorman, bristot, vschneid,
	linux-kernel

On Wed, May 24, 2023 at 7:43 PM Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> The static key psi_cgroups_enabled is only used inside file psi.c.
> Make it static.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Reviewed-by: Suren Baghdasaryan <surenb@google.com>

> ---
>  kernel/sched/psi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 81fca77397f6..2ccb0b2ebd78 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -140,7 +140,7 @@
>  static int psi_bug __read_mostly;
>
>  DEFINE_STATIC_KEY_FALSE(psi_disabled);
> -DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
> +static DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
>
>  #ifdef CONFIG_PSI_DEFAULT_DISABLED
>  static bool psi_enable;
> --
> 2.27.0
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] sched/psi: make psi_cgroups_enabled static
  2023-05-25 10:34 [PATCH] sched/psi: make psi_cgroups_enabled static Miaohe Lin
  2023-05-25 17:43 ` Suren Baghdasaryan
@ 2023-05-25 17:49 ` Johannes Weiner
  2023-06-17  2:01   ` Miaohe Lin
  2023-07-06 10:29   ` Peter Zijlstra
  2023-07-17 12:56 ` [tip: sched/core] " tip-bot2 for Miaohe Lin
  2 siblings, 2 replies; 6+ messages in thread
From: Johannes Weiner @ 2023-05-25 17:49 UTC (permalink / raw)
  To: Miaohe Lin
  Cc: surenb, mingo, peterz, juri.lelli, vincent.guittot,
	dietmar.eggemann, rostedt, bsegall, mgorman, bristot, vschneid,
	linux-kernel, Tom Rix

On Thu, May 25, 2023 at 06:34:28PM +0800, Miaohe Lin wrote:
> The static key psi_cgroups_enabled is only used inside file psi.c.
> Make it static.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

This was previously submitted by Tom:
https://lore.kernel.org/lkml/20230405163602.1939400-1-trix@redhat.com/

Peter, could you please pick this up?

Thanks!

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] sched/psi: make psi_cgroups_enabled static
  2023-05-25 17:49 ` Johannes Weiner
@ 2023-06-17  2:01   ` Miaohe Lin
  2023-07-06 10:29   ` Peter Zijlstra
  1 sibling, 0 replies; 6+ messages in thread
From: Miaohe Lin @ 2023-06-17  2:01 UTC (permalink / raw)
  To: Johannes Weiner
  Cc: surenb, mingo, peterz, juri.lelli, vincent.guittot,
	dietmar.eggemann, rostedt, bsegall, mgorman, bristot, vschneid,
	linux-kernel, Tom Rix

On 2023/5/26 1:49, Johannes Weiner wrote:
> On Thu, May 25, 2023 at 06:34:28PM +0800, Miaohe Lin wrote:
>> The static key psi_cgroups_enabled is only used inside file psi.c.
>> Make it static.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> 
> This was previously submitted by Tom:
> https://lore.kernel.org/lkml/20230405163602.1939400-1-trix@redhat.com/
> 
> Peter, could you please pick this up?
> 

friendly ping.. :)

> Thanks!
> .
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] sched/psi: make psi_cgroups_enabled static
  2023-05-25 17:49 ` Johannes Weiner
  2023-06-17  2:01   ` Miaohe Lin
@ 2023-07-06 10:29   ` Peter Zijlstra
  1 sibling, 0 replies; 6+ messages in thread
From: Peter Zijlstra @ 2023-07-06 10:29 UTC (permalink / raw)
  To: Johannes Weiner
  Cc: Miaohe Lin, surenb, mingo, juri.lelli, vincent.guittot,
	dietmar.eggemann, rostedt, bsegall, mgorman, bristot, vschneid,
	linux-kernel, Tom Rix

On Thu, May 25, 2023 at 01:49:37PM -0400, Johannes Weiner wrote:
> On Thu, May 25, 2023 at 06:34:28PM +0800, Miaohe Lin wrote:
> > The static key psi_cgroups_enabled is only used inside file psi.c.
> > Make it static.
> > 
> > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> 
> This was previously submitted by Tom:
> https://lore.kernel.org/lkml/20230405163602.1939400-1-trix@redhat.com/
> 
> Peter, could you please pick this up?

Found it, will queue after -rc1.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [tip: sched/core] sched/psi: make psi_cgroups_enabled static
  2023-05-25 10:34 [PATCH] sched/psi: make psi_cgroups_enabled static Miaohe Lin
  2023-05-25 17:43 ` Suren Baghdasaryan
  2023-05-25 17:49 ` Johannes Weiner
@ 2023-07-17 12:56 ` tip-bot2 for Miaohe Lin
  2 siblings, 0 replies; 6+ messages in thread
From: tip-bot2 for Miaohe Lin @ 2023-07-17 12:56 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Miaohe Lin, Peter Zijlstra (Intel),
	Suren Baghdasaryan, x86, linux-kernel

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     35cd21f6292c6656aaab6066a1fa13cd11ca27f5
Gitweb:        https://git.kernel.org/tip/35cd21f6292c6656aaab6066a1fa13cd11ca27f5
Author:        Miaohe Lin <linmiaohe@huawei.com>
AuthorDate:    Thu, 25 May 2023 18:34:28 +08:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Thu, 13 Jul 2023 15:21:50 +02:00

sched/psi: make psi_cgroups_enabled static

The static key psi_cgroups_enabled is only used inside file psi.c.
Make it static.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Suren Baghdasaryan <surenb@google.com>
Link: https://lore.kernel.org/r/20230525103428.49712-1-linmiaohe@huawei.com
---
 kernel/sched/psi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 81fca77..2ccb0b2 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -140,7 +140,7 @@
 static int psi_bug __read_mostly;
 
 DEFINE_STATIC_KEY_FALSE(psi_disabled);
-DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
+static DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
 
 #ifdef CONFIG_PSI_DEFAULT_DISABLED
 static bool psi_enable;

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-17 12:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-25 10:34 [PATCH] sched/psi: make psi_cgroups_enabled static Miaohe Lin
2023-05-25 17:43 ` Suren Baghdasaryan
2023-05-25 17:49 ` Johannes Weiner
2023-06-17  2:01   ` Miaohe Lin
2023-07-06 10:29   ` Peter Zijlstra
2023-07-17 12:56 ` [tip: sched/core] " tip-bot2 for Miaohe Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).