From: Mike Travis <mike.travis@hpe.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
x86-ml <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Dimitri Sivanich <sivanich@hpe.com>,
"Wahl, Steve" <steve.wahl@hpe.com>, Russ Anderson <rja@hpe.com>
Subject: Re: [GIT PULL] x86/platform updates for v5.10
Date: Tue, 13 Oct 2020 07:25:09 -0700 [thread overview]
Message-ID: <20e7f2da-793d-18f9-3345-45095383bdc6@hpe.com> (raw)
In-Reply-To: <93b52b3e-8eda-eb46-0feb-1c02c92d3819@hpe.com>
On 10/13/2020 6:37 AM, Mike Travis wrote:
>
>
> On 10/13/2020 6:29 AM, Borislav Petkov wrote:
>> On Tue, Oct 13, 2020 at 05:33:37AM -0700, Mike Travis wrote:
>>> I'm working on the correct code now, and I have UV4 & UV4A machine time
>>> starting at 7am (PDT) to test it. The UV5 simulator does not yet
>>> emulate
>>> console initiated NMI from the BMC.
>>
>> Ok, let me put it another way: is this simple fix good enough for now so
>> that it doesn't trigger the build error on Linus' tree or not? You can
>> take your time and do all kinds of fixing later but we need a minimal
>> fix *now*!
>>
>> Pretty please?
>>
>
> Yes, it does fix the compile error.
Turns out I was combining 3 different sources to determine if the NMI
INT occurred and I used the 1ULL << SHIFT to check each one. So the
MASK is indeed extraneous and can be removed. Tested and patch follows.
prev parent reply other threads:[~2020-10-13 14:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 10:10 [GIT PULL] x86/platform updates for v5.10 Borislav Petkov
2020-10-12 18:21 ` pr-tracker-bot
2020-10-12 21:10 ` Linus Torvalds
2020-10-12 21:15 ` Mike Travis
2020-10-12 21:27 ` Borislav Petkov
2020-10-12 21:42 ` Mike Travis
2020-10-12 21:46 ` Linus Torvalds
2020-10-12 21:56 ` Borislav Petkov
2020-10-12 22:00 ` Mike Travis
2020-10-12 21:58 ` Mike Travis
2020-10-13 11:11 ` Borislav Petkov
2020-10-13 12:33 ` Mike Travis
2020-10-13 13:29 ` Borislav Petkov
2020-10-13 13:37 ` Mike Travis
2020-10-13 14:25 ` Mike Travis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20e7f2da-793d-18f9-3345-45095383bdc6@hpe.com \
--to=mike.travis@hpe.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rja@hpe.com \
--cc=sivanich@hpe.com \
--cc=steve.wahl@hpe.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).