linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Mike Travis <mike.travis@hpe.com>
Cc: Borislav Petkov <bp@suse.de>, x86-ml <x86@kernel.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] x86/platform updates for v5.10
Date: Mon, 12 Oct 2020 14:46:10 -0700	[thread overview]
Message-ID: <CAHk-=wg6MBLPzRrRYGQ6EeoUGV+-MdMraFiUiiQyenVk=t6=Bw@mail.gmail.com> (raw)
In-Reply-To: <f778b25e-68e7-98ec-9032-b35696948405@hpe.com>

On Mon, Oct 12, 2020 at 2:42 PM Mike Travis <mike.travis@hpe.com> wrote:
>
> It should have been an unsigned long instead of an int as Linus
> suggested.  I'm not sure it's a write only variable as I think the mask
> is used to check if the interrupt occurred (I'll have to look closer).

At least "git grep" only shows two assignments to it.

Of course, that would miss any cases that play games with preprocessor
token pasting etc, so it's not entirely meaningful, but it's certainly
a hint..

And yes, I expect that the fix is to just make it "unsigned long", but
if it truly isn't actually used, maybe removal is better.

             Linus

  reply	other threads:[~2020-10-12 21:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12 10:10 [GIT PULL] x86/platform updates for v5.10 Borislav Petkov
2020-10-12 18:21 ` pr-tracker-bot
2020-10-12 21:10 ` Linus Torvalds
2020-10-12 21:15   ` Mike Travis
2020-10-12 21:27     ` Borislav Petkov
2020-10-12 21:42       ` Mike Travis
2020-10-12 21:46         ` Linus Torvalds [this message]
2020-10-12 21:56           ` Borislav Petkov
2020-10-12 22:00             ` Mike Travis
2020-10-12 21:58         ` Mike Travis
2020-10-13 11:11           ` Borislav Petkov
2020-10-13 12:33             ` Mike Travis
2020-10-13 13:29               ` Borislav Petkov
2020-10-13 13:37                 ` Mike Travis
2020-10-13 14:25                   ` Mike Travis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wg6MBLPzRrRYGQ6EeoUGV+-MdMraFiUiiQyenVk=t6=Bw@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=bp@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.travis@hpe.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).