* [PATCH] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE_CODED
@ 2024-03-28 13:18 Werner Sembach
2024-03-28 13:23 ` Paul Menzel
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Werner Sembach @ 2024-03-28 13:18 UTC (permalink / raw)
To: Marcel Holtmann, Luiz Augusto von Dentz
Cc: Christoffer Sandberg, Werner Sembach, linux-bluetooth, linux-kernel
From: Christoffer Sandberg <cs@tuxedo.de>
For HW variants 0x17, 0x18 and 0x19 LE Coded PHY causes scan and
connection issues when enabled. This patch disables it through
the existing quirk.
Signed-off-by: Christoffer Sandberg <cs@tuxedo.de>
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
Cc: <stable@vger.kernel.org>
---
drivers/bluetooth/btintel.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index cdc5c08824a0a..6dbfb74d0adf9 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -2881,6 +2881,8 @@ static int btintel_setup_combined(struct hci_dev *hdev)
case 0x17:
case 0x18:
case 0x19:
+ /* 0x17, 0x18 and 0x19 have issues when LE Coded PHY is enabled */
+ set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks);
case 0x1b:
case 0x1c:
/* Display version information of TLV type */
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE_CODED
2024-03-28 13:18 [PATCH] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE_CODED Werner Sembach
@ 2024-03-28 13:23 ` Paul Menzel
2024-04-02 9:17 ` Christoffer Sandberg
2024-03-28 14:17 ` Luiz Augusto von Dentz
2024-03-31 4:52 ` K, Kiran
2 siblings, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2024-03-28 13:23 UTC (permalink / raw)
To: Werner Sembach, Marcel Holtmann, Luiz Augusto von Dentz
Cc: Christoffer Sandberg, linux-bluetooth, linux-kernel
Dear Christoffer, dear Werner,
Thank you for the patch.
Am 28.03.24 um 14:18 schrieb Werner Sembach:
> From: Christoffer Sandberg <cs@tuxedo.de>
>
> For HW variants 0x17, 0x18 and 0x19 LE Coded PHY causes scan and
> connection issues when enabled. This patch disables it through
> the existing quirk.
It would fit in two lines with 75 characters per line.
On what hardware with what clients do you experience this exactly?
> Signed-off-by: Christoffer Sandberg <cs@tuxedo.de>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> Cc: <stable@vger.kernel.org>
> ---
> drivers/bluetooth/btintel.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index cdc5c08824a0a..6dbfb74d0adf9 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -2881,6 +2881,8 @@ static int btintel_setup_combined(struct hci_dev *hdev)
> case 0x17:
> case 0x18:
> case 0x19:
> + /* 0x17, 0x18 and 0x19 have issues when LE Coded PHY is enabled */
> + set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks);
> case 0x1b:
> case 0x1c:
> /* Display version information of TLV type */
Kind regards,
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE_CODED
2024-03-28 13:18 [PATCH] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE_CODED Werner Sembach
2024-03-28 13:23 ` Paul Menzel
@ 2024-03-28 14:17 ` Luiz Augusto von Dentz
2024-03-28 23:20 ` Werner Sembach
2024-03-31 4:52 ` K, Kiran
2 siblings, 1 reply; 6+ messages in thread
From: Luiz Augusto von Dentz @ 2024-03-28 14:17 UTC (permalink / raw)
To: Werner Sembach
Cc: Marcel Holtmann, Christoffer Sandberg, linux-bluetooth, linux-kernel
Hi Werner,
On Thu, Mar 28, 2024 at 9:18 AM Werner Sembach <wse@tuxedocomputers.com> wrote:
>
> From: Christoffer Sandberg <cs@tuxedo.de>
>
> For HW variants 0x17, 0x18 and 0x19 LE Coded PHY causes scan and
> connection issues when enabled. This patch disables it through
> the existing quirk.
>
> Signed-off-by: Christoffer Sandberg <cs@tuxedo.de>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> Cc: <stable@vger.kernel.org>
> ---
> drivers/bluetooth/btintel.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index cdc5c08824a0a..6dbfb74d0adf9 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -2881,6 +2881,8 @@ static int btintel_setup_combined(struct hci_dev *hdev)
> case 0x17:
> case 0x18:
> case 0x19:
> + /* 0x17, 0x18 and 0x19 have issues when LE Coded PHY is enabled */
> + set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks);
If it is just these 3 then we are missing a break here.
> case 0x1b:
> case 0x1c:
> /* Display version information of TLV type */
> --
> 2.34.1
>
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE_CODED
2024-03-28 14:17 ` Luiz Augusto von Dentz
@ 2024-03-28 23:20 ` Werner Sembach
0 siblings, 0 replies; 6+ messages in thread
From: Werner Sembach @ 2024-03-28 23:20 UTC (permalink / raw)
To: Luiz Augusto von Dentz
Cc: Marcel Holtmann, Christoffer Sandberg, linux-bluetooth, linux-kernel
Hi Luiz,
Am 28.03.24 um 15:17 schrieb Luiz Augusto von Dentz:
> Hi Werner,
>
> On Thu, Mar 28, 2024 at 9:18 AM Werner Sembach <wse@tuxedocomputers.com> wrote:
>> From: Christoffer Sandberg <cs@tuxedo.de>
>>
>> For HW variants 0x17, 0x18 and 0x19 LE Coded PHY causes scan and
>> connection issues when enabled. This patch disables it through
>> the existing quirk.
>>
>> Signed-off-by: Christoffer Sandberg <cs@tuxedo.de>
>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>> Cc: <stable@vger.kernel.org>
>> ---
>> drivers/bluetooth/btintel.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
>> index cdc5c08824a0a..6dbfb74d0adf9 100644
>> --- a/drivers/bluetooth/btintel.c
>> +++ b/drivers/bluetooth/btintel.c
>> @@ -2881,6 +2881,8 @@ static int btintel_setup_combined(struct hci_dev *hdev)
>> case 0x17:
>> case 0x18:
>> case 0x19:
>> + /* 0x17, 0x18 and 0x19 have issues when LE Coded PHY is enabled */
>> + set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks);
> If it is just these 3 then we are missing a break here.
The cases are not added by the patch, the fallthrough was here before. This
patch just adds this quirk for these 3 cases on top to the other things done
below, aka the fallthrough is intentional.
Best regards,
Werner
>
>> case 0x1b:
>> case 0x1c:
>> /* Display version information of TLV type */
>> --
>> 2.34.1
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE_CODED
2024-03-28 13:18 [PATCH] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE_CODED Werner Sembach
2024-03-28 13:23 ` Paul Menzel
2024-03-28 14:17 ` Luiz Augusto von Dentz
@ 2024-03-31 4:52 ` K, Kiran
2 siblings, 0 replies; 6+ messages in thread
From: K, Kiran @ 2024-03-31 4:52 UTC (permalink / raw)
To: Werner Sembach, Marcel Holtmann, Luiz Augusto von Dentz
Cc: Christoffer Sandberg, linux-bluetooth, linux-kernel
Hi Werner,
> -----Original Message-----
> From: Werner Sembach <wse@tuxedocomputers.com>
> Sent: Thursday, March 28, 2024 6:48 PM
> To: Marcel Holtmann <marcel@holtmann.org>; Luiz Augusto von Dentz
> <luiz.dentz@gmail.com>
> Cc: Christoffer Sandberg <cs@tuxedo.de>; Werner Sembach
> <wse@tuxedocomputers.com>; linux-bluetooth@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] Bluetooth: btintel: Add devices to
> HCI_QUIRK_BROKEN_LE_CODED
>
> From: Christoffer Sandberg <cs@tuxedo.de>
>
> For HW variants 0x17, 0x18 and 0x19 LE Coded PHY causes scan and
> connection issues when enabled. This patch disables it through the existing
> quirk.
>
Do see this issue with latest firmware ? Can you please share the firmware version you are using (share dmesg on system boot) ?
> Signed-off-by: Christoffer Sandberg <cs@tuxedo.de>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> Cc: <stable@vger.kernel.org>
> ---
> drivers/bluetooth/btintel.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index
> cdc5c08824a0a..6dbfb74d0adf9 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -2881,6 +2881,8 @@ static int btintel_setup_combined(struct hci_dev
> *hdev)
> case 0x17:
> case 0x18:
> case 0x19:
> + /* 0x17, 0x18 and 0x19 have issues when LE Coded PHY is
> enabled */
> + set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks);
> case 0x1b:
> case 0x1c:
> /* Display version information of TLV type */
> --
> 2.34.1
>
Thanks,
Kiran
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE_CODED
2024-03-28 13:23 ` Paul Menzel
@ 2024-04-02 9:17 ` Christoffer Sandberg
0 siblings, 0 replies; 6+ messages in thread
From: Christoffer Sandberg @ 2024-04-02 9:17 UTC (permalink / raw)
To: Paul Menzel
Cc: Werner Sembach, Marcel Holtmann, Luiz Augusto von Dentz,
Christoffer Sandberg, linux-bluetooth, linux-kernel
Dear Paul,
On 28.3.2024 14:23, Paul Menzel wrote:
> On what hardware with what clients do you experience this exactly?
>
The wifi/bluetooth modules AX201, AX210 and AX211 (cases 0x18, 0x17 and
0x19 respectively) used in various notebook devices started having
issues as of the patch that enabled le coded phy in the driver. (We also
use AX200, however without issue.)
Noted behaviour as of the issues: Device scan took longer and when it
did find a device connection often failed or timed out.
I do not know if a special type of bluetooth client is affected. It was
partially tested by looking at the difference in enumeration of the
current mix of bluetooth clients in the area (where you could clearly
see the difference at a glance) and with one specific device. A
bluetooth connected watercooling system (TUXEDO Aquaris or
LCT21001/LCT22002) where a test case showed the mentioned issues.
Best regards,
Christoffer
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-04-02 9:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-28 13:18 [PATCH] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE_CODED Werner Sembach
2024-03-28 13:23 ` Paul Menzel
2024-04-02 9:17 ` Christoffer Sandberg
2024-03-28 14:17 ` Luiz Augusto von Dentz
2024-03-28 23:20 ` Werner Sembach
2024-03-31 4:52 ` K, Kiran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).