* Re: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts
2013-01-18 0:39 [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts K. Y. Srinivasan
@ 2013-01-18 0:23 ` Greg KH
2013-01-18 1:07 ` KY Srinivasan
2013-01-18 13:10 ` Borislav Petkov
1 sibling, 1 reply; 11+ messages in thread
From: Greg KH @ 2013-01-18 0:23 UTC (permalink / raw)
To: K. Y. Srinivasan; +Cc: linux-kernel, devel, olaf, apw, jasowang, tglx
On Thu, Jan 17, 2013 at 04:39:37PM -0800, K. Y. Srinivasan wrote:
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
No changelog entry describing the patch?
> ---
> arch/x86/include/asm/irq_vectors.h | 2 +
> arch/x86/include/asm/mshyperv.h | 4 +++
> arch/x86/kernel/cpu/mshyperv.c | 39 ++++++++++++++++++++++++++++++++++++
> arch/x86/kernel/entry_32.S | 7 ++++++
> arch/x86/kernel/entry_64.S | 5 ++++
> 5 files changed, 57 insertions(+), 0 deletions(-)
This patch needs to go through the x86 maintainers, which you didn't
include all of on the To: line, any reason why?
greg k-h
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts
@ 2013-01-18 0:39 K. Y. Srinivasan
2013-01-18 0:23 ` Greg KH
2013-01-18 13:10 ` Borislav Petkov
0 siblings, 2 replies; 11+ messages in thread
From: K. Y. Srinivasan @ 2013-01-18 0:39 UTC (permalink / raw)
To: gregkh, linux-kernel, devel, olaf, apw, jasowang, tglx; +Cc: K. Y. Srinivasan
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
arch/x86/include/asm/irq_vectors.h | 2 +
arch/x86/include/asm/mshyperv.h | 4 +++
arch/x86/kernel/cpu/mshyperv.c | 39 ++++++++++++++++++++++++++++++++++++
arch/x86/kernel/entry_32.S | 7 ++++++
arch/x86/kernel/entry_64.S | 5 ++++
5 files changed, 57 insertions(+), 0 deletions(-)
diff --git a/arch/x86/include/asm/irq_vectors.h b/arch/x86/include/asm/irq_vectors.h
index 1508e51..c2ff239 100644
--- a/arch/x86/include/asm/irq_vectors.h
+++ b/arch/x86/include/asm/irq_vectors.h
@@ -112,6 +112,8 @@
/* Xen vector callback to receive events in a HVM domain */
#define XEN_HVM_EVTCHN_CALLBACK 0xf3
+/* Hyper-V vector callback to receive vmbus interrupts*/
+#define HYPER_V_CALLBACK_VECTOR 0xf2
/*
* Local APIC timer IRQ vector is on a different priority level,
* to work around the 'lost local interrupt if more than 2 IRQ
diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
index 79ce568..c2934be 100644
--- a/arch/x86/include/asm/mshyperv.h
+++ b/arch/x86/include/asm/mshyperv.h
@@ -11,4 +11,8 @@ struct ms_hyperv_info {
extern struct ms_hyperv_info ms_hyperv;
+void hyperv_callback_vector(void);
+void hyperv_vector_handler(struct pt_regs *regs);
+void hv_register_vmbus_handler(int irq, irq_handler_t handler);
+
#endif
diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
index 0a630dd..03be583 100644
--- a/arch/x86/kernel/cpu/mshyperv.c
+++ b/arch/x86/kernel/cpu/mshyperv.c
@@ -14,10 +14,15 @@
#include <linux/time.h>
#include <linux/clocksource.h>
#include <linux/module.h>
+#include <linux/hardirq.h>
+#include <linux/interrupt.h>
#include <asm/processor.h>
#include <asm/hypervisor.h>
#include <asm/hyperv.h>
#include <asm/mshyperv.h>
+#include <asm/desc.h>
+#include <asm/idle.h>
+#include <asm/irq_regs.h>
struct ms_hyperv_info ms_hyperv;
EXPORT_SYMBOL_GPL(ms_hyperv);
@@ -69,6 +74,11 @@ static void __init ms_hyperv_init_platform(void)
ms_hyperv.features, ms_hyperv.hints);
clocksource_register_hz(&hyperv_cs, NSEC_PER_SEC/100);
+
+ /*
+ * Setup the IDT for hypervisor callback.
+ */
+ alloc_intr_gate(HYPER_V_CALLBACK_VECTOR, hyperv_callback_vector);
}
const __refconst struct hypervisor_x86 x86_hyper_ms_hyperv = {
@@ -77,3 +87,32 @@ const __refconst struct hypervisor_x86 x86_hyper_ms_hyperv = {
.init_platform = ms_hyperv_init_platform,
};
EXPORT_SYMBOL(x86_hyper_ms_hyperv);
+
+static int vmbus_irq;
+static irq_handler_t vmbus_isr;
+
+void hv_register_vmbus_handler(int irq, irq_handler_t handler)
+{
+ vmbus_irq = irq;
+ vmbus_isr = handler;
+}
+EXPORT_SYMBOL_GPL(hv_register_vmbus_handler);
+
+void hyperv_vector_handler(struct pt_regs *regs)
+{
+ struct pt_regs *old_regs = set_irq_regs(regs);
+ struct irq_desc *desc;
+
+ irq_enter();
+#ifdef CONFIG_X86
+ exit_idle();
+#endif
+
+ desc = irq_to_desc(vmbus_irq);
+
+ if (desc)
+ generic_handle_irq_desc(vmbus_irq, desc);
+
+ irq_exit();
+ set_irq_regs(old_regs);
+}
diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
index e9dd4c4..7743876 100644
--- a/arch/x86/kernel/entry_32.S
+++ b/arch/x86/kernel/entry_32.S
@@ -1052,6 +1052,13 @@ BUILD_INTERRUPT3(xen_hvm_callback_vector, XEN_HVM_EVTCHN_CALLBACK,
#endif /* CONFIG_XEN */
+#if IS_ENABLED(CONFIG_HYPERV)
+
+BUILD_INTERRUPT3(hyperv_callback_vector, HYPER_V_CALLBACK_VECTOR,
+ hyperv_vector_handler)
+
+#endif /* CONFIG_HYPERV */
+
#ifdef CONFIG_FUNCTION_TRACER
#ifdef CONFIG_DYNAMIC_FTRACE
diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
index 1975122..a1cb724 100644
--- a/arch/x86/kernel/entry_64.S
+++ b/arch/x86/kernel/entry_64.S
@@ -1451,6 +1451,11 @@ apicinterrupt XEN_HVM_EVTCHN_CALLBACK \
#endif /* CONFIG_XEN */
+#if IS_ENABLED(CONFIG_HYPERV)
+apicinterrupt HYPER_V_CALLBACK_VECTOR \
+ hyperv_callback_vector hyperv_vector_handler
+#endif /* CONFIG_HYPERV */
+
/*
* Some functions should be protected against kprobes
*/
--
1.7.4.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* RE: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts
2013-01-18 0:23 ` Greg KH
@ 2013-01-18 1:07 ` KY Srinivasan
0 siblings, 0 replies; 11+ messages in thread
From: KY Srinivasan @ 2013-01-18 1:07 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel, devel, olaf, apw, jasowang, tglx
> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Thursday, January 17, 2013 7:24 PM
> To: KY Srinivasan
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; jasowang@redhat.com; tglx@linutronix.de
> Subject: Re: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special
> hypervisor interrupts
>
> On Thu, Jan 17, 2013 at 04:39:37PM -0800, K. Y. Srinivasan wrote:
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
>
> No changelog entry describing the patch?
I sent the wrong version of the patch by mistake. I will send the one with the changelog shortly.
>
> > ---
> > arch/x86/include/asm/irq_vectors.h | 2 +
> > arch/x86/include/asm/mshyperv.h | 4 +++
> > arch/x86/kernel/cpu/mshyperv.c | 39
> ++++++++++++++++++++++++++++++++++++
> > arch/x86/kernel/entry_32.S | 7 ++++++
> > arch/x86/kernel/entry_64.S | 5 ++++
> > 5 files changed, 57 insertions(+), 0 deletions(-)
>
> This patch needs to go through the x86 maintainers, which you didn't
> include all of on the To: line, any reason why?
I have included Thomas as this was an interrupt related patch. I will however include x86 maintainers
when I resend with the change log.
Thank you,
K. Y
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts
2013-01-18 0:39 [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts K. Y. Srinivasan
2013-01-18 0:23 ` Greg KH
@ 2013-01-18 13:10 ` Borislav Petkov
2013-01-18 15:27 ` KY Srinivasan
1 sibling, 1 reply; 11+ messages in thread
From: Borislav Petkov @ 2013-01-18 13:10 UTC (permalink / raw)
To: K. Y. Srinivasan
Cc: gregkh, linux-kernel, devel, olaf, apw, jasowang, tglx,
H. Peter Anvin, Ingo Molnar
On Thu, Jan 17, 2013 at 04:39:37PM -0800, K. Y. Srinivasan wrote:
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
> arch/x86/include/asm/irq_vectors.h | 2 +
> arch/x86/include/asm/mshyperv.h | 4 +++
> arch/x86/kernel/cpu/mshyperv.c | 39 ++++++++++++++++++++++++++++++++++++
> arch/x86/kernel/entry_32.S | 7 ++++++
> arch/x86/kernel/entry_64.S | 5 ++++
> 5 files changed, 57 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/include/asm/irq_vectors.h b/arch/x86/include/asm/irq_vectors.h
> index 1508e51..c2ff239 100644
> --- a/arch/x86/include/asm/irq_vectors.h
> +++ b/arch/x86/include/asm/irq_vectors.h
> @@ -112,6 +112,8 @@
> /* Xen vector callback to receive events in a HVM domain */
> #define XEN_HVM_EVTCHN_CALLBACK 0xf3
>
> +/* Hyper-V vector callback to receive vmbus interrupts*/
> +#define HYPER_V_CALLBACK_VECTOR 0xf2
Btw, could those hypervisor vectors be merged into one VIRT_INTR_VECTOR
and be shared between the hypervisors? I mean, you can't have a xen and
hyperv hypervisor running next to each other and fihgting over that
vector, right?
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts
2013-01-18 13:10 ` Borislav Petkov
@ 2013-01-18 15:27 ` KY Srinivasan
2013-01-22 22:20 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 11+ messages in thread
From: KY Srinivasan @ 2013-01-18 15:27 UTC (permalink / raw)
To: Borislav Petkov
Cc: gregkh, linux-kernel, devel, olaf, apw, jasowang, tglx,
H. Peter Anvin, Ingo Molnar, Konrad Wilk (konrad.wilk@oracle.com),
jeremy, Jan Beulich (JBeulich@suse.com)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2053 bytes --]
> -----Original Message-----
> From: Borislav Petkov [mailto:bp@alien8.de]
> Sent: Friday, January 18, 2013 8:11 AM
> To: KY Srinivasan
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> jasowang@redhat.com; tglx@linutronix.de; H. Peter Anvin; Ingo Molnar
> Subject: Re: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special
> hypervisor interrupts
>
> On Thu, Jan 17, 2013 at 04:39:37PM -0800, K. Y. Srinivasan wrote:
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> > arch/x86/include/asm/irq_vectors.h | 2 +
> > arch/x86/include/asm/mshyperv.h | 4 +++
> > arch/x86/kernel/cpu/mshyperv.c | 39
> ++++++++++++++++++++++++++++++++++++
> > arch/x86/kernel/entry_32.S | 7 ++++++
> > arch/x86/kernel/entry_64.S | 5 ++++
> > 5 files changed, 57 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/x86/include/asm/irq_vectors.h
> b/arch/x86/include/asm/irq_vectors.h
> > index 1508e51..c2ff239 100644
> > --- a/arch/x86/include/asm/irq_vectors.h
> > +++ b/arch/x86/include/asm/irq_vectors.h
> > @@ -112,6 +112,8 @@
> > /* Xen vector callback to receive events in a HVM domain */
> > #define XEN_HVM_EVTCHN_CALLBACK 0xf3
> >
> > +/* Hyper-V vector callback to receive vmbus interrupts*/
> > +#define HYPER_V_CALLBACK_VECTOR 0xf2
>
> Btw, could those hypervisor vectors be merged into one VIRT_INTR_VECTOR
> and be shared between the hypervisors? I mean, you can't have a xen and
> hyperv hypervisor running next to each other and fihgting over that
> vector, right?
You are right; we could just have one vector for this. Let me wait for other comments and
input from Xen maintainers before I make this change.
Regards,
K. Y
>
> --
> Regards/Gruss,
> Boris.
>
> Sent from a fat crate under my desk. Formatting is fine.
> --
>
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts
2013-01-18 15:27 ` KY Srinivasan
@ 2013-01-22 22:20 ` Konrad Rzeszutek Wilk
2013-01-22 23:19 ` H. Peter Anvin
0 siblings, 1 reply; 11+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-01-22 22:20 UTC (permalink / raw)
To: KY Srinivasan
Cc: Borislav Petkov, gregkh, linux-kernel, devel, olaf, apw,
jasowang, tglx, H. Peter Anvin, Ingo Molnar, jeremy,
Jan Beulich (JBeulich@suse.com)
On Fri, Jan 18, 2013 at 03:27:33PM +0000, KY Srinivasan wrote:
>
>
> > -----Original Message-----
> > From: Borislav Petkov [mailto:bp@alien8.de]
> > Sent: Friday, January 18, 2013 8:11 AM
> > To: KY Srinivasan
> > Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> > jasowang@redhat.com; tglx@linutronix.de; H. Peter Anvin; Ingo Molnar
> > Subject: Re: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special
> > hypervisor interrupts
> >
> > On Thu, Jan 17, 2013 at 04:39:37PM -0800, K. Y. Srinivasan wrote:
> > >
> > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > ---
> > > arch/x86/include/asm/irq_vectors.h | 2 +
> > > arch/x86/include/asm/mshyperv.h | 4 +++
> > > arch/x86/kernel/cpu/mshyperv.c | 39
> > ++++++++++++++++++++++++++++++++++++
> > > arch/x86/kernel/entry_32.S | 7 ++++++
> > > arch/x86/kernel/entry_64.S | 5 ++++
> > > 5 files changed, 57 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/x86/include/asm/irq_vectors.h
> > b/arch/x86/include/asm/irq_vectors.h
> > > index 1508e51..c2ff239 100644
> > > --- a/arch/x86/include/asm/irq_vectors.h
> > > +++ b/arch/x86/include/asm/irq_vectors.h
> > > @@ -112,6 +112,8 @@
> > > /* Xen vector callback to receive events in a HVM domain */
> > > #define XEN_HVM_EVTCHN_CALLBACK 0xf3
> > >
> > > +/* Hyper-V vector callback to receive vmbus interrupts*/
> > > +#define HYPER_V_CALLBACK_VECTOR 0xf2
> >
> > Btw, could those hypervisor vectors be merged into one VIRT_INTR_VECTOR
> > and be shared between the hypervisors? I mean, you can't have a xen and
> > hyperv hypervisor running next to each other and fihgting over that
> > vector, right?
>
> You are right; we could just have one vector for this. Let me wait for other comments and
> input from Xen maintainers before I make this change.
>
> Regards,
>
Looks OK to me.
> K. Y
> >
> > --
> > Regards/Gruss,
> > Boris.
> >
> > Sent from a fat crate under my desk. Formatting is fine.
> > --
> >
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts
2013-01-22 22:20 ` Konrad Rzeszutek Wilk
@ 2013-01-22 23:19 ` H. Peter Anvin
2013-01-23 15:37 ` Konrad Rzeszutek Wilk
2013-01-23 15:57 ` KY Srinivasan
0 siblings, 2 replies; 11+ messages in thread
From: H. Peter Anvin @ 2013-01-22 23:19 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, KY Srinivasan
Cc: Borislav Petkov, gregkh, linux-kernel, devel, olaf, apw,
jasowang, tglx, Ingo Molnar, jeremy,
Jan Beulich (JBeulich@suse.com)
Yes, how about we rename this the hypervisor vector...
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
>On Fri, Jan 18, 2013 at 03:27:33PM +0000, KY Srinivasan wrote:
>>
>>
>> > -----Original Message-----
>> > From: Borislav Petkov [mailto:bp@alien8.de]
>> > Sent: Friday, January 18, 2013 8:11 AM
>> > To: KY Srinivasan
>> > Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
>> > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
>> > jasowang@redhat.com; tglx@linutronix.de; H. Peter Anvin; Ingo
>Molnar
>> > Subject: Re: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as
>special
>> > hypervisor interrupts
>> >
>> > On Thu, Jan 17, 2013 at 04:39:37PM -0800, K. Y. Srinivasan wrote:
>> > >
>> > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
>> > > ---
>> > > arch/x86/include/asm/irq_vectors.h | 2 +
>> > > arch/x86/include/asm/mshyperv.h | 4 +++
>> > > arch/x86/kernel/cpu/mshyperv.c | 39
>> > ++++++++++++++++++++++++++++++++++++
>> > > arch/x86/kernel/entry_32.S | 7 ++++++
>> > > arch/x86/kernel/entry_64.S | 5 ++++
>> > > 5 files changed, 57 insertions(+), 0 deletions(-)
>> > >
>> > > diff --git a/arch/x86/include/asm/irq_vectors.h
>> > b/arch/x86/include/asm/irq_vectors.h
>> > > index 1508e51..c2ff239 100644
>> > > --- a/arch/x86/include/asm/irq_vectors.h
>> > > +++ b/arch/x86/include/asm/irq_vectors.h
>> > > @@ -112,6 +112,8 @@
>> > > /* Xen vector callback to receive events in a HVM domain */
>> > > #define XEN_HVM_EVTCHN_CALLBACK 0xf3
>> > >
>> > > +/* Hyper-V vector callback to receive vmbus interrupts*/
>> > > +#define HYPER_V_CALLBACK_VECTOR 0xf2
>> >
>> > Btw, could those hypervisor vectors be merged into one
>VIRT_INTR_VECTOR
>> > and be shared between the hypervisors? I mean, you can't have a xen
>and
>> > hyperv hypervisor running next to each other and fihgting over that
>> > vector, right?
>>
>> You are right; we could just have one vector for this. Let me wait
>for other comments and
>> input from Xen maintainers before I make this change.
>>
>> Regards,
>>
>
>Looks OK to me.
>
>> K. Y
>> >
>> > --
>> > Regards/Gruss,
>> > Boris.
>> >
>> > Sent from a fat crate under my desk. Formatting is fine.
>> > --
>> >
>>
--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts
2013-01-22 23:19 ` H. Peter Anvin
@ 2013-01-23 15:37 ` Konrad Rzeszutek Wilk
2013-01-23 16:04 ` H. Peter Anvin
2013-01-23 16:10 ` KY Srinivasan
2013-01-23 15:57 ` KY Srinivasan
1 sibling, 2 replies; 11+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-01-23 15:37 UTC (permalink / raw)
To: H. Peter Anvin
Cc: KY Srinivasan, Borislav Petkov, gregkh, linux-kernel, devel,
olaf, apw, jasowang, tglx, Ingo Molnar, jeremy,
Jan Beulich (JBeulich@suse.com)
On Tue, Jan 22, 2013 at 05:19:37PM -0600, H. Peter Anvin wrote:
> Yes, how about we rename this the hypervisor vector...
HYPERVISOR_CALLBACK_VECTOR ?
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts
2013-01-22 23:19 ` H. Peter Anvin
2013-01-23 15:37 ` Konrad Rzeszutek Wilk
@ 2013-01-23 15:57 ` KY Srinivasan
1 sibling, 0 replies; 11+ messages in thread
From: KY Srinivasan @ 2013-01-23 15:57 UTC (permalink / raw)
To: H. Peter Anvin, Konrad Rzeszutek Wilk
Cc: Borislav Petkov, gregkh, linux-kernel, devel, olaf, apw,
jasowang, tglx, Ingo Molnar, jeremy,
Jan Beulich (JBeulich@suse.com)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 3166 bytes --]
> -----Original Message-----
> From: H. Peter Anvin [mailto:hpa@zytor.com]
> Sent: Tuesday, January 22, 2013 6:20 PM
> To: Konrad Rzeszutek Wilk; KY Srinivasan
> Cc: Borislav Petkov; gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> jasowang@redhat.com; tglx@linutronix.de; Ingo Molnar; jeremy@goop.org; Jan
> Beulich (JBeulich@suse.com)
> Subject: Re: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special
> hypervisor interrupts
>
> Yes, how about we rename this the hypervisor vector...
Will do.
K. Y
>
> Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
>
> >On Fri, Jan 18, 2013 at 03:27:33PM +0000, KY Srinivasan wrote:
> >>
> >>
> >> > -----Original Message-----
> >> > From: Borislav Petkov [mailto:bp@alien8.de]
> >> > Sent: Friday, January 18, 2013 8:11 AM
> >> > To: KY Srinivasan
> >> > Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> >> > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> >> > jasowang@redhat.com; tglx@linutronix.de; H. Peter Anvin; Ingo
> >Molnar
> >> > Subject: Re: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as
> >special
> >> > hypervisor interrupts
> >> >
> >> > On Thu, Jan 17, 2013 at 04:39:37PM -0800, K. Y. Srinivasan wrote:
> >> > >
> >> > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> >> > > ---
> >> > > arch/x86/include/asm/irq_vectors.h | 2 +
> >> > > arch/x86/include/asm/mshyperv.h | 4 +++
> >> > > arch/x86/kernel/cpu/mshyperv.c | 39
> >> > ++++++++++++++++++++++++++++++++++++
> >> > > arch/x86/kernel/entry_32.S | 7 ++++++
> >> > > arch/x86/kernel/entry_64.S | 5 ++++
> >> > > 5 files changed, 57 insertions(+), 0 deletions(-)
> >> > >
> >> > > diff --git a/arch/x86/include/asm/irq_vectors.h
> >> > b/arch/x86/include/asm/irq_vectors.h
> >> > > index 1508e51..c2ff239 100644
> >> > > --- a/arch/x86/include/asm/irq_vectors.h
> >> > > +++ b/arch/x86/include/asm/irq_vectors.h
> >> > > @@ -112,6 +112,8 @@
> >> > > /* Xen vector callback to receive events in a HVM domain */
> >> > > #define XEN_HVM_EVTCHN_CALLBACK 0xf3
> >> > >
> >> > > +/* Hyper-V vector callback to receive vmbus interrupts*/
> >> > > +#define HYPER_V_CALLBACK_VECTOR 0xf2
> >> >
> >> > Btw, could those hypervisor vectors be merged into one
> >VIRT_INTR_VECTOR
> >> > and be shared between the hypervisors? I mean, you can't have a xen
> >and
> >> > hyperv hypervisor running next to each other and fihgting over that
> >> > vector, right?
> >>
> >> You are right; we could just have one vector for this. Let me wait
> >for other comments and
> >> input from Xen maintainers before I make this change.
> >>
> >> Regards,
> >>
> >
> >Looks OK to me.
> >
> >> K. Y
> >> >
> >> > --
> >> > Regards/Gruss,
> >> > Boris.
> >> >
> >> > Sent from a fat crate under my desk. Formatting is fine.
> >> > --
> >> >
> >>
>
> --
> Sent from my Android phone with K-9 Mail. Please excuse my brevity.
>
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts
2013-01-23 15:37 ` Konrad Rzeszutek Wilk
@ 2013-01-23 16:04 ` H. Peter Anvin
2013-01-23 16:10 ` KY Srinivasan
1 sibling, 0 replies; 11+ messages in thread
From: H. Peter Anvin @ 2013-01-23 16:04 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: KY Srinivasan, Borislav Petkov, gregkh, linux-kernel, devel,
olaf, apw, jasowang, tglx, Ingo Molnar, jeremy,
Jan Beulich (JBeulich@suse.com)
Sounds good to me.
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
>On Tue, Jan 22, 2013 at 05:19:37PM -0600, H. Peter Anvin wrote:
>> Yes, how about we rename this the hypervisor vector...
>
>HYPERVISOR_CALLBACK_VECTOR ?
--
Sent from my mobile phone. Please excuse brevity and lack of formatting.
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts
2013-01-23 15:37 ` Konrad Rzeszutek Wilk
2013-01-23 16:04 ` H. Peter Anvin
@ 2013-01-23 16:10 ` KY Srinivasan
1 sibling, 0 replies; 11+ messages in thread
From: KY Srinivasan @ 2013-01-23 16:10 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, H. Peter Anvin
Cc: Borislav Petkov, gregkh, linux-kernel, devel, olaf, apw,
jasowang, tglx, Ingo Molnar, jeremy,
Jan Beulich (JBeulich@suse.com)
> -----Original Message-----
> From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> Sent: Wednesday, January 23, 2013 10:37 AM
> To: H. Peter Anvin
> Cc: KY Srinivasan; Borislav Petkov; gregkh@linuxfoundation.org; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; jasowang@redhat.com; tglx@linutronix.de; Ingo Molnar;
> jeremy@goop.org; Jan Beulich (JBeulich@suse.com)
> Subject: Re: [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special
> hypervisor interrupts
>
> On Tue, Jan 22, 2013 at 05:19:37PM -0600, H. Peter Anvin wrote:
> > Yes, how about we rename this the hypervisor vector...
>
> HYPERVISOR_CALLBACK_VECTOR ?
Thanks Konrad. I will update the patch and send it out shortly.
Regards,
K. Y
>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2013-01-23 16:13 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-18 0:39 [PATCH 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts K. Y. Srinivasan
2013-01-18 0:23 ` Greg KH
2013-01-18 1:07 ` KY Srinivasan
2013-01-18 13:10 ` Borislav Petkov
2013-01-18 15:27 ` KY Srinivasan
2013-01-22 22:20 ` Konrad Rzeszutek Wilk
2013-01-22 23:19 ` H. Peter Anvin
2013-01-23 15:37 ` Konrad Rzeszutek Wilk
2013-01-23 16:04 ` H. Peter Anvin
2013-01-23 16:10 ` KY Srinivasan
2013-01-23 15:57 ` KY Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).