From: Akhil P Oommen <akhilpo@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
dri-devel@lists.freedesktop.org,
freedreno <freedreno@lists.freedesktop.org>,
linux-arm-msm@vger.kernel.org
Cc: Jonathan Marek <jonathan@marek.ca>,
linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Jordan Crouse <jordan@cosmicpenguin.net>,
Andy Gross <agross@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support
Date: Fri, 30 Jul 2021 00:27:23 +0530 [thread overview]
Message-ID: <308d8f1e-9f23-9d78-42cc-a42ce3463027@codeaurora.org> (raw)
In-Reply-To: <CAE-0n50-1eN3wwDukJi0JoTxCKnYx8NT1Ap2r0WDftQ621iBqQ@mail.gmail.com>
On 7/29/2021 10:46 PM, Stephen Boyd wrote:
> Quoting Akhil P Oommen (2021-07-28 00:17:45)
>> On 7/27/2021 5:46 AM, Stephen Boyd wrote:
>>> Quoting Akhil P Oommen (2021-07-24 10:29:00)
>>>> Add the necessary dt nodes for gpu support in sc7280.
>>>>
>>>> Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org>
>>>> ---
>>>> This patch has dependency on the GPUCC bindings patch here:
>>>> https://patchwork.kernel.org/project/linux-arm-msm/patch/1619519590-3019-4-git-send-email-tdas@codeaurora.org/
>>>
>>> To avoid the dependency the plain numbers can be used.
>>
>> But, won't that reduce readability and make things prone to error?
>
> The numbers are not supposed to change so maybe it reduces readability
> but I don't see how it is prone to error.
I cross check GPU's clock list whenever there is a system level issue
like NoC errors. So it is convenient to have the clock names here, at
least for me. But, I will budge if it is not easy to manage the dependency.
>
>> If
>> the other patch doesn't get picked up soon, we should try this option.
>> We like to get this patch merged in v5.15.
>
> The clk binding is already picked up but Bjorn would need to merge it
> into the qcom tree to use it. I don't know what the plan is there.
>
Bjorn, could you please advise here?
-Akhil.
next prev parent reply other threads:[~2021-07-29 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 17:29 [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support Akhil P Oommen
2021-07-27 0:16 ` Stephen Boyd
2021-07-28 7:17 ` Akhil P Oommen
2021-07-29 17:16 ` Stephen Boyd
2021-07-29 18:57 ` Akhil P Oommen [this message]
2021-07-29 19:02 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=308d8f1e-9f23-9d78-42cc-a42ce3463027@codeaurora.org \
--to=akhilpo@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=jordan@cosmicpenguin.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).