From: Jiri Slaby <jirislaby@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ralf Ramsauer <ralf.ramsauer@oth-regensburg.de>
Subject: Re: [PATCH v1 3/4] serial: 8250_pci: Always try MSI/MSI-X
Date: Wed, 14 Jul 2021 09:58:52 +0200 [thread overview]
Message-ID: <33767cf0-2104-d7aa-2da8-5a3f5f20a654@kernel.org> (raw)
In-Reply-To: <9af24b96-8119-7ccf-f0d0-d725af80aa0b@kernel.org>
On 14. 07. 21, 8:54, Jiri Slaby wrote:
>> @@ -3994,14 +3982,9 @@ pciserial_init_ports(struct pci_dev *dev, const
>> struct pciserial_board *board)
>> if (board->flags & FL_NOIRQ) {
>> uart.port.irq = 0;
>> } else {
>> - if (pci_match_id(pci_use_msi, dev)) {
>> - dev_dbg(&dev->dev, "Using MSI(-X) interrupts\n");
>> - pci_set_master(dev);
>> - rc = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_ALL_TYPES);
>> - } else {
>> - dev_dbg(&dev->dev, "Using legacy interrupts\n");
>> - rc = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_LEGACY);
>> - }
>> + pci_set_master(dev);
>
> But bus mastering is not about MSIs. I *think* it's still OK, but you
> need to document that in the commit log too.
>
> Actually, why the commit which added this code turns on bus mastering?
Forget about this line, I wasn't woken enough. Of course, MSI (writes)
to bus need bus mastering.
In any case, I'm still not sure what happens to devices which do not
support MSI if we enable mastering on them?
--
js
suse labs
next prev parent reply other threads:[~2021-07-14 7:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 10:40 [PATCH v1 1/4] serial: 8250_pci: Refactor the loop in pci_ite887x_init() Andy Shevchenko
2021-07-13 10:40 ` [PATCH v1 2/4] serial: 8250_pci: Get rid of redundant 'else' keyword Andy Shevchenko
2021-07-13 10:40 ` [PATCH v1 3/4] serial: 8250_pci: Always try MSI/MSI-X Andy Shevchenko
2021-07-14 6:54 ` Jiri Slaby
2021-07-14 7:58 ` Jiri Slaby [this message]
2021-07-14 9:31 ` Andy Shevchenko
2021-07-14 9:15 ` Andy Shevchenko
2021-07-14 16:56 ` rwright
2021-07-14 12:49 ` [EXT] " Ralf Ramsauer
2021-07-14 13:35 ` Andy Shevchenko
2021-07-14 16:49 ` Ralf Ramsauer
2021-07-16 13:07 ` Ralf Ramsauer
2021-07-16 15:01 ` Andy Shevchenko
2021-07-16 15:27 ` Ralf Ramsauer
2021-07-16 17:27 ` Andy Shevchenko
2021-07-17 12:44 ` Ralf Ramsauer
2021-07-13 10:40 ` [PATCH v1 4/4] serial: 8250_pci: Replace dev_*() by pci_*() macros Andy Shevchenko
2021-07-13 21:05 ` Joe Perches
2021-07-14 6:57 ` [PATCH v1 1/4] serial: 8250_pci: Refactor the loop in pci_ite887x_init() Jiri Slaby
2021-07-14 12:37 ` Andy Shevchenko
2021-07-14 8:07 ` Dan Carpenter
2021-07-14 10:44 ` Joe Perches
2021-07-14 12:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33767cf0-2104-d7aa-2da8-5a3f5f20a654@kernel.org \
--to=jirislaby@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ralf.ramsauer@oth-regensburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).