From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 4/4] serial: 8250_pci: Replace dev_*() by pci_*() macros
Date: Tue, 13 Jul 2021 14:05:27 -0700 [thread overview]
Message-ID: <8c2868969894ae5710147d3660e8442017438932.camel@perches.com> (raw)
In-Reply-To: <20210713104026.58560-4-andriy.shevchenko@linux.intel.com>
On Tue, 2021-07-13 at 13:40 +0300, Andy Shevchenko wrote:
> PCI subsystem provides convenient shortcut macros for message printing.
> Use those macros instead of dev_*().
[]
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
[]
> @@ -4147,8 +4139,7 @@ pciserial_init_one(struct pci_dev *dev, const struct pci_device_id *ent)
> sizeof(struct pciserial_board));
> rc = serial_pci_guess_board(dev, &tmp);
> if (rc == 0 && serial_pci_matches(board, &tmp))
> - moan_device("Redundant entry in serial pci_table.",
> - dev);
> + moan_device("Redundant entry in serial pci_table.", dev);
Unassociated change.
next prev parent reply other threads:[~2021-07-13 21:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 10:40 [PATCH v1 1/4] serial: 8250_pci: Refactor the loop in pci_ite887x_init() Andy Shevchenko
2021-07-13 10:40 ` [PATCH v1 2/4] serial: 8250_pci: Get rid of redundant 'else' keyword Andy Shevchenko
2021-07-13 10:40 ` [PATCH v1 3/4] serial: 8250_pci: Always try MSI/MSI-X Andy Shevchenko
2021-07-14 6:54 ` Jiri Slaby
2021-07-14 7:58 ` Jiri Slaby
2021-07-14 9:31 ` Andy Shevchenko
2021-07-14 9:15 ` Andy Shevchenko
2021-07-14 16:56 ` rwright
2021-07-14 12:49 ` [EXT] " Ralf Ramsauer
2021-07-14 13:35 ` Andy Shevchenko
2021-07-14 16:49 ` Ralf Ramsauer
2021-07-16 13:07 ` Ralf Ramsauer
2021-07-16 15:01 ` Andy Shevchenko
2021-07-16 15:27 ` Ralf Ramsauer
2021-07-16 17:27 ` Andy Shevchenko
2021-07-17 12:44 ` Ralf Ramsauer
2021-07-13 10:40 ` [PATCH v1 4/4] serial: 8250_pci: Replace dev_*() by pci_*() macros Andy Shevchenko
2021-07-13 21:05 ` Joe Perches [this message]
2021-07-14 6:57 ` [PATCH v1 1/4] serial: 8250_pci: Refactor the loop in pci_ite887x_init() Jiri Slaby
2021-07-14 12:37 ` Andy Shevchenko
2021-07-14 8:07 ` Dan Carpenter
2021-07-14 10:44 ` Joe Perches
2021-07-14 12:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c2868969894ae5710147d3660e8442017438932.camel@perches.com \
--to=joe@perches.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).