From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Thara Gopinath <thara.gopinath@linaro.org>,
mingo@redhat.com, peterz@infradead.org, ionela.voinescu@arm.com,
vincent.guittot@linaro.org, rui.zhang@intel.com,
edubezval@gmail.com, qperret@google.com
Cc: linux-kernel@vger.kernel.org, amit.kachhap@gmail.com,
javi.merino@kernel.org, daniel.lezcano@linaro.org
Subject: Re: [Patch v4 2/6] sched: Add infrastructure to store and update instantaneous thermal pressure
Date: Fri, 1 Nov 2019 13:17:27 +0100 [thread overview]
Message-ID: <379d23e5-79a5-9d90-0fb6-125d9be85e99@arm.com> (raw)
In-Reply-To: <1571776465-29763-3-git-send-email-thara.gopinath@linaro.org>
On 22.10.19 22:34, Thara Gopinath wrote:
[...]
> +/**
> + * trigger_thermal_pressure_average: Trigger the thermal pressure accumulate
> + * and average algorithm
> + */
> +void trigger_thermal_pressure_average(struct rq *rq)
> +{
> + update_thermal_load_avg(rq_clock_task(rq), rq,
> + per_cpu(delta_capacity, cpu_of(rq)));
> +}
Why not call update_thermal_load_avg() directly in fair.c? We do this for all
the other update_foo_load_avg() functions (foo eq. irq, rt_rq, dl_rq ...)
You don't have to pass 'u64 now', so you can hide it plus the
sched_thermal_decay_coeff add-on within update_thermal_load_avg().
(Similar to update_irq_load_avg()).
You could even hide 'u64 capacity' in it.
So we save one function layer (trigger_thermal_pressure_average()), thermal becomes
more aligned with the other PELT users when it comes to call-sites and we have less
code for this feature.
Something like this (only for 'u64 now' and only compile tested on arm64:
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index be3e802a2dc5..ac3ec3a04469 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -7576,7 +7576,7 @@ static void update_blocked_averages(int cpu)
update_blocked_load_status(rq, !done);
- trigger_thermal_pressure_average(rq);
+ update_thermal_load_avg(rq, per_cpu(delta_capacity, cpu_of(rq)));
rq_unlock_irqrestore(rq, &rf);
}
@@ -9938,7 +9938,7 @@ static void task_tick_fair(struct rq *rq, struct task_struct *curr, int queued)
update_misfit_status(curr, rq);
update_overutilized_status(task_rq(curr));
- trigger_thermal_pressure_average(rq);
+ update_thermal_load_avg(rq, per_cpu(delta_capacity, cpu_of(rq)));
}
/*
diff --git a/kernel/sched/pelt.c b/kernel/sched/pelt.c
index 38210691c615..7dd0d7e43854 100644
--- a/kernel/sched/pelt.c
+++ b/kernel/sched/pelt.c
@@ -353,8 +353,12 @@ int update_dl_rq_load_avg(u64 now, struct rq *rq, int running)
return 0;
}
-int update_thermal_load_avg(u64 now, struct rq *rq, u64 capacity)
+extern int sched_thermal_decay_coeff;
+
+int update_thermal_load_avg(struct rq *rq, u64 capacity)
{
+ u64 now = rq_clock_task(rq) >> sched_thermal_decay_coeff;
+
if (___update_load_sum(now, &rq->avg_thermal,
capacity,
capacity,
diff --git a/kernel/sched/pelt.h b/kernel/sched/pelt.h
index c74226de716e..91483c957b6c 100644
--- a/kernel/sched/pelt.h
+++ b/kernel/sched/pelt.h
@@ -6,7 +6,7 @@ int __update_load_avg_se(u64 now, struct cfs_rq *cfs_rq, struct sched_entity *se
int __update_load_avg_cfs_rq(u64 now, struct cfs_rq *cfs_rq);
int update_rt_rq_load_avg(u64 now, struct rq *rq, int running);
int update_dl_rq_load_avg(u64 now, struct rq *rq, int running);
-int update_thermal_load_avg(u64 now, struct rq *rq, u64 capacity);
+int update_thermal_load_avg(struct rq *rq, u64 capacity);
#ifdef CONFIG_HAVE_SCHED_AVG_IRQ
int update_irq_load_avg(struct rq *rq, u64 running);
diff --git a/kernel/sched/thermal.c b/kernel/sched/thermal.c
index 0da31e12a5ff..7b8c4e35c28d 100644
--- a/kernel/sched/thermal.c
+++ b/kernel/sched/thermal.c
@@ -21,7 +21,7 @@
* 3 256
* 4 512
*/
-static int sched_thermal_decay_coeff;
+int sched_thermal_decay_coeff;
static int __init setup_sched_thermal_decay_coeff(char *str)
{
@@ -32,7 +32,7 @@ static int __init setup_sched_thermal_decay_coeff(char *str)
}
__setup("sched_thermal_decay_coeff=", setup_sched_thermal_decay_coeff);
-static DEFINE_PER_CPU(unsigned long, delta_capacity);
+DEFINE_PER_CPU(unsigned long, delta_capacity);
/**
* update_thermal_pressure: Update thermal pressure
@@ -55,14 +55,3 @@ void update_thermal_pressure(int cpu, u64 capped_freq_ratio)
per_cpu(delta_capacity, cpu) = delta;
}
-
-/**
- * trigger_thermal_pressure_average: Trigger the thermal pressure accumulate
- * and average algorithm
- */
-void trigger_thermal_pressure_average(struct rq *rq)
-{
- update_thermal_load_avg(rq_clock_task(rq) >>
- sched_thermal_decay_coeff, rq,
- per_cpu(delta_capacity, cpu_of(rq)));
-}
diff --git a/kernel/sched/thermal.h b/kernel/sched/thermal.h
index 26e5b07e9c29..a6ee973db41b 100644
--- a/kernel/sched/thermal.h
+++ b/kernel/sched/thermal.h
@@ -2,12 +2,4 @@
/*
* Scheduler thermal interaction internal methods.
*/
-
-#ifdef CONFIG_SMP
-void trigger_thermal_pressure_average(struct rq *rq);
-
-#else
-static inline void trigger_thermal_pressure_average(struct rq *rq)
-{
-}
-#endif
+DECLARE_PER_CPU(unsigned long , delta_capacity);
next prev parent reply other threads:[~2019-11-01 12:17 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 20:34 [Patch v4 0/6] Introduce Thermal Pressure Thara Gopinath
2019-10-22 20:34 ` [Patch v4 1/6] sched/pelt.c: Add support to track thermal pressure Thara Gopinath
2019-10-31 9:47 ` Ionela Voinescu
2019-10-22 20:34 ` [Patch v4 2/6] sched: Add infrastructure to store and update instantaneous " Thara Gopinath
2019-10-28 15:21 ` Peter Zijlstra
2019-10-30 21:37 ` Thara Gopinath
2019-11-01 12:17 ` Dietmar Eggemann [this message]
2019-11-01 20:57 ` Thara Gopinath
2019-11-04 17:29 ` Dietmar Eggemann
2019-11-04 17:34 ` Vincent Guittot
2019-11-04 17:41 ` Dietmar Eggemann
2019-11-04 17:48 ` Vincent Guittot
2019-10-22 20:34 ` [Patch v4 3/6] sched/fair: Enable CFS periodic tick to update " Thara Gopinath
2019-10-28 15:24 ` Peter Zijlstra
2019-10-28 15:27 ` Peter Zijlstra
2019-10-30 21:41 ` Thara Gopinath
2019-10-31 16:11 ` Dietmar Eggemann
2019-10-31 16:46 ` Thara Gopinath
2019-10-22 20:34 ` [Patch v4 4/6] sched/fair: update cpu_capcity to reflect " Thara Gopinath
2019-10-23 12:28 ` Qais Yousef
2019-10-28 15:30 ` Peter Zijlstra
2019-10-31 10:53 ` Qais Yousef
2019-10-31 15:38 ` Dietmar Eggemann
2019-10-31 15:48 ` Vincent Guittot
2019-10-31 16:17 ` Dietmar Eggemann
2019-10-31 16:31 ` Vincent Guittot
2019-10-31 16:44 ` Dietmar Eggemann
2019-10-31 16:03 ` Thara Gopinath
2019-10-31 16:56 ` Qais Yousef
2019-10-22 20:34 ` [Patch v4 5/6] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping Thara Gopinath
2019-10-28 15:33 ` Peter Zijlstra
2019-10-31 16:29 ` Dietmar Eggemann
2019-10-31 16:38 ` Vincent Guittot
2019-11-01 15:47 ` Ionela Voinescu
2019-11-01 21:04 ` Thara Gopinath
2019-11-04 14:41 ` Ionela Voinescu
2019-10-31 16:46 ` Thara Gopinath
2019-10-22 20:34 ` [Patch v4 6/6] sched: thermal: Enable tuning of decay period Thara Gopinath
2019-10-28 15:42 ` Peter Zijlstra
2019-11-04 16:12 ` Ionela Voinescu
2019-11-05 20:26 ` Thara Gopinath
2019-11-05 21:29 ` Ionela Voinescu
2019-10-29 15:34 ` [Patch v4 0/6] Introduce Thermal Pressure Daniel Lezcano
2019-10-31 10:07 ` Ionela Voinescu
2019-10-31 11:54 ` Daniel Lezcano
2019-10-31 12:57 ` Ionela Voinescu
2019-10-31 17:48 ` Daniel Lezcano
2019-10-31 9:44 ` Ionela Voinescu
2019-10-31 16:41 ` Thara Gopinath
2019-10-31 16:52 ` Thara Gopinath
2019-11-05 21:04 ` Ionela Voinescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=379d23e5-79a5-9d90-0fb6-125d9be85e99@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).