From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Qais Yousef <qais.yousef@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Thara Gopinath <thara.gopinath@linaro.org>,
Ingo Molnar <mingo@redhat.com>,
Ionela Voinescu <ionela.voinescu@arm.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Quentin Perret <qperret@google.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Amit Kachhap <amit.kachhap@gmail.com>,
Javi Merino <javi.merino@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [Patch v4 4/6] sched/fair: update cpu_capcity to reflect thermal pressure
Date: Thu, 31 Oct 2019 17:44:44 +0100 [thread overview]
Message-ID: <aeb800c0-f23a-b9c3-6014-f5248f84adbd@arm.com> (raw)
In-Reply-To: <CAKfTPtCQe8qd1e5s-jf_5C7eaGVc7OYcXYgdvBK+ACF8aL7ByQ@mail.gmail.com>
On 31.10.19 17:31, Vincent Guittot wrote:
> On Thu, 31 Oct 2019 at 17:17, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>>
>> On 31.10.19 16:48, Vincent Guittot wrote:
>>> On Thu, 31 Oct 2019 at 16:38, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>>>>
>>>> On 31.10.19 11:53, Qais Yousef wrote:
>>>>> On 10/28/19 16:30, Peter Zijlstra wrote:
>>>>>> On Wed, Oct 23, 2019 at 01:28:40PM +0100, Qais Yousef wrote:
>>>>>>> On 10/22/19 16:34, Thara Gopinath wrote:
[...]
>>>> diff --git a/kernel/sched/pelt.c b/kernel/sched/pelt.c
>>>> index 38210691c615..d3035457483f 100644
>>>> --- a/kernel/sched/pelt.c
>>>> +++ b/kernel/sched/pelt.c
>>>> @@ -357,9 +357,9 @@ int update_thermal_load_avg(u64 now, struct rq *rq,
>>>> u64 capacity)
>>>> {
>>>> if (___update_load_sum(now, &rq->avg_thermal,
>>>> capacity,
>>>> - capacity,
>>>> - capacity)) {
>>>> - ___update_load_avg(&rq->avg_thermal, 1, 1);
>>>> + 0,
>>>> + 0)) {
>>>> + ___update_load_avg(&rq->avg_thermal, 1, 0);
>>>> return 1;
>>>> }
>>
>> So we could call it this way since we don't care about runnable_load or
>> util?
>
> one way or the other is quite similar but the current solution is
> aligned with other irq, rt, dl signals which duplicates the same state
> in each fields
I see. But there is a subtle difference. For irq, rt, dl, we have to
also set load (even we only use util) because of:
___update_load_sum() {
...
if (!load)
runnable = running = 0;
...
}
which is there for se's only.
I like self-explanatory code but I agree in this case it's not obvious.
next prev parent reply other threads:[~2019-10-31 16:44 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 20:34 [Patch v4 0/6] Introduce Thermal Pressure Thara Gopinath
2019-10-22 20:34 ` [Patch v4 1/6] sched/pelt.c: Add support to track thermal pressure Thara Gopinath
2019-10-31 9:47 ` Ionela Voinescu
2019-10-22 20:34 ` [Patch v4 2/6] sched: Add infrastructure to store and update instantaneous " Thara Gopinath
2019-10-28 15:21 ` Peter Zijlstra
2019-10-30 21:37 ` Thara Gopinath
2019-11-01 12:17 ` Dietmar Eggemann
2019-11-01 20:57 ` Thara Gopinath
2019-11-04 17:29 ` Dietmar Eggemann
2019-11-04 17:34 ` Vincent Guittot
2019-11-04 17:41 ` Dietmar Eggemann
2019-11-04 17:48 ` Vincent Guittot
2019-10-22 20:34 ` [Patch v4 3/6] sched/fair: Enable CFS periodic tick to update " Thara Gopinath
2019-10-28 15:24 ` Peter Zijlstra
2019-10-28 15:27 ` Peter Zijlstra
2019-10-30 21:41 ` Thara Gopinath
2019-10-31 16:11 ` Dietmar Eggemann
2019-10-31 16:46 ` Thara Gopinath
2019-10-22 20:34 ` [Patch v4 4/6] sched/fair: update cpu_capcity to reflect " Thara Gopinath
2019-10-23 12:28 ` Qais Yousef
2019-10-28 15:30 ` Peter Zijlstra
2019-10-31 10:53 ` Qais Yousef
2019-10-31 15:38 ` Dietmar Eggemann
2019-10-31 15:48 ` Vincent Guittot
2019-10-31 16:17 ` Dietmar Eggemann
2019-10-31 16:31 ` Vincent Guittot
2019-10-31 16:44 ` Dietmar Eggemann [this message]
2019-10-31 16:03 ` Thara Gopinath
2019-10-31 16:56 ` Qais Yousef
2019-10-22 20:34 ` [Patch v4 5/6] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping Thara Gopinath
2019-10-28 15:33 ` Peter Zijlstra
2019-10-31 16:29 ` Dietmar Eggemann
2019-10-31 16:38 ` Vincent Guittot
2019-11-01 15:47 ` Ionela Voinescu
2019-11-01 21:04 ` Thara Gopinath
2019-11-04 14:41 ` Ionela Voinescu
2019-10-31 16:46 ` Thara Gopinath
2019-10-22 20:34 ` [Patch v4 6/6] sched: thermal: Enable tuning of decay period Thara Gopinath
2019-10-28 15:42 ` Peter Zijlstra
2019-11-04 16:12 ` Ionela Voinescu
2019-11-05 20:26 ` Thara Gopinath
2019-11-05 21:29 ` Ionela Voinescu
2019-10-29 15:34 ` [Patch v4 0/6] Introduce Thermal Pressure Daniel Lezcano
2019-10-31 10:07 ` Ionela Voinescu
2019-10-31 11:54 ` Daniel Lezcano
2019-10-31 12:57 ` Ionela Voinescu
2019-10-31 17:48 ` Daniel Lezcano
2019-10-31 9:44 ` Ionela Voinescu
2019-10-31 16:41 ` Thara Gopinath
2019-10-31 16:52 ` Thara Gopinath
2019-11-05 21:04 ` Ionela Voinescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeb800c0-f23a-b9c3-6014-f5248f84adbd@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=qperret@google.com \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).