From: Taniya Das <tdas@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: David Brown <david.brown@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Gross <agross@kernel.org>,
devicetree@vger.kernel.org, robh@kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v2 4/4] clk: qcom: lpass: Add support for LPASS clock controller for SC7180
Date: Wed, 10 Jun 2020 22:41:49 +0530 [thread overview]
Message-ID: <3ac34bd7-bc5b-bc04-99ba-8ba3c5a9a691@codeaurora.org> (raw)
In-Reply-To: <159054904061.88029.1394425232497625411@swboyd.mtv.corp.google.com>
Thanks for your review.
On 5/27/2020 8:40 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2020-05-17 02:22:24)
>> diff --git a/drivers/clk/qcom/lpasscorecc-sc7180.c b/drivers/clk/qcom/lpasscorecc-sc7180.c
>> new file mode 100644
>> index 0000000..86e3599
>> --- /dev/null
>> +++ b/drivers/clk/qcom/lpasscorecc-sc7180.c
>> @@ -0,0 +1,479 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Copyright (c) 2020, The Linux Foundation. All rights reserved.
>> + */
>> +
>> +#include <linux/clk-provider.h>
>> +#include <linux/err.h>
>> +#include <linux/module.h>
>> +#include <linux/of_device.h>
>> +#include <linux/pm_clock.h>
>> +#include <linux/pm_runtime.h>
>> +#include <linux/of.h>
>> +#include <linux/regmap.h>
>> +
>> +#include <dt-bindings/clock/qcom,lpasscorecc-sc7180.h>
>> +
>> +#include "clk-alpha-pll.h"
>> +#include "clk-branch.h"
>> +#include "clk-rcg.h"
>> +#include "clk-regmap.h"
>> +#include "common.h"
>> +#include "gdsc.h"
>> +
>> +enum {
>> + P_BI_TCXO,
>> + P_LPASS_LPAAUDIO_DIG_PLL_OUT_ODD,
>> + P_SLEEP_CLK,
>> +};
>> +
>> +static struct pll_vco fabia_vco[] = {
>> + { 249600000, 2000000000, 0 },
>> +};
>> +
>> +static const struct alpha_pll_config lpass_lpaaudio_dig_pll_config = {
>> + .l = 0x20,
> [...]
>> +
>> +static struct regmap_config lpass_core_cc_sc7180_regmap_config = {
>> + .reg_bits = 32,
>> + .reg_stride = 4,
>> + .val_bits = 32,
>> + .fast_io = true,
>> +};
>> +
>> +static const struct qcom_cc_desc lpass_core_hm_sc7180_desc = {
>> + .config = &lpass_core_cc_sc7180_regmap_config,
>> + .gdscs = lpass_core_hm_sc7180_gdscs,
>> + .num_gdscs = ARRAY_SIZE(lpass_core_hm_sc7180_gdscs),
>> +};
>> +
>> +static const struct qcom_cc_desc lpass_core_cc_sc7180_desc = {
>> + .config = &lpass_core_cc_sc7180_regmap_config,
>> + .clks = lpass_core_cc_sc7180_clocks,
>> + .num_clks = ARRAY_SIZE(lpass_core_cc_sc7180_clocks),
>> +};
>> +
>> +static const struct qcom_cc_desc lpass_audio_hm_sc7180_desc = {
>> + .config = &lpass_core_cc_sc7180_regmap_config,
>> + .gdscs = lpass_audio_hm_sc7180_gdscs,
>> + .num_gdscs = ARRAY_SIZE(lpass_audio_hm_sc7180_gdscs),
>> +};
>> +
>> +
>
> Drop double newline please.
>
Done.
>> +static int lpass_core_cc_sc7180_probe(struct platform_device *pdev)
>> +{
>> + const struct qcom_cc_desc *desc;
>> + struct regmap *regmap;
>> + int ret;
>> +
>> + lpass_core_cc_sc7180_regmap_config.name = "lpass_audio_cc";
>> + desc = &lpass_audio_hm_sc7180_desc;
>> + ret = qcom_cc_probe_by_index(pdev, 1, desc);
>> + if (ret)
>> + return ret;
>> +
>> + lpass_core_cc_sc7180_regmap_config.name = "lpass_core_cc";
>> + regmap = qcom_cc_map(pdev, &lpass_core_cc_sc7180_desc);
>> + if (IS_ERR(regmap))
>> + return PTR_ERR(regmap);
>> +
>> + /*
>> + * Keep the CLK always-ON
>
> Why? Presumably to make sure we can access the lpass sysnoc path all the
> time?
>
This is an always ON clock from HW, just making sure to keep it enabled.
>> + * LPASS_AUDIO_CORE_SYSNOC_SWAY_CORE_CLK
>> + */
>> + regmap_update_bits(regmap, 0x24000, BIT(0), BIT(0));
>> +
>> + /* PLL settings */
>> + regmap_write(regmap, 0x1008, 0x20);
>> + regmap_update_bits(regmap, 0x1014, BIT(0), BIT(0));
>> +
>> + clk_fabia_pll_configure(&lpass_lpaaudio_dig_pll, regmap,
>> + &lpass_lpaaudio_dig_pll_config);
>> +
>> + return qcom_cc_really_probe(pdev, &lpass_core_cc_sc7180_desc, regmap);
>> +}
>> +
>> +static int lpass_hm_core_probe(struct platform_device *pdev)
>> +{
>> + const struct qcom_cc_desc *desc;
>> + int ret;
>> +
>> + lpass_core_cc_sc7180_regmap_config.name = "lpass_hm_core";
>> + desc = &lpass_core_hm_sc7180_desc;
>> +
>> + return qcom_cc_probe_by_index(pdev, 0, desc);
>> +}
>> +
>> +static const struct of_device_id lpass_core_cc_sc7180_match_table[] = {
>> + {
>> + .compatible = "qcom,sc7180-lpasshm",
>> + .data = lpass_hm_core_probe,
>> + },
>> + {
>> + .compatible = "qcom,sc7180-lpasscorecc",
>> + .data = lpass_core_cc_sc7180_probe,
>> + },
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(of, lpass_core_cc_sc7180_match_table);
>> +
>> +static int lpass_core_sc7180_probe(struct platform_device *pdev)
>> +{
>> + int (*clk_probe)(struct platform_device *p);
>> + int ret;
>> +
>> + pm_runtime_enable(&pdev->dev);
>> + ret = pm_clk_create(&pdev->dev);
>> + if (ret)
>> + return ret;
>> +
>> + ret = pm_clk_add(&pdev->dev, "gcc_lpass_sway");
>> + if (ret < 0) {
>> + dev_err(&pdev->dev, "failed to acquire iface clock\n");
>
> Can the clk name be 'iface' if it's actually the interface clk?
> "gcc_lpass_sway" looks to be the actual clk name which we shouldn't care
> about here. It should be whatever clk name we consider it to be, which
> would mean iface probably.
>
Yes would use "iface".
>> + goto disable_pm_runtime;
>> + }
>> +
>> + clk_probe = of_device_get_match_data(&pdev->dev);
>> + if (!clk_probe)
>> + return -EINVAL;
>> +
>> + ret = clk_probe(pdev);
>> + if (ret)
>> + goto destroy_pm_clk;
>> +
>> + return 0;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
next prev parent reply other threads:[~2020-06-10 17:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 9:22 [PATCH v2 0/4] clk: qcom: Support for Low Power Audio Clocks on SC7180 Taniya Das
2020-05-17 9:22 ` [PATCH v2 1/4] clk: qcom: gdsc: Add support to enable retention of GSDCR Taniya Das
2020-05-17 9:22 ` [PATCH v2 2/4] dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7180 Taniya Das
2020-05-27 3:11 ` Stephen Boyd
2020-06-10 17:07 ` Taniya Das
2020-05-28 20:25 ` Rob Herring
2020-06-10 17:09 ` Taniya Das
2020-05-17 9:22 ` [PATCH v2 3/4] clk: qcom: gcc: Add support for GCC LPASS clock for SC7180 Taniya Das
2020-05-17 9:22 ` [PATCH v2 4/4] clk: qcom: lpass: Add support for LPASS clock controller " Taniya Das
2020-05-27 3:10 ` Stephen Boyd
2020-06-10 17:11 ` Taniya Das [this message]
2020-06-11 1:06 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ac34bd7-bc5b-bc04-99ba-8ba3c5a9a691@codeaurora.org \
--to=tdas@codeaurora.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).