* [PATCH net-next] net: mvpp2: explicitly include linux/interrupt.h
@ 2018-07-09 15:00 Antoine Tenart
2018-07-09 16:28 ` [EXT] " Yan Markman
2018-07-12 5:57 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Antoine Tenart @ 2018-07-09 15:00 UTC (permalink / raw)
To: davem
Cc: Antoine Tenart, netdev, linux-kernel, thomas.petazzoni,
maxime.chevallier, gregory.clement, miquel.raynal, nadavh,
stefanc, ymarkman, mw
The Marvell PPv2 driver uses interrupts and tasklet but does not
explicitly include linux/interrupt.h, relying on implicit includes. This
one particularly is included by chance after a long unlogical chain of
inclusions. Fix this so we do not get future build breaks.
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
index 81a66cce7fa8..18834619bb3a 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
@@ -12,6 +12,7 @@
#ifndef _MVPP2_H_
#define _MVPP2_H_
+#include <linux/interrupt.h>
#include <linux/kernel.h>
#include <linux/netdevice.h>
#include <linux/phy.h>
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [EXT] [PATCH net-next] net: mvpp2: explicitly include linux/interrupt.h
2018-07-09 15:00 [PATCH net-next] net: mvpp2: explicitly include linux/interrupt.h Antoine Tenart
@ 2018-07-09 16:28 ` Yan Markman
2018-07-12 5:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Yan Markman @ 2018-07-09 16:28 UTC (permalink / raw)
To: Antoine Tenart, davem
Cc: netdev, linux-kernel, thomas.petazzoni, maxime.chevallier,
gregory.clement, miquel.raynal, Nadav Haklai, Stefan Chulski, mw
+10
Yan Markman
Tel. 05-44732819
-----Original Message-----
From: Antoine Tenart [mailto:antoine.tenart@bootlin.com]
Sent: Monday, July 09, 2018 6:01 PM
To: davem@davemloft.net
Cc: Antoine Tenart <antoine.tenart@bootlin.com>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; thomas.petazzoni@bootlin.com; maxime.chevallier@bootlin.com; gregory.clement@bootlin.com; miquel.raynal@bootlin.com; Nadav Haklai <nadavh@marvell.com>; Stefan Chulski <stefanc@marvell.com>; Yan Markman <ymarkman@marvell.com>; mw@semihalf.com
Subject: [EXT] [PATCH net-next] net: mvpp2: explicitly include linux/interrupt.h
External Email
----------------------------------------------------------------------
The Marvell PPv2 driver uses interrupts and tasklet but does not explicitly include linux/interrupt.h, relying on implicit includes. This one particularly is included by chance after a long unlogical chain of inclusions. Fix this so we do not get future build breaks.
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
index 81a66cce7fa8..18834619bb3a 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
@@ -12,6 +12,7 @@
#ifndef _MVPP2_H_
#define _MVPP2_H_
+#include <linux/interrupt.h>
#include <linux/kernel.h>
#include <linux/netdevice.h>
#include <linux/phy.h>
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: mvpp2: explicitly include linux/interrupt.h
2018-07-09 15:00 [PATCH net-next] net: mvpp2: explicitly include linux/interrupt.h Antoine Tenart
2018-07-09 16:28 ` [EXT] " Yan Markman
@ 2018-07-12 5:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-07-12 5:57 UTC (permalink / raw)
To: antoine.tenart
Cc: netdev, linux-kernel, thomas.petazzoni, maxime.chevallier,
gregory.clement, miquel.raynal, nadavh, stefanc, ymarkman, mw
From: Antoine Tenart <antoine.tenart@bootlin.com>
Date: Mon, 9 Jul 2018 17:00:43 +0200
> The Marvell PPv2 driver uses interrupts and tasklet but does not
> explicitly include linux/interrupt.h, relying on implicit includes. This
> one particularly is included by chance after a long unlogical chain of
> inclusions. Fix this so we do not get future build breaks.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-12 5:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-09 15:00 [PATCH net-next] net: mvpp2: explicitly include linux/interrupt.h Antoine Tenart
2018-07-09 16:28 ` [EXT] " Yan Markman
2018-07-12 5:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).