From: Maximilian Luz <luzmaximilian@gmail.com>
To: Yu Chen <yu.c.chen@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH v2 1/2] platform: Fix device check for surfacepro3_button
Date: Tue, 2 Jul 2019 04:04:37 +0200 [thread overview]
Message-ID: <3eab65a6-90d6-d598-2b16-805c28864716@gmail.com> (raw)
In-Reply-To: <20190702015717.GA20346@chenyu-office.sh.intel.com>
On 7/2/19 3:57 AM, Yu Chen wrote:
> How about using a boolean, according to the function name, if a mshw0040 revison
> is detected then returns true other wise false. Other than that,
> Acked-by: Chen Yu <yu.c.chen@intel.com>
I can change that if you want me to. Just thought this might be a bit
more flexible in case we ever have to adapt the check for future device
generations.
Thanks,
Maximilian
next prev parent reply other threads:[~2019-07-02 2:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 0:37 [PATCH 0/2] Support for buttons on newer MS Surface devices Maximilian Luz
2019-07-02 0:37 ` [PATCH v2 1/2] platform: Fix device check for surfacepro3_button Maximilian Luz
2019-07-02 1:14 ` Yu Chen
2019-07-02 1:25 ` Maximilian Luz
2019-07-02 1:33 ` Maximilian Luz
2019-07-02 1:57 ` Yu Chen
2019-07-02 2:04 ` Maximilian Luz [this message]
2019-07-18 17:43 ` Andy Shevchenko
2019-07-02 0:37 ` [PATCH v2 2/2] input: soc_button_array for newer surface devices Maximilian Luz
2019-07-04 15:31 ` Maximilian Luz
2019-07-16 7:21 ` Dmitry Torokhov
2019-07-16 18:19 ` Maximilian Luz
2019-07-16 20:18 ` Dmitry Torokhov
2019-07-17 19:23 ` Maximilian Luz
2019-07-02 17:13 ` [PATCH 0/2] Support for buttons on newer MS Surface devices Andy Shevchenko
2019-07-02 17:26 ` Maximilian Luz
2019-07-20 15:15 ` Maximilian Luz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3eab65a6-90d6-d598-2b16-805c28864716@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=andy@infradead.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).