From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Maximilian Luz <luzmaximilian@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Chen Yu <yu.c.chen@intel.com>, Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH 0/2] Support for buttons on newer MS Surface devices
Date: Tue, 2 Jul 2019 20:13:27 +0300 [thread overview]
Message-ID: <CAHp75Ve-f-piRxwG2u2djWGt2fUKkvZSDJ+XkjGKLmMZeLEYsw@mail.gmail.com> (raw)
In-Reply-To: <20190702003740.75970-1-luzmaximilian@gmail.com>
On Tue, Jul 2, 2019 at 3:38 AM Maximilian Luz <luzmaximilian@gmail.com> wrote:
>
> This series adds suport for power and volume buttons on 5th and 6th
> generation Microsoft Surface devices. Specifically, it adds support for
> the power-button on the Surface Laptop 1 and Laptop 2, as well as
> support for power- and (on-device) volume-buttons on the Surface Pro 5
> (2017), Pro 6, and Book 2.
>
> These devices use the same MSHW0040 device as on the Surface Pro 4,
> however, whereas the Pro 4 uses an ACPI notify handler, the newer
> devices use GPIO interrupts to signal these events.
>
> The first patch of this series ensures that the surfacepro3_button
> driver, used for MSHW0040 on the Pro 4, does not probe for the newer
> devices. The second patch adapts soc_button_array to implement the
> actual button support.
>
> I think the changes to soc_button_array in the second patch warrant a
> thorough review. I've tried to make things a bit more generic to be able
> to integrate arbitrary ACPI GPIO power-/volume-button devices more
> easily, I'm not sure if there may be reasons against this.
>
> These patches have also been tested on various Surface devices via the
> github.com/jakeday/linux-surface patchset.
>
> Changes since v1:
> - [PATCH 1/2] platform: Fix device check for surfacepro3_button
> No changes.
>
> - [PATCH 2/2] input: soc_button_array for newer surface devices
> Ensure the patch compiles without CONFIG_ACPI.
I re-pushed to my queue, though if you are going to send a new
version, check my repository for the titles of the patches (you need
to use correct templates for the subsystems).
>
> Maximilian Luz (2):
> platform: Fix device check for surfacepro3_button
> input: soc_button_array for newer surface devices
>
> drivers/input/misc/soc_button_array.c | 145 ++++++++++++++++++++--
> drivers/platform/x86/surfacepro3_button.c | 38 ++++++
> 2 files changed, 171 insertions(+), 12 deletions(-)
>
> --
> 2.22.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-07-02 17:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 0:37 [PATCH 0/2] Support for buttons on newer MS Surface devices Maximilian Luz
2019-07-02 0:37 ` [PATCH v2 1/2] platform: Fix device check for surfacepro3_button Maximilian Luz
2019-07-02 1:14 ` Yu Chen
2019-07-02 1:25 ` Maximilian Luz
2019-07-02 1:33 ` Maximilian Luz
2019-07-02 1:57 ` Yu Chen
2019-07-02 2:04 ` Maximilian Luz
2019-07-18 17:43 ` Andy Shevchenko
2019-07-02 0:37 ` [PATCH v2 2/2] input: soc_button_array for newer surface devices Maximilian Luz
2019-07-04 15:31 ` Maximilian Luz
2019-07-16 7:21 ` Dmitry Torokhov
2019-07-16 18:19 ` Maximilian Luz
2019-07-16 20:18 ` Dmitry Torokhov
2019-07-17 19:23 ` Maximilian Luz
2019-07-02 17:13 ` Andy Shevchenko [this message]
2019-07-02 17:26 ` [PATCH 0/2] Support for buttons on newer MS Surface devices Maximilian Luz
2019-07-20 15:15 ` Maximilian Luz
-- strict thread matches above, loose matches on Subject: below --
2019-06-20 11:50 Maximilian Luz
2019-06-29 14:18 ` Andy Shevchenko
2019-07-02 0:43 ` Maximilian Luz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Ve-f-piRxwG2u2djWGt2fUKkvZSDJ+XkjGKLmMZeLEYsw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).